UniSharp\Uploadable\Traits\WithImages

Complexity

Total Complexity

4

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Test Coverage

Coverage

90.91%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	bootWithImages()	0	5	1
A	images()	0	3	1
A	image()	0	3	1
A	bindImage()	0	3	1

<?php

This file is missing a doc comment.

The PHP open tag does not have a corresponding PHP close tag

Filename "WithImages.php" doesn't match the expected filename "withimages.php"

Missing file doc comment

namespace UniSharp\Uploadable\Traits;

use UniSharp\Uploadable\File;
use UniSharp\Uploadable\Image;
use Illuminate\Database\Eloquent\Relations\MorphOne;
use Illuminate\Database\Eloquent\Relations\MorphMany;

trait WithImages

Missing class doc comment

{

Opening brace should be on the same line as the declaration for trait WithImages

    use Helpers;

    public static function bootWithImages(): void

Expected 2 blank lines before function; 1 found

Missing function doc comment

    {

Opening brace should be on the same line as the declaration

        static::deleted(function ($model) {

The opening parenthesis of a multi-line function call should be the last content on the line.

            $model->images->each(function ($image) {

The opening parenthesis of a multi-line function call should be the last content on the line.

                $image->delete();
            });

For multi-line function calls, the closing parenthesis should be on a new line.

        });

For multi-line function calls, the closing parenthesis should be on a new line.

    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end bootWithImages()

    public function image(): MorphOne

Missing function doc comment

    {

Opening brace should be on the same line as the declaration

        return $this->morphOne(Image::class, 'uploadable')->whereNull('extra')->latest('id');

It seems like morphOne() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end image()

    public function images(): MorphMany

Missing function doc comment

    {

Opening brace should be on the same line as the declaration

        return $this->morphMany(Image::class, 'uploadable');

It seems like morphMany() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end images()

    public function bindImage(File $image, $extra = null): self

Missing function doc comment

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of null please use NULL.

    {

Opening brace should be on the same line as the declaration

        return $this->bindUploadable($image, $extra);
    }

Expected 2 blank lines after function; 0 found

Expected 1 blank line before closing function brace; 0 found

Expected //end bindImage()

}

As per coding style, files should not end with a newline character.