Conditions | 9 |
Paths | 52 |
Total Lines | 59 |
Code Lines | 35 |
Lines | 0 |
Ratio | 0 % |
Changes | 5 | ||
Bugs | 3 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
16 | public function getRename() |
||
17 | { |
||
18 | $old_name = $this->helper->input('file'); |
||
19 | $new_name = $this->helper->input('new_name'); |
||
20 | |||
21 | $file = $this->lfm->setName($old_name); |
||
22 | |||
23 | if (!Storage::disk($this->helper->config('disk'))->exists($file->path('storage'))) { |
||
24 | abort(404); |
||
25 | } |
||
26 | |||
27 | $old_file = $this->lfm->pretty($old_name); |
||
28 | |||
29 | $is_directory = $file->isDirectory(); |
||
30 | |||
31 | if (empty($new_name)) { |
||
32 | if ($is_directory) { |
||
33 | return parent::error('folder-name'); |
||
34 | } else { |
||
35 | return parent::error('file-name'); |
||
36 | } |
||
37 | } |
||
38 | |||
39 | $new_name = Str::slug($new_name, '_'); |
||
40 | |||
41 | if (! $is_directory) { |
||
42 | $extension = $old_file->extension(); |
||
43 | if ($extension) { |
||
44 | $new_name = str_replace('.' . $extension, '', $new_name) . '.' . $extension; |
||
45 | } |
||
46 | } |
||
47 | |||
48 | $new_path = $this->lfm->setName($new_name)->path('absolute'); |
||
49 | |||
50 | if ($is_directory) { |
||
51 | event(new FolderIsRenaming($old_file->path(), $new_path)); |
||
52 | } else { |
||
53 | event(new FileIsRenaming($old_file->path(), $new_path)); |
||
54 | event(new ImageIsRenaming($old_file->path(), $new_path)); |
||
55 | } |
||
56 | |||
57 | $old_path = $old_file->path(); |
||
58 | |||
59 | if ($old_file->hasThumb()) { |
||
60 | $this->lfm->setName($old_name)->thumb() |
||
61 | ->move($this->lfm->setName($new_name)->thumb()); |
||
62 | } |
||
63 | |||
64 | $this->lfm->setName($old_name) |
||
65 | ->move($this->lfm->setName($new_name)); |
||
66 | |||
67 | if ($is_directory) { |
||
68 | event(new FolderWasRenamed($old_path, $new_path)); |
||
69 | } else { |
||
70 | event(new FileWasRenamed($old_path, $new_path)); |
||
71 | event(new ImageWasRenamed($old_path, $new_path)); |
||
72 | } |
||
73 | |||
74 | return parent::$success_response; |
||
75 | } |
||
77 |