ItemsController::getItems() - Code Metrics - Inspection of "Added simple search function" - UniSharp/laravel-filemanager - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#995)

unknown

created 2020-10-20 12:57 UTC

ItemsController::getItems() A

↳ Parent: ItemsController

Complexity

Conditions	3
Paths	2

Size

Total Lines	67
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes	9
Bugs	0	Features	0

Metric	Value
cc	3
eloc	20
c	9
b	0
f	0
nc	2
nop	1
dl	0
loc	67
rs	9.6

How to fix Long Method

<?php

namespace UniSharp\LaravelFilemanager\Controllers;

use Illuminate\Http\Request;

use UniSharp\LaravelFilemanager\Events\FileIsMoving;
use UniSharp\LaravelFilemanager\Events\FileWasMoving;
use UniSharp\LaravelFilemanager\Events\FolderIsMoving;
use UniSharp\LaravelFilemanager\Events\FolderWasMoving;

class ItemsController extends LfmController
{
    /**
     * Get the images to load for a selected folder.
     *
     * @return mixed
     */
    public function getItems(Request $request)
    {
        /*$currentPage = self::getCurrentPageFromRequest();
        $keyword = $request->keyword;

        $perPage = $this->helper->getPaginationPerPage();
        $items = array_merge($this->lfm->folders(), $this->lfm->files());

        $items = array_map(function ($item) {
            return $item->fill()->attributes;
        }, array_slice($items, ($currentPage - 1) * $perPage, $perPage));

        $c = count($items);

        if (!empty($keyword)) {
            $items = array_values(array_filter($items, function ($item) use ($keyword) {
                if ($this->like_match("%".$keyword."%", $item['name'])) {
                    return true;
                } else {
                    return false;
                }
            }));
        }

        return [
            'items' => array_map(function ($item) {
                return $item->fill()->attributes;
            }, array_slice($items, ($currentPage - 1) * $perPage, $perPage)),
            'items' => $items,
            'paginator' => [
                'current_page' => $currentPage,
                'total' => $c,
                'per_page' => $perPage,
            ],
            'display' => $this->helper->getDisplayMode(),
            'working_dir' => $this->lfm->path('working_dir'),
        ];*/


        $currentPage = self::getCurrentPageFromRequest();

        $perPage = $this->helper->getPaginationPerPage();
        $perPage = $this->helper->getPaginationPerPage();
        $items = array_merge($this->lfm->folders(), $this->lfm->files());
        $items = array_merge($this->lfm->/** @scrutinizer ignore-call */ folders(), $this->lfm->files());
        
        $keyword = $request->keyword;

        if (!empty($keyword)) {
            $items = array_values(array_filter($items, function ($item) use ($keyword) {
                if ($this->like_match("%".$keyword."%", $item['name'])) {
                    return true;
                } else {
                    return false;
                }
            }));
        }

        return [
            'items' => array_map(function ($item) {
                return $item->fill()->attributes;
            }, array_slice($items, ($currentPage - 1) * $perPage, $perPage)),
            'paginator' => [
                'current_page' => $currentPage,
                'total' => count($items),
                'per_page' => $perPage,
            ],
            'display' => $this->helper->getDisplayMode(),
            'working_dir' => $this->lfm->path('working_dir'),
        ];
    }


    public function like_match($pattern, $subject)
    {
        $pattern = str_replace('%', '.*', preg_quote($pattern, '/'));
        return (bool) preg_match("/^{$pattern}$/i", $subject);
    }

    public function move()
    {
        $items = request('items');
        $items = /** @scrutinizer ignore-call */ request('items');
        $folder_types = array_filter(['user', 'share'], function ($type) {
            return $this->helper->allowFolderType($type);

        });
        return view('laravel-filemanager::move')
        return /** @scrutinizer ignore-call */ view('laravel-filemanager::move')
            ->with([
                'root_folders' => array_map(function ($type) use ($folder_types) {
                    $path = $this->lfm->dir($this->helper->getRootFolder($type));


                    return (object) [
                        'name' => trans('laravel-filemanager::lfm.title-' . $type),
                        'name' => /** @scrutinizer ignore-call */ trans('laravel-filemanager::lfm.title-' . $type),
                        'url' => $path->path('working_dir'),
                        'children' => $path->folders(),
                        'has_next' => ! ($type == end($folder_types)),
                    ];
                }, $folder_types),
            ])
            ->with('items', $items);
    }

    public function domove()
    {
        $target = $this->helper->input('goToFolder');

        $items = $this->helper->input('items');

        foreach ($items as $item) {
            $old_file = $this->lfm->pretty($item);

            $is_directory = $old_file->isDirectory();

            if ($old_file->hasThumb()) {
                $new_file = $this->lfm->setName($item)->thumb()->dir($target);
                if ($is_directory) {
                    event(new FolderIsMoving($old_file->path(), $new_file->path()));
                    event(new FolderIsMoving($old_file->path(), $new_file->path()));
                } else {
                    event(new FileIsMoving($old_file->path(), $new_file->path()));
                }
                $this->lfm->setName($item)->thumb()->move($new_file);
            }
            $new_file = $this->lfm->setName($item)->dir($target);
            $this->lfm->setName($item)->move($new_file);
            if ($is_directory) {
                event(new FolderWasMoving($old_file->path(), $new_file->path()));
            } else {
                event(new FileWasMoving($old_file->path(), $new_file->path()));
            }
        };

        return parent::$success_response;
    }

    private static function getCurrentPageFromRequest()
    {
        $currentPage = (int) request()->get('page', 1);
        $currentPage = (int) /** @scrutinizer ignore-call */ request()->get('page', 1);
        $currentPage = $currentPage < 1 ? 1 : $currentPage;

        return $currentPage;
    }

    private static function getKeywordFromRequest()

    {
        $keyword = request()->get('keyword', "");
        $keyword = /** @scrutinizer ignore-call */ request()->get('keyword', "");
        return $keyword;
    }
}


UniSharp / laravel-filemanager

Pull Request — master (#995)

ItemsController::getItems() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like