| Conditions | 15 |
| Paths | 58 |
| Total Lines | 65 |
| Code Lines | 40 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 5 | ||
| Bugs | 3 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 15 | public function getRename() |
||
| 16 | { |
||
| 17 | $old_name = $this->helper->input('file'); |
||
| 18 | $new_name = $this->helper->input('new_name'); |
||
| 19 | |||
| 20 | $file = $this->lfm->setName($old_name); |
||
| 21 | |||
| 22 | if (!Storage::disk($this->helper->config('disk'))->exists($file->path('storage'))) { |
||
| 23 | abort(404); |
||
| 24 | } |
||
| 25 | |||
| 26 | $old_file = $this->lfm->pretty($old_name); |
||
| 27 | |||
| 28 | $is_directory = $file->isDirectory(); |
||
| 29 | |||
| 30 | if (empty($new_name)) { |
||
| 31 | if ($is_directory) { |
||
| 32 | return response()->json(parent::error('folder-name'), 400); |
||
| 33 | } else { |
||
| 34 | return response()->json(parent::error('file-name'), 400); |
||
| 35 | } |
||
| 36 | } |
||
| 37 | |||
| 38 | if ($is_directory && config('lfm.alphanumeric_directory') && preg_match('/[^\w-]/i', $new_name)) { |
||
| 39 | return response()->json(parent::error('folder-alnum'), 400); |
||
| 40 | } elseif (config('lfm.alphanumeric_filename') && preg_match('/[^.\w-]/i', $new_name)) { |
||
| 41 | return response()->json(parent::error('file-alnum'), 400); |
||
| 42 | } elseif ($this->lfm->setName($new_name)->exists()) { |
||
| 43 | return response()->json(parent::error('rename'), 400); |
||
| 44 | } |
||
| 45 | |||
| 46 | if (! $is_directory) { |
||
| 47 | $extension = $old_file->extension(); |
||
| 48 | if ($extension) { |
||
| 49 | $new_name = str_replace('.' . $extension, '', $new_name) . '.' . $extension; |
||
| 50 | } |
||
| 51 | } |
||
| 52 | |||
| 53 | $new_path = $this->lfm->setName($new_name)->path('absolute'); |
||
| 54 | |||
| 55 | if ($is_directory) { |
||
| 56 | event(new FolderIsRenaming($old_file->path(), $new_path)); |
||
| 57 | } else { |
||
| 58 | event(new FileIsRenaming($old_file->path(), $new_path)); |
||
| 59 | event(new ImageIsRenaming($old_file->path(), $new_path)); |
||
| 60 | } |
||
| 61 | |||
| 62 | $old_path = $old_file->path(); |
||
| 63 | |||
| 64 | if ($old_file->hasThumb()) { |
||
| 65 | $this->lfm->setName($old_name)->thumb() |
||
| 66 | ->move($this->lfm->setName($new_name)->thumb()); |
||
| 67 | } |
||
| 68 | |||
| 69 | $this->lfm->setName($old_name) |
||
| 70 | ->move($this->lfm->setName($new_name)); |
||
| 71 | |||
| 72 | if ($is_directory) { |
||
| 73 | event(new FolderWasRenamed($old_path, $new_path)); |
||
| 74 | } else { |
||
| 75 | event(new FileWasRenamed($old_path, $new_path)); |
||
| 76 | event(new ImageWasRenamed($old_path, $new_path)); |
||
| 77 | } |
||
| 78 | |||
| 79 | return parent::$success_response; |
||
| 80 | } |
||
| 82 |