UFSC / moodle-local-relationship

assign.php

<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.

/**
 * Assign users to Relationship's Group page
 *
 * @package local_relationship
 * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
 */

require_once(__DIR__.'/../../config.php');
require($CFG->dirroot.'/local/relationship/lib.php');
require_once($CFG->dirroot.'/local/relationship/locallib.php');

require_login();

$relationshipgroupid = required_param('relationshipgroupid', PARAM_INT);
$relationshipgroup = $DB->get_record('relationship_groups', array('id' => $relationshipgroupid), '*', MUST_EXIST);

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

$relationship = $DB->get_record('relationship', array('id' => $relationshipgroup->relationshipid), '*', MUST_EXIST);

Equals sign not aligned with surrounding assignments; expected 8 spaces but found 1 space

$context = context::instance_by_id($relationship->contextid, MUST_EXIST);

Equals sign not aligned with surrounding assignments; expected 13 spaces but found 1 space

require_capability('local/relationship:view', $context);

$canassign = has_capability('local/relationship:assign', $context);
$editable = $canassign && empty($relationship->component);

Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

$baseurl = new moodle_url('/local/relationship/assign.php', array('relationshipgroupid' => $relationshipgroupid));

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

$returnurl = new moodle_url('/local/relationship/groups.php', array('relationshipid' => $relationship->id));

if (optional_param('cancel', false, PARAM_BOOL)) {
    redirect($returnurl);
}

relationship_set_header($context, $baseurl, $relationship, 'groups');
relationship_set_title($relationship, 'assignto', format_string($relationshipgroup->name));

echo $OUTPUT->notification(get_string('removeuserwarning', 'local_relationship'));

// Get the user_selector we will need.
if ($editable) {
    $potentialuserselector = new local_relationship_candidate_selector('addselect', array('relationshipgroup' => $relationshipgroup));
}
$existinguserselector = new local_relationship_existing_selector('removeselect', array('relationshipgroup' => $relationshipgroup));

// Process incoming user assignments to the relationship

if ($canassign && optional_param('add', false, PARAM_BOOL) && confirm_sesskey()) {

This code seems to be duplicated across your project.

    $userstoassign = $potentialuserselector->get_selected_users();
    if (!empty($userstoassign)) {
        foreach ($userstoassign as $adduser) {
            relationship_add_member($relationshipgroup->id, $adduser->relationshipcohortid, $adduser->userid);
        }
        $potentialuserselector->invalidate_selected_users();
        $existinguserselector->invalidate_selected_users();
    }
}

// Process removing user assignments to the relationship
if ($canassign && optional_param('remove', false, PARAM_BOOL) && confirm_sesskey()) {

This code seems to be duplicated across your project.

    $userstoremove = $existinguserselector->get_selected_users();
    if (!empty($userstoremove)) {
        foreach ($userstoremove as $removeuser) {
            relationship_remove_member($relationshipgroup->id, $removeuser->relationshipcohortid, $removeuser->userid);
        }
        $potentialuserselector->invalidate_selected_users();
        $existinguserselector->invalidate_selected_users();
    }
}

// Print the form.
if ($editable) {
    ?>
    <form id="assignform" method="post" action="<?php echo $PAGE->url ?>">
        <div>
            <input type="hidden" name="sesskey" value="<?php echo sesskey() ?>"/>

            <table summary="" class="generaltable generalbox boxaligncenter" cellspacing="0">
                <tr>
                    <td id="existingcell">
                        <p>
                            <label for="removeselect"><?php print_string('currentusers', 'local_relationship'); ?></label>
                        </p>
                        <?php $existinguserselector->display() ?>
                    </td>
                    <td id="buttonscell">
                        <div id="addcontrols">
                            <input name="add" id="add" type="submit"
                                   value="<?php echo $OUTPUT->larrow().'&nbsp;'.s(get_string('add')); ?>"
                                   title="<?php p(get_string('add')); ?>"/><br/>
                        </div>

                        <div id="removecontrols">
                            <input name="remove" id="remove" type="submit"
                                   value="<?php echo s(get_string('remove')).'&nbsp;'.$OUTPUT->rarrow(); ?>"
                                   title="<?php p(get_string('remove')); ?>"/>
                        </div>
                    </td>
                    <td id="potentialcell">
                        <p><label for="addselect"><?php print_string('potusers', 'local_relationship'); ?></label></p>
                        <?php $potentialuserselector->display() ?>
                    </td>
                </tr>
            </table>
        </div>
    </form>
<?php
} else {
    ?>
    <div>
        <table summary="" class="generaltable generalbox boxaligncenter" cellspacing="0">
            <tr>
                <td id="existingcell">
                    <p><label for="removeselect"><?php print_string('currentusers', 'local_relationship'); ?></label>
                    </p>
                    <?php $existinguserselector->display() ?>
                </td>
            </tr>
        </table>
    </div>
<?php

}

echo $OUTPUT->footer();