UFSC / moodle-local-relationship

classes/candidate_selector.php

Spacing +6 added lines, -6 removed lines

@@ -38,7 +38,7 @@ 
 
         list($usercondition, $params) = users_search_sql($search, 'u', $this->searchanywhere);
 
-        if(!empty($this->validatinguserids)) {
+        if (!empty($this->validatinguserids)) {
             list($usertest, $userparams) = $DB->get_in_or_equal($this->validatinguserids, SQL_PARAMS_NAMED, 'val');
             $usercondition .= " AND u.id*1000000+rc.id " . $usertest;
             $params = array_merge($params, $userparams);
@@ -66,7 +66,7 @@ 
                        OR (rc.allowdupsingroups = 0 AND rm.id IS NULL))
                   AND {$usercondition}";
 
-        $orderby= "ORDER BY roleid, in_group, fullname";
+        $orderby = "ORDER BY roleid, in_group, fullname";
 
         if (!$this->is_validating()) {
             $sql = $countfields . "\n" . $from;
@@ -78,18 +78,18 @@ 
             }
         }
 
-        $sql = $selectfields . "\n" . $from .  "\n" . $orderby;
+        $sql = $selectfields . "\n" . $from . "\n" . $orderby;
 
         $users = array();
         $roleid = -1;
         $in_group = -1;
         $index = false;
-        foreach($DB->get_recordset_sql($sql, $params) AS $cand) {
-            if($cand->roleid != $roleid || $cand->in_group != $in_group) {
+        foreach ($DB->get_recordset_sql($sql, $params) AS $cand) {
+            if ($cand->roleid != $roleid || $cand->in_group != $in_group) {
                 $role = $DB->get_record('role', array('id'=>$cand->roleid), '*', MUST_EXIST);
                 $role_name = role_get_name($role);
 
-                $str_alloc = $cand->in_group == 1  ? get_string('allocated', 'local_relationship') : get_string('notallocated', 'local_relationship');
+                $str_alloc = $cand->in_group == 1 ? get_string('allocated', 'local_relationship') : get_string('notallocated', 'local_relationship');
                 $index = $role_name . $str_alloc;
                 $users[$index] = array();
 

assign.php

Spacing +5 added lines, -5 removed lines

@@ -21,9 +21,9 @@ 
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-require_once(__DIR__.'/../../config.php');
-require($CFG->dirroot.'/local/relationship/lib.php');
-require_once($CFG->dirroot.'/local/relationship/locallib.php');
+require_once(__DIR__ . '/../../config.php');
+require($CFG->dirroot . '/local/relationship/lib.php');
+require_once($CFG->dirroot . '/local/relationship/locallib.php');
 
 require_login();
 
@@ -98,13 +98,13 @@ 
                     <td id="buttonscell">
                         <div id="addcontrols">
                             <input name="add" id="add" type="submit"
-                                   value="<?php echo $OUTPUT->larrow().'&nbsp;'.s(get_string('add')); ?>"
+                                   value="<?php echo $OUTPUT->larrow() . '&nbsp;' . s(get_string('add')); ?>"
                                    title="<?php p(get_string('add')); ?>"/><br/>
                         </div>
 
                         <div id="removecontrols">
                             <input name="remove" id="remove" type="submit"
-                                   value="<?php echo s(get_string('remove')).'&nbsp;'.$OUTPUT->rarrow(); ?>"
+                                   value="<?php echo s(get_string('remove')) . '&nbsp;' . $OUTPUT->rarrow(); ?>"
                                    title="<?php p(get_string('remove')); ?>"/>
                         </div>
                     </td>

index.php

Spacing +6 added lines, -6 removed lines

@@ -22,9 +22,9 @@ 
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-require_once(__DIR__.'/../../config.php');
-require($CFG->dirroot.'/local/relationship/lib.php');
-require_once($CFG->dirroot.'/local/relationship/locallib.php');
+require_once(__DIR__ . '/../../config.php');
+require($CFG->dirroot . '/local/relationship/lib.php');
+require_once($CFG->dirroot . '/local/relationship/locallib.php');
 
 require_login();
 $contextid = required_param('contextid', PARAM_INT);
@@ -61,9 +61,9 @@ 
 $count = '';
 if ($relationships['allrelationships'] > 0) {
     if ($searchquery === '') {
-        $count = ' ('.$relationships['allrelationships'].')';
+        $count = ' (' . $relationships['allrelationships'] . ')';
     } else {
-        $count = ' ('.$relationships['totalrelationships'].'/'.$relationships['allrelationships'].')';
+        $count = ' (' . $relationships['totalrelationships'] . '/' . $relationships['allrelationships'] . ')';
     }
 }
 
@@ -97,7 +97,7 @@ 
     if ($course_count > 0) {
         $url = new moodle_url('/local/relationship/index.php', array('contextid' => $contextid, 'relationshipid' => $relationship->id));
         $link = html_writer::link($url, get_string('list', 'local_relationship'));
-        $line[] = $course_count.' ('.$link.')';
+        $line[] = $course_count . ' (' . $link . ')';
     } else {
         $line[] = $course_count;
     }

autogroup.php

Spacing +6 added lines, -6 removed lines

@@ -21,10 +21,10 @@ 
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-require_once(__DIR__.'/../../config.php');
-require($CFG->dirroot.'/local/relationship/lib.php');
-require_once($CFG->dirroot.'/local/relationship/locallib.php');
-require_once($CFG->dirroot.'/group/lib.php');
+require_once(__DIR__ . '/../../config.php');
+require($CFG->dirroot . '/local/relationship/lib.php');
+require_once($CFG->dirroot . '/local/relationship/locallib.php');
+require_once($CFG->dirroot . '/group/lib.php');
 
 require_login();
 
@@ -104,9 +104,9 @@ 
         $table->data = array();
         foreach ($new_groups as $group) {
             if ($group['exists']) {
-                $text = html_writer::tag('span', $group['name'], array('style' => 'color:red; font-weight: bold;')).get_string('alreadyexists', 'local_relationship');
+                $text = html_writer::tag('span', $group['name'], array('style' => 'color:red; font-weight: bold;')) . get_string('alreadyexists', 'local_relationship');
             } else if ($group['exists_external']) {
-                $text = html_writer::tag('span', $group['name'], array('style' => 'color:red; font-weight: bold;')).get_string('alreadyexistsexternal', 'local_relationship');
+                $text = html_writer::tag('span', $group['name'], array('style' => 'color:red; font-weight: bold;')) . get_string('alreadyexistsexternal', 'local_relationship');
             } else {
                 $text = $group['name'];
             }

edit_cohort.php

Spacing +5 added lines, -5 removed lines

@@ -20,9 +20,9 @@ 
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-require_once(__DIR__.'/../../config.php');
-require($CFG->dirroot.'/local/relationship/lib.php');
-require_once($CFG->dirroot.'/local/relationship/locallib.php');
+require_once(__DIR__ . '/../../config.php');
+require($CFG->dirroot . '/local/relationship/lib.php');
+require_once($CFG->dirroot . '/local/relationship/locallib.php');
 
 require_login();
 
@@ -58,7 +58,7 @@ 
 relationship_set_header($context, $baseurl, $relationship, 'cohorts');
 
 if (optional_param('delete', 0, PARAM_BOOL) && $relationshipcohort->id) {
-    $desc = format_string($relationshipcohort->role_name.'/'.$relationshipcohort->cohort->name);
+    $desc = format_string($relationshipcohort->role_name . '/' . $relationshipcohort->cohort->name);
     relationship_set_title($relationship, 'deletecohort', $desc);
     echo $OUTPUT->notification(get_string('deletecohortwarning', 'local_relationship'));
     $yesurl = new moodle_url('/local/relationship/edit_cohort.php', array('relationshipcohortid' => $relationshipcohort->id, 'relationshipid' => $relationship->id, 'delete' => 1, 'confirmedelete' => 1, 'sesskey' => sesskey()));
@@ -82,7 +82,7 @@ 
 }
 
 if ($relationshipcohort->id) {
-    $desc = format_string($relationshipcohort->role_name.'/'.$relationshipcohort->cohort->name);
+    $desc = format_string($relationshipcohort->role_name . '/' . $relationshipcohort->cohort->name);
     relationship_set_title($relationship, 'editcohort', $desc);
 } else {
     relationship_set_title($relationship, 'addcohort');

groups.php

Spacing +8 added lines, -8 removed lines

@@ -21,10 +21,10 @@ 
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-require_once(__DIR__.'/../../config.php');
-require($CFG->dirroot.'/local/relationship/lib.php');
-require_once($CFG->dirroot.'/local/relationship/locallib.php');
-require_once($CFG->libdir.'/adminlib.php');
+require_once(__DIR__ . '/../../config.php');
+require($CFG->dirroot . '/local/relationship/lib.php');
+require_once($CFG->dirroot . '/local/relationship/locallib.php');
+require_once($CFG->libdir . '/adminlib.php');
 
 require_login();
 
@@ -64,7 +64,7 @@ 
     }
     if ($editable) {
         $url = new moodle_url('/local/relationship/edit_group.php', array('relationshipgroupid' => $relationshipgroup->id, 'uniformdistribution' => $uniformdistribution));
-        $line[] = $status.' ('.html_writer::link($url, $text).')';
+        $line[] = $status . ' (' . html_writer::link($url, $text) . ')';
     } else {
         $line[] = $status;
     }
@@ -87,8 +87,8 @@ 
 $table = new html_table();
 $table->head = array(get_string('name', 'local_relationship'),
         get_string('memberscount', 'local_relationship'),
-        get_string('limit', 'local_relationship').$OUTPUT->help_icon('userlimit', 'local_relationship'),
-        get_string('uniformdistribute', 'local_relationship').$OUTPUT->help_icon('uniformdistribute', 'local_relationship'),
+        get_string('limit', 'local_relationship') . $OUTPUT->help_icon('userlimit', 'local_relationship'),
+        get_string('uniformdistribute', 'local_relationship') . $OUTPUT->help_icon('uniformdistribute', 'local_relationship'),
         get_string('edit'));
 $table->colclasses = array('leftalign name',
         'leftalign size',
@@ -135,7 +135,7 @@ 
 
     $addgroup = new single_button(new moodle_url('/local/relationship/edit_group.php', array('relationshipid' => $relationshipid)), get_string('addgroup', 'local_relationship'));
     $addgroups = new single_button(new moodle_url('/local/relationship/autogroup.php', array('relationshipid' => $relationshipid)), get_string('autogroup', 'local_relationship'));
-    echo html_writer::tag('div', $OUTPUT->render($addgroup).$OUTPUT->render($addgroups), array('class' => 'buttons'));
+    echo html_writer::tag('div', $OUTPUT->render($addgroup) . $OUTPUT->render($addgroups), array('class' => 'buttons'));
 } else if ($manager) {
     echo $OUTPUT->heading(get_string('noeditable', 'local_relationship'));
 }

locallib.php

Spacing +13 added lines, -13 removed lines

@@ -26,7 +26,7 @@ 
 require_once($CFG->dirroot . '/user/selector/lib.php');
 require_once($CFG->dirroot . '/tag/lib.php');
 
-function relationship_set_header($context, $url, $relationship=null, $module=null) {
+function relationship_set_header($context, $url, $relationship = null, $module = null) {
     global $PAGE, $COURSE, $DB;
 
     if ($context->contextlevel != CONTEXT_COURSECAT) {
@@ -43,27 +43,27 @@ 
 
     $PAGE->navbar->add($category->name, new moodle_url('/course/index.php', array('categoryid'=>$category->id)));
     $PAGE->navbar->add($navtitle, new moodle_url('/local/relationship/index.php', array('contextid'=>$context->id)));
-    if($module) {
+    if ($module) {
         $PAGE->navbar->add(get_string($module, 'local_relationship'),
                            new moodle_url("/local/relationship/{$module}.php", array('relationshipid'=>$relationship->id)));
     }
 }
 
-function relationship_set_title($relationship=null, $action=null, $param=null) {
+function relationship_set_title($relationship = null, $action = null, $param = null) {
     global $OUTPUT;
 
     echo $OUTPUT->header();
-    if($relationship) {
+    if ($relationship) {
         echo $OUTPUT->heading(get_string('relationship', 'local_relationship') . ': ' . format_string($relationship->name));
         echo html_writer::empty_tag('BR');
     }
-    if($action) {
+    if ($action) {
         echo $OUTPUT->heading(get_string($action, 'local_relationship', $param), '4');
     }
 }
 
-function relationship_groups_parse_name($format, $value, $value_is_a_name=false) {
-    if($value_is_a_name) {
+function relationship_groups_parse_name($format, $value, $value_is_a_name = false) {
+    if ($value_is_a_name) {
         if (strstr($format, '@') !== false) {
             $str = str_replace('@', $value, $format);
         } else {
@@ -72,7 +72,7 @@ 
     } else {
         if (strstr($format, '@') !== false) { // Convert $value to a character series
             $letter = 'A';
-            for($i=0; $i<$value; $i++) {
+            for ($i = 0; $i < $value; $i++) {
                 $letter++;
             }
             $str = str_replace('@', $letter, $format);
@@ -87,8 +87,8 @@ 
     $all_roles = role_get_names();
     $ctx_roles = get_roles_for_contextlevels(CONTEXT_COURSE);
     $roles = array();
-    foreach($ctx_roles AS $id=>$roleid) {
-        if($roleid > 2) {
+    foreach ($ctx_roles AS $id=>$roleid) {
+        if ($roleid > 2) {
             $roles[$roleid] = $all_roles[$roleid]->localname;
         }
     }
@@ -103,7 +103,7 @@ 
     $context = context::instance_by_id($relationship->contextid);
 
     $contextids = array();
-    foreach($context->get_parent_context_ids(true) as $ctxid) {
+    foreach ($context->get_parent_context_ids(true) as $ctxid) {
         $context = context::instance_by_id($ctxid);
         if (has_capability('moodle/cohort:view', $context)) {
             $contextids[] = $ctxid;
@@ -139,7 +139,7 @@ 
                AND g.idnumber NOT LIKE 'relationship_{$relationshipid}_%'
           ORDER BY g.name";
     $groups = array();
-    foreach($DB->get_records_sql($sql, array('relationshipid'=>$relationshipid)) as $r) {
+    foreach ($DB->get_records_sql($sql, array('relationshipid'=>$relationshipid)) as $r) {
         $groups[$r->name][] = $r;
     }
     return $groups;
@@ -223,7 +223,7 @@ 
     $allrelationships = $DB->count_records('relationship', array('contextid'=>$contextid));
     $totalrelationships = $DB->count_records_sql($countfields . $sql, $params);
     $relationships = $DB->get_records_sql($fields . $sql . $order, $params, $page*$perpage, $perpage);
-    foreach($relationships as $rl) {
+    foreach ($relationships as $rl) {
         $rl->tags = tag_get_tags_array('relationship', $rl->id);
     }