local_relationship_candidate_selector::find_users()

Complexity

Conditions	9
Paths	20

Size

Total Lines	69
Code Lines	37

Duplication

Lines	14
Ratio	20.29 %

Importance

Changes	3
Bugs	0	Features	0

<?php
    public function find_users($search) {
        global $DB;

        list($usercondition, $params) = users_search_sql($search, 'u', $this->searchanywhere);

        if(!empty($this->validatinguserids)) {

This code seems to be duplicated across your project.

            list($usertest, $userparams) = $DB->get_in_or_equal($this->validatinguserids, SQL_PARAMS_NAMED, 'val');
            $usercondition .= " AND u.id*1000000+rc.id " . $usertest;

Equals sign not aligned with surrounding assignments; expected 14 spaces but found 1 space

            $params = array_merge($params, $userparams);

Equals sign not aligned with surrounding assignments; expected 22 spaces but found 1 space

        }

        $params['relationshipid'] = $this->relationshipgroup->relationshipid;

Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space

        $params['relationshipgroupid'] = $this->relationshipgroup->id;

        $countfields  = 'SELECT COUNT(DISTINCT u.id)';
        $selectfields = "SELECT DISTINCT u.id*1000000+rc.id as id, rc.id AS relationshipcohortid, rc.roleid, rc.allowdupsingroups,
                                u.id AS userid, CONCAT(u.firstname, ' ', u.lastname) AS fullname,
                                CASE WHEN rm.id IS NULL THEN 0 ELSE 1 END AS in_group";

        $from = "FROM {relationship_cohorts} rc
                 JOIN {cohort_members} cm ON (cm.cohortid = rc.cohortid)
                 JOIN {user} u ON (u.id = cm.userid)
            LEFT JOIN {relationship_members} rm ON (rm.relationshipcohortid = rc.id AND rm.userid = cm.userid)
                WHERE rc.relationshipid = :relationshipid
                  AND NOT EXISTS (SELECT 1
                                    FROM {relationship_members} rm
                                   WHERE rm.relationshipcohortid = rc.id
                                     AND rm.userid = cm.userid
                                     AND rm.relationshipgroupid = :relationshipgroupid)
                  AND (rc.allowdupsingroups = 1
                       OR (rc.allowdupsingroups = 0 AND rm.id IS NULL))
                  AND {$usercondition}";

        $orderby= "ORDER BY roleid, in_group, fullname";

Equals sign not aligned correctly; expected 1 space but found 0 spaces

        if (!$this->is_validating()) {

This code seems to be duplicated across your project.

            $sql = $countfields . "\n" . $from;

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

            $count = $DB->count_records_sql($sql, $params);
            if ($count > $this->maxusersperpage) {
                return $this->too_many_results($search, $count);
            } else if ($count == 0) {
                return array();
            }
        }

        $sql = $selectfields . "\n" . $from .  "\n" . $orderby;

        $users = array();

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

        $roleid = -1;

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

        $in_group = -1;
        $index = false;

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

        foreach($DB->get_recordset_sql($sql, $params) AS $cand) {
            if($cand->roleid != $roleid || $cand->in_group != $in_group) {
                $role = $DB->get_record('role', array('id'=>$cand->roleid), '*', MUST_EXIST);

Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space

                $role_name = role_get_name($role);

                $str_alloc = $cand->in_group == 1  ? get_string('allocated', 'local_relationship') : get_string('notallocated', 'local_relationship');

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

                $index = $role_name . $str_alloc;

Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space

                $users[$index] = array();

                $roleid = $cand->roleid;

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

                $in_group = $cand->in_group;
            }

            $users[$index][$cand->id] = $cand;
        }

        return $users;
    }