UFSC / moodle-local-relationship

lib.php

Spacing +1 added lines, -1 removed lines

@@ -320,7 +320,7 @@
 
     $cohorts = $DB->get_records('relationship_cohorts', array('relationshipid' => $relationship->id));
 
-    if(count($cohorts) == 0) {
+    if (count($cohorts) == 0) {
 
         $relationshipgroups = $DB->get_records('relationship_groups', array('relationshipid' => $relationship->id));
         foreach ($relationshipgroups AS $g) {

Doc Comments +1 added lines, -1 removed lines

@@ -284,7 +284,7 @@
  * Update existing relationship
  *
  * @param sstdClass $relationship
- * @return void
+ * @return boolean
  */
 function relationship_update_relationship($relationship) {
     global $DB;

cohorts.php

Spacing +5 added lines, -5 removed lines

@@ -21,9 +21,9 @@ 
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-require_once(__DIR__.'/../../config.php');
-require($CFG->dirroot.'/local/relationship/lib.php');
-require_once($CFG->dirroot.'/local/relationship/locallib.php');
+require_once(__DIR__ . '/../../config.php');
+require($CFG->dirroot . '/local/relationship/lib.php');
+require_once($CFG->dirroot . '/local/relationship/locallib.php');
 
 require_login();
 
@@ -68,8 +68,8 @@ 
         get_string('cohort', 'cohort'),
         get_string('size'),
         get_string('role'),
-        get_string('allowdupsingroups', 'local_relationship').$OUTPUT->help_icon('allowdupsingroups', 'local_relationship'),
-        get_string('uniformdistribute', 'local_relationship').$OUTPUT->help_icon('uniformdistribute', 'local_relationship'),
+        get_string('allowdupsingroups', 'local_relationship') . $OUTPUT->help_icon('allowdupsingroups', 'local_relationship'),
+        get_string('uniformdistribute', 'local_relationship') . $OUTPUT->help_icon('uniformdistribute', 'local_relationship'),
         get_string('edit')
 );
 $table->colclasses = array(

edit_group.php

Spacing +4 added lines, -4 removed lines

@@ -21,10 +21,10 @@
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-require_once(__DIR__.'/../../config.php');
-require_once($CFG->dirroot.'/course/lib.php');
-require($CFG->dirroot.'/local/relationship/lib.php');
-require_once($CFG->dirroot.'/local/relationship/locallib.php');
+require_once(__DIR__ . '/../../config.php');
+require_once($CFG->dirroot . '/course/lib.php');
+require($CFG->dirroot . '/local/relationship/lib.php');
+require_once($CFG->dirroot . '/local/relationship/locallib.php');
 
 require_login();
 

classes/existing_selector.php

Spacing +5 added lines, -5 removed lines

@@ -44,7 +44,7 @@ 
 
         list($usercondition, $params) = users_search_sql($search, 'u', $this->searchanywhere);
 
-        if(!empty($this->validatinguserids)) {
+        if (!empty($this->validatinguserids)) {
             list($usertest, $userparams) = $DB->get_in_or_equal($this->validatinguserids, SQL_PARAMS_NAMED, 'val');
             $usercondition .= " AND u.id*1000000+rc.id " . $usertest;
             $params = array_merge($params, $userparams);
@@ -61,7 +61,7 @@ 
                 WHERE rm.relationshipgroupid = :relationshipgroupid
                   AND {$usercondition}";
 
-        $orderby= "ORDER BY roleid, fullname";
+        $orderby = "ORDER BY roleid, fullname";
 
         if (!$this->is_validating()) {
             $sql = $countfields . "\n" . $from;
@@ -73,13 +73,13 @@ 
             }
         }
 
-        $sql = $selectfields . "\n" . $from .  "\n" . $orderby;
+        $sql = $selectfields . "\n" . $from . "\n" . $orderby;
 
         $users = array();
         $roleid = -1;
         $index = false;
-        foreach($DB->get_recordset_sql($sql, $params) AS $cand) {
-            if($cand->roleid != $roleid) {
+        foreach ($DB->get_recordset_sql($sql, $params) AS $cand) {
+            if ($cand->roleid != $roleid) {
                 $role = $DB->get_record('role', array('id'=>$cand->roleid), '*', MUST_EXIST);
                 $index = role_get_name($role);
                 $users[$index] = array();

classes/observer.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot.'/local/relationship/lib.php');
+require_once($CFG->dirroot . '/local/relationship/lib.php');
 
 /**
  * Event handler for relationship local plugin.

classes/form/autogroup.php

Spacing +2 added lines, -2 removed lines

@@ -24,7 +24,7 @@ 
 namespace local_relationship\form;
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot.'/lib/formslib.php');
+require_once($CFG->dirroot . '/lib/formslib.php');
 
 /**
  * Auto group form class
@@ -40,7 +40,7 @@ 
     function definition() {
         global $DB;
 
-        $mform =& $this->_form;
+        $mform = & $this->_form;
 
         $relationshipid = $this->_customdata['relationshipid'];
 

classes/form/edit_cohort.php

Spacing +4 added lines, -4 removed lines

@@ -24,7 +24,7 @@ 
 namespace local_relationship\form;
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot.'/lib/formslib.php');
+require_once($CFG->dirroot . '/lib/formslib.php');
 
 class edit_cohort extends \moodleform {
 
@@ -35,19 +35,19 @@ 
 
         $cohorts = relationship_get_cohort_options($relationshipcohort->relationshipid);
         $relationshipcohorts = relationship_get_cohorts($relationshipcohort->relationshipid);
-        foreach($relationshipcohorts AS $rc) {
+        foreach ($relationshipcohorts AS $rc) {
             unset($cohorts[$rc->cohortid]);
         }
 
         $mform->addElement('select', 'cohortid', get_string('cohort', 'cohort'), $cohorts);
 
         $roles = relationship_get_role_options();
-        foreach($relationshipcohorts AS $rc) {
+        foreach ($relationshipcohorts AS $rc) {
             unset($roles[$rc->roleid]);
         }
         $mform->addElement('select', 'roleid', get_string('role'), $roles);
 
-        if($relationshipcohort->id) {
+        if ($relationshipcohort->id) {
             $mform->freeze('roleid');
             $mform->freeze('cohortid');
         }

classes/form/edit_relationship.php

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
 namespace local_relationship\form;
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot.'/lib/formslib.php');
+require_once($CFG->dirroot . '/lib/formslib.php');
 
 class edit_relationship extends \moodleform {
 

classes/candidate_selector.php

Spacing +6 added lines, -6 removed lines

@@ -38,7 +38,7 @@ 
 
         list($usercondition, $params) = users_search_sql($search, 'u', $this->searchanywhere);
 
-        if(!empty($this->validatinguserids)) {
+        if (!empty($this->validatinguserids)) {
             list($usertest, $userparams) = $DB->get_in_or_equal($this->validatinguserids, SQL_PARAMS_NAMED, 'val');
             $usercondition .= " AND u.id*1000000+rc.id " . $usertest;
             $params = array_merge($params, $userparams);
@@ -66,7 +66,7 @@ 
                        OR (rc.allowdupsingroups = 0 AND rm.id IS NULL))
                   AND {$usercondition}";
 
-        $orderby= "ORDER BY roleid, in_group, fullname";
+        $orderby = "ORDER BY roleid, in_group, fullname";
 
         if (!$this->is_validating()) {
             $sql = $countfields . "\n" . $from;
@@ -78,18 +78,18 @@ 
             }
         }
 
-        $sql = $selectfields . "\n" . $from .  "\n" . $orderby;
+        $sql = $selectfields . "\n" . $from . "\n" . $orderby;
 
         $users = array();
         $roleid = -1;
         $in_group = -1;
         $index = false;
-        foreach($DB->get_recordset_sql($sql, $params) AS $cand) {
-            if($cand->roleid != $roleid || $cand->in_group != $in_group) {
+        foreach ($DB->get_recordset_sql($sql, $params) AS $cand) {
+            if ($cand->roleid != $roleid || $cand->in_group != $in_group) {
                 $role = $DB->get_record('role', array('id'=>$cand->roleid), '*', MUST_EXIST);
                 $role_name = role_get_name($role);
 
-                $str_alloc = $cand->in_group == 1  ? get_string('allocated', 'local_relationship') : get_string('notallocated', 'local_relationship');
+                $str_alloc = $cand->in_group == 1 ? get_string('allocated', 'local_relationship') : get_string('notallocated', 'local_relationship');
                 $index = $role_name . $str_alloc;
                 $users[$index] = array();