UFSC / moodle-local-relationship

classes/candidate_selector.php

Spacing +6 added lines, -6 removed lines

@@ -38,7 +38,7 @@ 
 
         list($usercondition, $params) = users_search_sql($search, 'u', $this->searchanywhere);
 
-        if(!empty($this->validatinguserids)) {
+        if (!empty($this->validatinguserids)) {
             list($usertest, $userparams) = $DB->get_in_or_equal($this->validatinguserids, SQL_PARAMS_NAMED, 'val');
             $usercondition .= " AND u.id*1000000+rc.id " . $usertest;
             $params = array_merge($params, $userparams);
@@ -66,7 +66,7 @@ 
                        OR (rc.allowdupsingroups = 0 AND rm.id IS NULL))
                   AND {$usercondition}";
 
-        $orderby= "ORDER BY roleid, in_group, fullname";
+        $orderby = "ORDER BY roleid, in_group, fullname";
 
         if (!$this->is_validating()) {
             $sql = $countfields . "\n" . $from;
@@ -78,18 +78,18 @@ 
             }
         }
 
-        $sql = $selectfields . "\n" . $from .  "\n" . $orderby;
+        $sql = $selectfields . "\n" . $from . "\n" . $orderby;
 
         $users = array();
         $roleid = -1;
         $in_group = -1;
         $index = false;
-        foreach($DB->get_recordset_sql($sql, $params) AS $cand) {
-            if($cand->roleid != $roleid || $cand->in_group != $in_group) {
+        foreach ($DB->get_recordset_sql($sql, $params) AS $cand) {
+            if ($cand->roleid != $roleid || $cand->in_group != $in_group) {
                 $role = $DB->get_record('role', array('id'=>$cand->roleid), '*', MUST_EXIST);
                 $role_name = role_get_name($role);
 
-                $str_alloc = $cand->in_group == 1  ? get_string('allocated', 'local_relationship') : get_string('notallocated', 'local_relationship');
+                $str_alloc = $cand->in_group == 1 ? get_string('allocated', 'local_relationship') : get_string('notallocated', 'local_relationship');
                 $index = $role_name . $str_alloc;
                 $users[$index] = array();
 

assign.php

Spacing +5 added lines, -5 removed lines

@@ -21,9 +21,9 @@ 
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-require_once(__DIR__.'/../../config.php');
-require($CFG->dirroot.'/local/relationship/lib.php');
-require_once($CFG->dirroot.'/local/relationship/locallib.php');
+require_once(__DIR__ . '/../../config.php');
+require($CFG->dirroot . '/local/relationship/lib.php');
+require_once($CFG->dirroot . '/local/relationship/locallib.php');
 
 require_login();
 
@@ -98,13 +98,13 @@ 
                     <td id="buttonscell">
                         <div id="addcontrols">
                             <input name="add" id="add" type="submit"
-                                   value="<?php echo $OUTPUT->larrow().'&nbsp;'.s(get_string('add')); ?>"
+                                   value="<?php echo $OUTPUT->larrow() . '&nbsp;' . s(get_string('add')); ?>"
                                    title="<?php p(get_string('add')); ?>"/><br/>
                         </div>
 
                         <div id="removecontrols">
                             <input name="remove" id="remove" type="submit"
-                                   value="<?php echo s(get_string('remove')).'&nbsp;'.$OUTPUT->rarrow(); ?>"
+                                   value="<?php echo s(get_string('remove')) . '&nbsp;' . $OUTPUT->rarrow(); ?>"
                                    title="<?php p(get_string('remove')); ?>"/>
                         </div>
                     </td>

index.php

Spacing +6 added lines, -6 removed lines

@@ -22,9 +22,9 @@ 
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-require_once(__DIR__.'/../../config.php');
-require($CFG->dirroot.'/local/relationship/lib.php');
-require_once($CFG->dirroot.'/local/relationship/locallib.php');
+require_once(__DIR__ . '/../../config.php');
+require($CFG->dirroot . '/local/relationship/lib.php');
+require_once($CFG->dirroot . '/local/relationship/locallib.php');
 
 require_login();
 $contextid = required_param('contextid', PARAM_INT);
@@ -61,9 +61,9 @@ 
 $count = '';
 if ($relationships['allrelationships'] > 0) {
     if ($searchquery === '') {
-        $count = ' ('.$relationships['allrelationships'].')';
+        $count = ' (' . $relationships['allrelationships'] . ')';
     } else {
-        $count = ' ('.$relationships['totalrelationships'].'/'.$relationships['allrelationships'].')';
+        $count = ' (' . $relationships['totalrelationships'] . '/' . $relationships['allrelationships'] . ')';
     }
 }
 
@@ -97,7 +97,7 @@ 
     if ($course_count > 0) {
         $url = new moodle_url('/local/relationship/index.php', array('contextid' => $contextid, 'relationshipid' => $relationship->id));
         $link = html_writer::link($url, get_string('list', 'local_relationship'));
-        $line[] = $course_count.' ('.$link.')';
+        $line[] = $course_count . ' (' . $link . ')';
     } else {
         $line[] = $course_count;
     }

autogroup.php

Spacing +6 added lines, -6 removed lines

@@ -21,10 +21,10 @@ 
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-require_once(__DIR__.'/../../config.php');
-require($CFG->dirroot.'/local/relationship/lib.php');
-require_once($CFG->dirroot.'/local/relationship/locallib.php');
-require_once($CFG->dirroot.'/group/lib.php');
+require_once(__DIR__ . '/../../config.php');
+require($CFG->dirroot . '/local/relationship/lib.php');
+require_once($CFG->dirroot . '/local/relationship/locallib.php');
+require_once($CFG->dirroot . '/group/lib.php');
 
 require_login();
 
@@ -104,9 +104,9 @@ 
         $table->data = array();
         foreach ($new_groups as $group) {
             if ($group['exists']) {
-                $text = html_writer::tag('span', $group['name'], array('style' => 'color:red; font-weight: bold;')).get_string('alreadyexists', 'local_relationship');
+                $text = html_writer::tag('span', $group['name'], array('style' => 'color:red; font-weight: bold;')) . get_string('alreadyexists', 'local_relationship');
             } else if ($group['exists_external']) {
-                $text = html_writer::tag('span', $group['name'], array('style' => 'color:red; font-weight: bold;')).get_string('alreadyexistsexternal', 'local_relationship');
+                $text = html_writer::tag('span', $group['name'], array('style' => 'color:red; font-weight: bold;')) . get_string('alreadyexistsexternal', 'local_relationship');
             } else {
                 $text = $group['name'];
             }

edit_cohort.php

Spacing +5 added lines, -5 removed lines

@@ -20,9 +20,9 @@ 
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-require_once(__DIR__.'/../../config.php');
-require($CFG->dirroot.'/local/relationship/lib.php');
-require_once($CFG->dirroot.'/local/relationship/locallib.php');
+require_once(__DIR__ . '/../../config.php');
+require($CFG->dirroot . '/local/relationship/lib.php');
+require_once($CFG->dirroot . '/local/relationship/locallib.php');
 
 require_login();
 
@@ -58,7 +58,7 @@ 
 relationship_set_header($context, $baseurl, $relationship, 'cohorts');
 
 if (optional_param('delete', 0, PARAM_BOOL) && $relationshipcohort->id) {
-    $desc = format_string($relationshipcohort->role_name.'/'.$relationshipcohort->cohort->name);
+    $desc = format_string($relationshipcohort->role_name . '/' . $relationshipcohort->cohort->name);
     relationship_set_title($relationship, 'deletecohort', $desc);
     echo $OUTPUT->notification(get_string('deletecohortwarning', 'local_relationship'));
     $yesurl = new moodle_url('/local/relationship/edit_cohort.php', array('relationshipcohortid' => $relationshipcohort->id, 'relationshipid' => $relationship->id, 'delete' => 1, 'confirmedelete' => 1, 'sesskey' => sesskey()));
@@ -82,7 +82,7 @@ 
 }
 
 if ($relationshipcohort->id) {
-    $desc = format_string($relationshipcohort->role_name.'/'.$relationshipcohort->cohort->name);
+    $desc = format_string($relationshipcohort->role_name . '/' . $relationshipcohort->cohort->name);
     relationship_set_title($relationship, 'editcohort', $desc);
 } else {
     relationship_set_title($relationship, 'addcohort');

lib.php

Spacing +3 added lines, -3 removed lines

@@ -269,7 +269,7 @@ 
             'relationship',
             $relationship->id,
             context::instance_by_id($relationship->contextid),
-            $relationship->tags) ;
+            $relationship->tags);
 
         $event = \local_relationship\event\relationship_created::create(array(
                 'context' => context::instance_by_id($relationship->contextid),
@@ -301,7 +301,7 @@ 
             'relationship',
             $relationship->id,
             context::instance_by_id($relationship->contextid),
-            $relationship->tags) ;
+            $relationship->tags);
 
         $event = \local_relationship\event\relationship_updated::create(array(
                 'context' => context::instance_by_id($relationship->contextid),
@@ -328,7 +328,7 @@ 
 
     $cohorts = $DB->get_records('relationship_cohorts', array('relationshipid' => $relationship->id));
 
-    if(count($cohorts) == 0) {
+    if (count($cohorts) == 0) {
 
         $relationshipgroups = $DB->get_records('relationship_groups', array('relationshipid' => $relationship->id));
         foreach ($relationshipgroups AS $g) {

classes/progress_tracker.php

Indentation -1 removed lines

@@ -16,7 +16,6 @@
 
 /**
  * class based on core/admin/uu_progress_tracker by Petr Skoda
-
  * @package    local_relationship
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */

Spacing +4 added lines, -4 removed lines

@@ -57,16 +57,16 @@
         $table->tablealign = 'center';
 
         $table->head = array(get_string('titleline', 'local_relationship'));
-        $table->align = array ('right');
-        foreach($this->columns AS $col) {
-            $table->head[] = get_string('title'.$col, 'local_relationship');
+        $table->align = array('right');
+        foreach ($this->columns AS $col) {
+            $table->head[] = get_string('title' . $col, 'local_relationship');
             $table->align[] = 'left';
         }
 
         $table->data = array();
         foreach ($this->rows AS $linenum => $r) {
             $row = array($linenum . '.');
-            foreach($r AS $col=>$occurs) {
+            foreach ($r AS $col=>$occurs) {
                 $text = '';
                 foreach ($occurs AS $occur) {
                     $msg = html_writer::tag('div', $occur['msg'], array('class' => 'alert-' . $occur['level']));

groups.php

Spacing +9 added lines, -9 removed lines

@@ -21,10 +21,10 @@ 
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-require_once(__DIR__.'/../../config.php');
-require($CFG->dirroot.'/local/relationship/lib.php');
-require_once($CFG->dirroot.'/local/relationship/locallib.php');
-require_once($CFG->libdir.'/adminlib.php');
+require_once(__DIR__ . '/../../config.php');
+require($CFG->dirroot . '/local/relationship/lib.php');
+require_once($CFG->dirroot . '/local/relationship/locallib.php');
+require_once($CFG->libdir . '/adminlib.php');
 
 require_login();
 
@@ -65,7 +65,7 @@ 
     }
     if ($editable) {
         $url = new moodle_url('/local/relationship/edit_group.php', array('relationshipgroupid' => $relationshipgroup->id, 'uniformdistribution' => $uniformdistribution));
-        $line[] = $status.' ('.html_writer::link($url, $text).')';
+        $line[] = $status . ' (' . html_writer::link($url, $text) . ')';
     } else {
         $line[] = $status;
     }
@@ -80,7 +80,7 @@ 
     if ($manager || $canassign) {
         $buttons[] = html_writer::link(new moodle_url('/local/relationship/assign.php', array('relationshipgroupid' => $relationshipgroup->id)),
                 html_writer::empty_tag('img', array('src' => $OUTPUT->pix_url('t/assignroles'), 'alt' => get_string('assign', 'local_relationship'), 'title' => get_string('assign', 'local_relationship'), 'class' => 'iconsmall')));
-        if($relationshipcohort && empty($relationshipcohort->component) && !$relationshipcohort->uniformdistribution && !$relationshipgroup->uniformdistribution) {
+        if ($relationshipcohort && empty($relationshipcohort->component) && !$relationshipcohort->uniformdistribution && !$relationshipgroup->uniformdistribution) {
             $buttons[] = html_writer::link(new moodle_url('/local/relationship/mass_assign.php', array('relationshipgroupid' => $relationshipgroup->id)),
                 html_writer::empty_tag('img', array('src' => $OUTPUT->pix_url('t/add'), 'alt' => get_string('massassign', 'local_relationship'), 'title' => get_string('massassign', 'local_relationship'), 'class' => 'iconsmall')));
         }
@@ -92,8 +92,8 @@ 
 $table = new html_table();
 $table->head = array(get_string('name', 'local_relationship'),
         get_string('memberscount', 'local_relationship'),
-        get_string('limit', 'local_relationship').$OUTPUT->help_icon('userlimit', 'local_relationship'),
-        get_string('uniformdistribute', 'local_relationship').$OUTPUT->help_icon('uniformdistribute', 'local_relationship'),
+        get_string('limit', 'local_relationship') . $OUTPUT->help_icon('userlimit', 'local_relationship'),
+        get_string('uniformdistribute', 'local_relationship') . $OUTPUT->help_icon('uniformdistribute', 'local_relationship'),
         get_string('edit'));
 $table->colclasses = array('leftalign name',
         'leftalign size',
@@ -140,7 +140,7 @@ 
 
     $addgroup = new single_button(new moodle_url('/local/relationship/edit_group.php', array('relationshipid' => $relationshipid)), get_string('addgroup', 'local_relationship'));
     $addgroups = new single_button(new moodle_url('/local/relationship/autogroup.php', array('relationshipid' => $relationshipid)), get_string('autogroup', 'local_relationship'));
-    echo html_writer::tag('div', $OUTPUT->render($addgroup).$OUTPUT->render($addgroups), array('class' => 'buttons'));
+    echo html_writer::tag('div', $OUTPUT->render($addgroup) . $OUTPUT->render($addgroups), array('class' => 'buttons'));
 } else if ($manager) {
     echo $OUTPUT->heading(get_string('noeditable', 'local_relationship'));
 }

settings.php

Spacing +2 added lines, -2 removed lines

@@ -21,11 +21,11 @@
     $settings->add(new admin_setting_heading('local_relationship/settings', get_string('massassignusers', 'local_relationship'), get_string('massassignusers_desc', 'local_relationship')));
 
     $optionsauthtype = array();
-    foreach(get_enabled_auth_plugins(false) as $opt){
+    foreach (get_enabled_auth_plugins(false) as $opt) {
         $optionsauthtype[$opt] = $opt;
     }
     $settings->add(new admin_setting_configselect('local_relationship/authtype', get_string('authtype', 'local_relationship'),
-        get_string('authtype_desc', 'local_relationship') ,'manual', $optionsauthtype));
+        get_string('authtype_desc', 'local_relationship'), 'manual', $optionsauthtype));
 
     $options = array(0=>get_string('no'), 1=>get_string('yes'));
     $setting = new admin_setting_configselect('local_relationship/searchsccp', get_string('searchsccp', 'local_relationship'),