Passed
Push — master ( 6314bf...2403c5 )
by Roberto
45s
created
autogroup.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -21,10 +21,10 @@  discard block
 block discarded – undo
21 21
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
22 22
  */
23 23
 
24
-require_once(__DIR__.'/../../config.php');
25
-require($CFG->dirroot.'/local/relationship/lib.php');
26
-require_once($CFG->dirroot.'/local/relationship/locallib.php');
27
-require_once($CFG->dirroot.'/group/lib.php');
24
+require_once(__DIR__ . '/../../config.php');
25
+require($CFG->dirroot . '/local/relationship/lib.php');
26
+require_once($CFG->dirroot . '/local/relationship/locallib.php');
27
+require_once($CFG->dirroot . '/group/lib.php');
28 28
 
29 29
 require_login();
30 30
 
@@ -104,9 +104,9 @@  discard block
 block discarded – undo
104 104
         $table->data = array();
105 105
         foreach ($new_groups as $group) {
106 106
             if ($group['exists']) {
107
-                $text = html_writer::tag('span', $group['name'], array('style' => 'color:red; font-weight: bold;')).get_string('alreadyexists', 'local_relationship');
107
+                $text = html_writer::tag('span', $group['name'], array('style' => 'color:red; font-weight: bold;')) . get_string('alreadyexists', 'local_relationship');
108 108
             } else if ($group['exists_external']) {
109
-                $text = html_writer::tag('span', $group['name'], array('style' => 'color:red; font-weight: bold;')).get_string('alreadyexistsexternal', 'local_relationship');
109
+                $text = html_writer::tag('span', $group['name'], array('style' => 'color:red; font-weight: bold;')) . get_string('alreadyexistsexternal', 'local_relationship');
110 110
             } else {
111 111
                 $text = $group['name'];
112 112
             }
Please login to merge, or discard this patch.
edit_cohort.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -20,9 +20,9 @@  discard block
 block discarded – undo
20 20
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
21 21
  */
22 22
 
23
-require_once(__DIR__.'/../../config.php');
24
-require($CFG->dirroot.'/local/relationship/lib.php');
25
-require_once($CFG->dirroot.'/local/relationship/locallib.php');
23
+require_once(__DIR__ . '/../../config.php');
24
+require($CFG->dirroot . '/local/relationship/lib.php');
25
+require_once($CFG->dirroot . '/local/relationship/locallib.php');
26 26
 
27 27
 require_login();
28 28
 
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 relationship_set_header($context, $baseurl, $relationship, 'cohorts');
59 59
 
60 60
 if (optional_param('delete', 0, PARAM_BOOL) && $relationshipcohort->id) {
61
-    $desc = format_string($relationshipcohort->role_name.'/'.$relationshipcohort->cohort->name);
61
+    $desc = format_string($relationshipcohort->role_name . '/' . $relationshipcohort->cohort->name);
62 62
     relationship_set_title($relationship, 'deletecohort', $desc);
63 63
     echo $OUTPUT->notification(get_string('deletecohortwarning', 'local_relationship'));
64 64
     $yesurl = new moodle_url('/local/relationship/edit_cohort.php', array('relationshipcohortid' => $relationshipcohort->id, 'relationshipid' => $relationship->id, 'delete' => 1, 'confirmedelete' => 1, 'sesskey' => sesskey()));
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
 }
83 83
 
84 84
 if ($relationshipcohort->id) {
85
-    $desc = format_string($relationshipcohort->role_name.'/'.$relationshipcohort->cohort->name);
85
+    $desc = format_string($relationshipcohort->role_name . '/' . $relationshipcohort->cohort->name);
86 86
     relationship_set_title($relationship, 'editcohort', $desc);
87 87
 } else {
88 88
     relationship_set_title($relationship, 'addcohort');
Please login to merge, or discard this patch.
edit.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -21,10 +21,10 @@  discard block
 block discarded – undo
21 21
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
22 22
  */
23 23
 
24
-require_once(__DIR__.'/../../config.php');
25
-require_once($CFG->libdir.'/filelib.php');
26
-require($CFG->dirroot.'/local/relationship/lib.php');
27
-require_once($CFG->dirroot.'/local/relationship/locallib.php');
24
+require_once(__DIR__ . '/../../config.php');
25
+require_once($CFG->libdir . '/filelib.php');
26
+require($CFG->dirroot . '/local/relationship/lib.php');
27
+require_once($CFG->dirroot . '/local/relationship/locallib.php');
28 28
 
29 29
 require_login();
30 30
 
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 
54 54
 if (optional_param('confirmdelete', 0, PARAM_BOOL) && confirm_sesskey() && $relationship->id) {
55 55
     $res = relationship_delete_relationship($relationship);
56
-    if($res === -1) {
56
+    if ($res === -1) {
57 57
         print_string('has_cohorts', 'local_relationship');
58 58
    }
59 59
     redirect($returnurl);
Please login to merge, or discard this patch.
lib.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
             'relationship',
270 270
             $relationship->id,
271 271
             context::instance_by_id($relationship->contextid),
272
-            $relationship->tags) ;
272
+            $relationship->tags);
273 273
 
274 274
         $event = \local_relationship\event\relationship_created::create(array(
275 275
                 'context' => context::instance_by_id($relationship->contextid),
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
301 301
             'relationship',
302 302
             $relationship->id,
303 303
             context::instance_by_id($relationship->contextid),
304
-            $relationship->tags) ;
304
+            $relationship->tags);
305 305
 
306 306
         $event = \local_relationship\event\relationship_updated::create(array(
307 307
                 'context' => context::instance_by_id($relationship->contextid),
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
 
329 329
     $cohorts = $DB->get_records('relationship_cohorts', array('relationshipid' => $relationship->id));
330 330
 
331
-    if(count($cohorts) == 0) {
331
+    if (count($cohorts) == 0) {
332 332
 
333 333
         $relationshipgroups = $DB->get_records('relationship_groups', array('relationshipid' => $relationship->id));
334 334
         foreach ($relationshipgroups AS $g) {
Please login to merge, or discard this patch.
classes/progress_tracker.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -57,16 +57,16 @@
 block discarded – undo
57 57
         $table->tablealign = 'center';
58 58
 
59 59
         $table->head = array(get_string('titleline', 'local_relationship'));
60
-        $table->align = array ('right');
61
-        foreach($this->columns AS $col) {
62
-            $table->head[] = get_string('title'.$col, 'local_relationship');
60
+        $table->align = array('right');
61
+        foreach ($this->columns AS $col) {
62
+            $table->head[] = get_string('title' . $col, 'local_relationship');
63 63
             $table->align[] = 'left';
64 64
         }
65 65
 
66 66
         $table->data = array();
67 67
         foreach ($this->rows AS $linenum => $r) {
68 68
             $row = array($linenum . '.');
69
-            foreach($r AS $col=>$occurs) {
69
+            foreach ($r AS $col=>$occurs) {
70 70
                 $text = '';
71 71
                 foreach ($occurs AS $occur) {
72 72
                     $msg = html_writer::tag('div', $occur['msg'], array('class' => 'alert-' . $occur['level']));
Please login to merge, or discard this patch.
settings.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -21,11 +21,11 @@
 block discarded – undo
21 21
     $settings->add(new admin_setting_heading('local_relationship/settings', get_string('massassignusers', 'local_relationship'), get_string('massassignusers_desc', 'local_relationship')));
22 22
 
23 23
     $optionsauthtype = array();
24
-    foreach(get_enabled_auth_plugins(false) as $opt){
24
+    foreach (get_enabled_auth_plugins(false) as $opt) {
25 25
         $optionsauthtype[$opt] = $opt;
26 26
     }
27 27
     $settings->add(new admin_setting_configselect('local_relationship/authtype', get_string('authtype', 'local_relationship'),
28
-        get_string('authtype_desc', 'local_relationship') ,'manual', $optionsauthtype));
28
+        get_string('authtype_desc', 'local_relationship'), 'manual', $optionsauthtype));
29 29
 
30 30
     $options = array(0=>get_string('no'), 1=>get_string('yes'));
31 31
     $setting = new admin_setting_configselect('local_relationship/searchsccp', get_string('searchsccp', 'local_relationship'),
Please login to merge, or discard this patch.
locallib.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
 require_once($CFG->dirroot . '/user/selector/lib.php');
27 27
 require_once($CFG->dirroot . '/tag/lib.php');
28 28
 
29
-function relationship_set_header($context, $url, $relationship=null, $module=null) {
29
+function relationship_set_header($context, $url, $relationship = null, $module = null) {
30 30
     global $PAGE, $COURSE, $DB;
31 31
 
32 32
     if ($context->contextlevel != CONTEXT_COURSECAT) {
@@ -43,27 +43,27 @@  discard block
 block discarded – undo
43 43
 
44 44
     $PAGE->navbar->add($category->name, new moodle_url('/course/index.php', array('categoryid'=>$category->id)));
45 45
     $PAGE->navbar->add($navtitle, new moodle_url('/local/relationship/index.php', array('contextid'=>$context->id)));
46
-    if($module) {
46
+    if ($module) {
47 47
         $PAGE->navbar->add(get_string($module, 'local_relationship'),
48 48
                            new moodle_url("/local/relationship/{$module}.php", array('relationshipid'=>$relationship->id)));
49 49
     }
50 50
 }
51 51
 
52
-function relationship_set_title($relationship=null, $action=null, $param=null) {
52
+function relationship_set_title($relationship = null, $action = null, $param = null) {
53 53
     global $OUTPUT;
54 54
 
55 55
     echo $OUTPUT->header();
56
-    if($relationship) {
56
+    if ($relationship) {
57 57
         echo $OUTPUT->heading(get_string('relationship', 'local_relationship') . ': ' . format_string($relationship->name));
58 58
         echo html_writer::empty_tag('BR');
59 59
     }
60
-    if($action) {
60
+    if ($action) {
61 61
         echo $OUTPUT->heading(get_string($action, 'local_relationship', $param), '4');
62 62
     }
63 63
 }
64 64
 
65
-function relationship_groups_parse_name($format, $value, $value_is_a_name=false) {
66
-    if($value_is_a_name) {
65
+function relationship_groups_parse_name($format, $value, $value_is_a_name = false) {
66
+    if ($value_is_a_name) {
67 67
         if (strstr($format, '@') !== false) {
68 68
             $str = str_replace('@', $value, $format);
69 69
         } else {
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
     } else {
73 73
         if (strstr($format, '@') !== false) { // Convert $value to a character series
74 74
             $letter = 'A';
75
-            for($i=0; $i<$value; $i++) {
75
+            for ($i = 0; $i < $value; $i++) {
76 76
                 $letter++;
77 77
             }
78 78
             $str = str_replace('@', $letter, $format);
@@ -87,8 +87,8 @@  discard block
 block discarded – undo
87 87
     $all_roles = role_get_names();
88 88
     $ctx_roles = get_roles_for_contextlevels(CONTEXT_COURSE);
89 89
     $roles = array();
90
-    foreach($ctx_roles AS $id=>$roleid) {
91
-        if($roleid > 2) {
90
+    foreach ($ctx_roles AS $id=>$roleid) {
91
+        if ($roleid > 2) {
92 92
             $roles[$roleid] = $all_roles[$roleid]->localname;
93 93
         }
94 94
     }
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
     $context = context::instance_by_id($relationship->contextid);
104 104
 
105 105
     $contextids = array();
106
-    foreach($context->get_parent_context_ids(true) as $ctxid) {
106
+    foreach ($context->get_parent_context_ids(true) as $ctxid) {
107 107
         $context = context::instance_by_id($ctxid);
108 108
         if (has_capability('moodle/cohort:view', $context)) {
109 109
             $contextids[] = $ctxid;
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
                AND g.idnumber NOT LIKE 'relationship_{$relationshipid}_%'
140 140
           ORDER BY g.name";
141 141
     $groups = array();
142
-    foreach($DB->get_records_sql($sql, array('relationshipid'=>$relationshipid)) as $r) {
142
+    foreach ($DB->get_records_sql($sql, array('relationshipid'=>$relationshipid)) as $r) {
143 143
         $groups[$r->name][] = $r;
144 144
     }
145 145
     return $groups;
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
     $allrelationships = $DB->count_records('relationship', array('contextid'=>$contextid));
224 224
     $totalrelationships = $DB->count_records_sql($countfields . $sql, $params);
225 225
     $relationships = $DB->get_records_sql($fields . $sql . $order, $params, $page*$perpage, $perpage);
226
-    foreach($relationships as $rl) {
226
+    foreach ($relationships as $rl) {
227 227
         $rl->tags = core_tag_tag::get_item_tags_array('relationship', 'relationship', $rl->id);
228 228
     }
229 229
 
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
  * @return mixed
242 242
  * @throws coding_exception
243 243
  */
244
-function relationship_get_cohort_by_roleshortname($relationshipid, $roleshortname, $strictness=IGNORE_MISSING) {
244
+function relationship_get_cohort_by_roleshortname($relationshipid, $roleshortname, $strictness = IGNORE_MISSING) {
245 245
     global $DB;
246 246
 
247 247
     $sql = "SELECT rc.*, ch.name, ch.component, r.name rolename
@@ -266,7 +266,7 @@  discard block
 block discarded – undo
266 266
     return $OUTPUT->box($text, 'generalbox', 'notice');
267 267
 }
268 268
 
269
-function relationship_print_tabs($url, $tabs, $action='') {
269
+function relationship_print_tabs($url, $tabs, $action = '') {
270 270
     global $OUTPUT;
271 271
 
272 272
     if (is_array($tabs) && count($tabs) > 1) {
Please login to merge, or discard this patch.
classes/form/mass_assign.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -25,14 +25,14 @@  discard block
 block discarded – undo
25 25
 defined('MOODLE_INTERNAL') || die();
26 26
 
27 27
 use local_relationship\mass_assign_processor;
28
-require_once($CFG->dirroot.'/lib/formslib.php');
28
+require_once($CFG->dirroot . '/lib/formslib.php');
29 29
 
30 30
 class mass_assign extends \moodleform {
31 31
 
32 32
     /**
33 33
      * Form Definition
34 34
      */
35
-    function definition () {
35
+    function definition() {
36 36
 
37 37
         $mform = $this->_form;
38 38
         $relationshipgroup = $this->_customdata['data'];
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
         $rcs = relationship_get_cohort_by_roleshortname($relationshipgroup->relationshipid, 'student');
49 49
 
50 50
         $cohortrole = get_string('none');
51
-        if($rcs) {
51
+        if ($rcs) {
52 52
             $r = get_string('role');
53 53
             $cohortrole = "{$rcs->name}  ({$r}: $rcs->rolename)";
54 54
         }
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
             $mform->addHelpButton('allowallusers', 'allowallusers', 'local_relationship');
69 69
         }
70 70
 
71
-        if(mass_assign_processor::search_sccp()) {
71
+        if (mass_assign_processor::search_sccp()) {
72 72
             $mform->addElement('checkbox', 'registerpendencies', get_string('registerpendencies', 'local_relationship'), false);
73 73
             $mform->addHelpButton('registerpendencies', 'registerpendencies', 'local_relationship');
74 74
         }
Please login to merge, or discard this patch.
mass_assign.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -22,9 +22,9 @@  discard block
 block discarded – undo
22 22
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
23 23
  */
24 24
 
25
-require_once(__DIR__.'/../../config.php');
26
-require($CFG->dirroot.'/local/relationship/lib.php');
27
-require_once($CFG->dirroot.'/local/relationship/locallib.php');
25
+require_once(__DIR__ . '/../../config.php');
26
+require($CFG->dirroot . '/local/relationship/lib.php');
27
+require_once($CFG->dirroot . '/local/relationship/locallib.php');
28 28
 
29 29
 require_login();
30 30
 
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
 // Therefore, the mass assign only works in cohort without component.
39 39
 // When uniform distribution is enabled, users are uniformly distribute to any group with uniformdistribution = 1 in the relationship,
40 40
 // so uniform distribution needs to be disabled to mass assign users in a specific group.
41
-if(!empty($relationshipcohort->component) || $relationshipcohort->uniformdistribution || $relationshipgroup->uniformdistribution) {
41
+if (!empty($relationshipcohort->component) || $relationshipcohort->uniformdistribution || $relationshipgroup->uniformdistribution) {
42 42
     print_error('cantmassassign', 'local_relationship');
43 43
 }
44 44
 
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
             $rcs = relationship_get_cohort_by_roleshortname($relationshipgroup->relationshipid, 'student');
127 127
 
128 128
             $cohortrole = get_string('none');
129
-            if($rcs) {
129
+            if ($rcs) {
130 130
                 $r = get_string('role');
131 131
                 $cohortrole = "{$rcs->name}  ({$r}: $rcs->rolename)";
132 132
             }
@@ -137,9 +137,9 @@  discard block
 block discarded – undo
137 137
 
138 138
             $recs = $DB->get_records('relationship_pendencies', array('relationshipgroupid'=>$relationshipgroup->id, 'relationshipcohortid'=>$relationshipcohort->id), 'cpf');
139 139
             $table = new html_table();
140
-            $table->head  = array('CPF', get_string('timecreated', 'local_relationship'));
140
+            $table->head = array('CPF', get_string('timecreated', 'local_relationship'));
141 141
             $table->data = array();
142
-            foreach($recs AS $rec) {
142
+            foreach ($recs AS $rec) {
143 143
                 $line = array($rec->cpf, userdate($rec->timecreated));
144 144
                 $baseurl->param('id', $rec->id);
145 145
                 $baseurl->param('delete', 1);
Please login to merge, or discard this patch.