set_constants() - Code Metrics - Inspection of "Update palma_analyze" - UB-Mannheim/PalMA - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#218)

unknown

created 2024-03-06 10:21 UTC

set_constants() F

↳ Parent: Project

Complexity

Conditions	14
Paths	8192

Size

Total Lines	77
Code Lines	50

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	2

Metric	Value
cc	14
eloc	50
c	2
b	1
f	2
nc	8192
nop	0
dl	0
loc	77
rs	2.1

How to fix Long Method Complexity

<?php

function trace($text)
{
    static $firstRun = true;
    if ($firstRun) {
        $firstRun = false;
        openlog("palma", LOG_PID, LOG_USER);
    }
    syslog(LOG_NOTICE, $text);
}

function monitor($action)
{
    if (!defined('CONFIG_MONITOR_URL')) {
      //trace('CONFIG_MONITOR_URL is undefined');
        return;
    }
  //trace("monitor $action");
    $ch = curl_init();
    $url = CONFIG_MONITOR_URL;

  
    curl_setopt_array($ch, array(
                        CURLOPT_RETURNTRANSFER => 1,
                        CURLOPT_URL => CONFIG_MONITOR_URL . '/' . CONFIG_STATIONNAME . '/' . base64_encode($action),
                        CURLOPT_USERAGENT => 'PalMA cURL Request'
                               ));
    $resp = curl_exec($ch);

    curl_close($ch);
}

function set_constants()
{
    // Get some constants from a configuration file.
    $conf_fn = 'palma.ini';
    if (!file_exists($conf_fn)) {
        $conf_fn = '/etc/palma.ini';
    }
    $conf = parse_ini_file($conf_fn);
    //~ print_r($conf);

    // Entries in group 'display'.
    if (array_key_exists('id', $conf)) {
        define('CONFIG_DISPLAY', $conf['id']);
    } else {
        define('CONFIG_DISPLAY', ':1');
    }
    if (array_key_exists('ssh', $conf)) {
        define('CONFIG_SSH', $conf['ssh']);
    } // There is no default value for CONFIG_SSH.

    // Entries in group 'general'.
    if (array_key_exists('password', $conf)) {
        define('CONFIG_PASSWORD', $conf['password']);
    } else {
        define('CONFIG_PASSWORD', false);
    }
    if (array_key_exists('pin', $conf)) {
        define('CONFIG_PIN', $conf['pin']);
    } else {
        define('CONFIG_PIN', true);
    }
    if (array_key_exists('stationname', $conf)) {
        define('CONFIG_STATIONNAME', $conf['stationname']);
    } else {
        define(
            'CONFIG_STATIONNAME',
            str_replace(array("\r", "\n", " "), '', `hostname -f`)
        );
    }
    if (array_key_exists('theme', $conf)) {
        define('CONFIG_THEME', $conf['theme']);
    } else {
        define('CONFIG_THEME', 'demo/simple');
    }

    // Entries in group 'path'.
    if (array_key_exists('start_url', $conf)) {
        define('CONFIG_START_URL', $conf['start_url']);
    } else {
        // By default we use the FQDN of the host
        define(
            'CONFIG_START_URL',
            'http://' . str_replace(array("\r", "\n", " "), '', `hostname -f`) . '/'
        );
    }
    if (array_key_exists('control_file', $conf)) {
        define('CONFIG_CONTROL_FILE', $conf['control_file']);
    } else {
        define('CONFIG_CONTROL_FILE', CONFIG_START_URL . 'control.php');
    }
    if (array_key_exists('policy', $conf)) {
        define('CONFIG_POLICY', $conf['policy']);
    } // There is no default value for CONFIG_POLICY.
    if (array_key_exists('upload_dir', $conf)) {
        define('CONFIG_UPLOAD_DIR', $conf['upload_dir']);
    } else {
        define('CONFIG_UPLOAD_DIR', '/tmp/palma');
    }
    if (array_key_exists('institution_url', $conf)) {
        define('CONFIG_INSTITUTION_URL', $conf['institution_url']);
    } else {
        define('CONFIG_INSTITUTION_URL', '');
    }

    // Entries in group 'monitoring'.
    if (array_key_exists('monitor_url', $conf)) {
        define('CONFIG_MONITOR_URL', $conf['monitor_url']);
    } // There is no default value for CONFIG_MONITOR_URL.
}
set_constants();


1			<?php
2
3			function trace($text)
4			{
5			static $firstRun = true;
6			if ($firstRun) {
7			$firstRun = false;
8			openlog("palma", LOG_PID, LOG_USER);
9			}
10			syslog(LOG_NOTICE, $text);
11			}
12
13			function monitor($action)
14			{
15			if (!defined('CONFIG_MONITOR_URL')) {
16			//trace('CONFIG_MONITOR_URL is undefined');
17			return;
18			}
19			//trace("monitor $action");
20			$ch = curl_init();
21			$url = CONFIG_MONITOR_URL;
			0 ignored issues – show Unused Code introduced 2018-07-19 13:55 UTC by Report Bug Copy Issue Report The assignment to `$url` is dead and can be removed. Loading history...
22
23			curl_setopt_array($ch, array(
24			CURLOPT_RETURNTRANSFER => 1,
25			CURLOPT_URL => CONFIG_MONITOR_URL . '/' . CONFIG_STATIONNAME . '/' . base64_encode($action),
26			CURLOPT_USERAGENT => 'PalMA cURL Request'
27			));
28			$resp = curl_exec($ch);
			0 ignored issues – show Unused Code introduced 2018-07-19 13:55 UTC by Report Bug Copy Issue Report The assignment to `$resp` is dead and can be removed. Loading history...
29			curl_close($ch);
30			}
31
32			function set_constants()
33			{
34			// Get some constants from a configuration file.
35			$conf_fn = 'palma.ini';
36			if (!file_exists($conf_fn)) {
37			$conf_fn = '/etc/palma.ini';
38			}
39			$conf = parse_ini_file($conf_fn);
40			//~ print_r($conf);
41
42			// Entries in group 'display'.
43			if (array_key_exists('id', $conf)) {
44			define('CONFIG_DISPLAY', $conf['id']);
45			} else {
46			define('CONFIG_DISPLAY', ':1');
47			}
48			if (array_key_exists('ssh', $conf)) {
49			define('CONFIG_SSH', $conf['ssh']);
50			} // There is no default value for CONFIG_SSH.
51
52			// Entries in group 'general'.
53			if (array_key_exists('password', $conf)) {
54			define('CONFIG_PASSWORD', $conf['password']);
55			} else {
56			define('CONFIG_PASSWORD', false);
57			}
58			if (array_key_exists('pin', $conf)) {
59			define('CONFIG_PIN', $conf['pin']);
60			} else {
61			define('CONFIG_PIN', true);
62			}
63			if (array_key_exists('stationname', $conf)) {
64			define('CONFIG_STATIONNAME', $conf['stationname']);
65			} else {
66			define(
67			'CONFIG_STATIONNAME',
68			str_replace(array("\r", "\n", " "), '', `hostname -f`)
69			);
70			}
71			if (array_key_exists('theme', $conf)) {
72			define('CONFIG_THEME', $conf['theme']);
73			} else {
74			define('CONFIG_THEME', 'demo/simple');
75			}
76
77			// Entries in group 'path'.
78			if (array_key_exists('start_url', $conf)) {
79			define('CONFIG_START_URL', $conf['start_url']);
80			} else {
81			// By default we use the FQDN of the host
82			define(
83			'CONFIG_START_URL',
84			'http://' . str_replace(array("\r", "\n", " "), '', `hostname -f`) . '/'
85			);
86			}
87			if (array_key_exists('control_file', $conf)) {
88			define('CONFIG_CONTROL_FILE', $conf['control_file']);
89			} else {
90			define('CONFIG_CONTROL_FILE', CONFIG_START_URL . 'control.php');
91			}
92			if (array_key_exists('policy', $conf)) {
93			define('CONFIG_POLICY', $conf['policy']);
94			} // There is no default value for CONFIG_POLICY.
95			if (array_key_exists('upload_dir', $conf)) {
96			define('CONFIG_UPLOAD_DIR', $conf['upload_dir']);
97			} else {
98			define('CONFIG_UPLOAD_DIR', '/tmp/palma');
99			}
100			if (array_key_exists('institution_url', $conf)) {
101			define('CONFIG_INSTITUTION_URL', $conf['institution_url']);
102			} else {
103			define('CONFIG_INSTITUTION_URL', '');
104			}
105
106			// Entries in group 'monitoring'.
107			if (array_key_exists('monitor_url', $conf)) {
108			define('CONFIG_MONITOR_URL', $conf['monitor_url']);
109			} // There is no default value for CONFIG_MONITOR_URL.
110			}
111			set_constants();
112

UB-Mannheim / PalMA

Pull Request — master (#218)

set_constants() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like