checkCredentials()

Complexity

Conditions	13
Paths	8

Size

Total Lines	58
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
function checkCredentials($username, $password)
{
    // Check username + password against fixed internal value and
    // external proxy with authentisation.

    global $errtext;

    $remote = $_SERVER['REMOTE_ADDR'];
    if ($username == 'chef' && $password == 'chef') {
        if ($remote == '::1' || $remote == '127.0.0.1' ||
            preg_match('/^134[.]155[.]36[.]/', $remote) &&
            $remote != '134.155.36.48') {
            // Allow test access for restricted remote hosts (localhost,
            // UB Mannheim library staff, but not via proxy server).
            // TODO: PalMA installations which are accessible from
            // the Internet may want to remove this test access.
            return true;
        } else {
            trace("Test access not allowed for IP address $remote");
            return false;
        }
    }

    if ($username == '' || $password == '') {
        // Don't allow empty user name or password.
        // Proxy authentisation can fail with empty values.
        trace("access denied for user '$username'");
        return false;
    }
    // TODO: testurl sollte auf einem lokalen Server liegen.
    $testurl = 'http://www.weilnetz.de/proxytest';
    $proxy = 'proxy.bib.uni-mannheim.de:3150';
    $curl = curl_init($testurl);
    curl_setopt($curl, CURLOPT_HEADER, true);

It seems like $curl can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

    curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);
    curl_setopt($curl, CURLOPT_PROXY, $proxy);
    curl_setopt($curl, CURLOPT_PROXYAUTH, CURLAUTH_ANY);
    curl_setopt($curl, CURLOPT_PROXYUSERPWD, "$username:$password");
    //~ trace("Start curl");
    $out = curl_exec($curl);

It seems like $curl can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

    curl_close($curl);

It seems like $curl can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

    if (!$out) {
        trace("curl failed for user '$username'");
        $errtext = addslashes(__('Invalid credentials!'));

The function __ was not found. Maybe you did not declare it correctly or list all dependencies?

    } elseif (preg_match('/404 Not Found/', $out)) {

It seems like $out can also be of type true; however, parameter $subject of preg_match() does only seem to accept string, maybe add an additional type check?

        return true;
    } elseif (preg_match('/Could not resolve proxy/', $out)) {
        trace('proxy authentisation was not possible');
        $errtext = addslashes(__('Cannot check credentials, sorry!'));
    } elseif (preg_match('/Cache Access Denied/', $out)) {
        trace("access denied for user '$username'");
        $errtext = addslashes(__('Invalid credentials!'));
    } else {
        trace("access not possible for user '$username'");
        $errtext = addslashes(__('Invalid credentials!'));
    }
    return false;
}