Issues in i12n.php - Fixed Issues - Inspection of "Fix code to satify Scrutinizer" - UB-Mannheim/PalMA - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 344e9e...630bd5 )

by Stefan

created 2018-03-23 18:29 UTC

i12n.php (11 issues)

Labels

Documentation 11

Severity

Minor 11

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

// Copyright (C) 2014-2016 Universitätsbibliothek Mannheim
// See file LICENSE for license details.

// Test whether the script was called directly (used for unit test).
if (!isset($unittest)) {
    $unittest = array();
}
$unittest[__FILE__] = (sizeof(get_included_files()) == 1);

require_once('php-gettext/gettext.inc');

    // The default translations are in locale/en_US.UTF-8/LC_MESSAGES/palma.mo.
    $locale = '';
    if (isset($_REQUEST['lang'])) {
        // User requested language by URL parameter.
        $locale = $_REQUEST['lang'];
        $_SESSION['lang'] = $locale;
    } else if (isset($_SESSION['lang'])) {
        // Get language from session data.
        $locale = $_SESSION['lang'];
    } else if (isset($_SERVER['HTTP_ACCEPT_LANGUAGE'])) {
        // Get language from browser settings.
        $locale = Locale::acceptFromHttp($_SERVER['HTTP_ACCEPT_LANGUAGE']);
    }
    switch (substr($locale, 0, 2)) {
    case 'al':
        // Albanian.
        $locale = 'al_AL.UTF-8';
        break;
    case 'ar':
        // Arabic.
        $locale = 'ar.UTF-8';
        break;
    case 'de':
        // German.
        $locale = 'de_DE.UTF-8';
        break;
    case 'en':
        // English.
        $locale = 'en_US.UTF-8';
        break;
    case 'es':
        // Spanish.
        $locale = 'es_ES.UTF-8';
        break;
    case 'fr':
        // French.
        $locale = 'fr_FR.UTF-8';
        break;
    case 'it':
        // Italian.
        $locale = 'it_IT.UTF-8';
        break;
    case 'lv':
        // Latvian.
        $locale = 'lv_LV.UTF-8';
        break;
    case 'ru':
        // Russian.
        $locale = 'ru_RU.UTF-8';
        break;
    case 'ur':
        // Urdu.
        $locale = 'ur_PK.UTF-8';
        break;
    case 'zh':
        // Chinese.
        $locale = 'zh_CN.UTF-8';
        break;
    default:
        $locale = 'en_US.UTF-8';
        break;
    }
    //~ error_log("setlocale $locale");
    putenv("LANG=$locale");
    _setlocale(LC_MESSAGES, $locale);
    _bindtextdomain('palma', 'locale');
    _bind_textdomain_codeset('palma', 'UTF-8');
    _textdomain('palma');

if ($unittest[__FILE__]) {

    function testlocale($locale = false)
    {
        if ($locale) {
            _setlocale(LC_MESSAGES, $locale);
        }
        error_log(sprintf('%-12s ', ($locale ? $locale : 'default') . ':') . __('Screen section'));
    }

    // Run unit test.

    if (locale_emulation()) {
        print "locale '$locale' is not supported on your system, using custom gettext implementation.\n";
    }
    else {
        print "locale '$locale' is supported on your system, using native gettext implementation.\n";
    }

    testlocale();
    testlocale('al_AL.UTF-8');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    testlocale('ar.UTF-8');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    testlocale('de_DE.UTF-8');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    testlocale('en_US.UTF-8');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    testlocale('es_ES.UTF-8');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    testlocale('fr_FR.UTF-8');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    testlocale('it_IT.UTF-8');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    testlocale('lv_LV.UTF-8');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    testlocale('ru_RU.UTF-8');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    testlocale('ur_PK.UTF-8');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    testlocale('zh_CN.UTF-8');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
}


1			<?php
2
3			// Copyright (C) 2014-2016 Universitätsbibliothek Mannheim
4			// See file LICENSE for license details.
5
6			// Test whether the script was called directly (used for unit test).
7			if (!isset($unittest)) {
8			$unittest = array();
9			}
10			$unittest[__FILE__] = (sizeof(get_included_files()) == 1);
11
12			require_once('php-gettext/gettext.inc');
13
14			// The default translations are in locale/en_US.UTF-8/LC_MESSAGES/palma.mo.
15			$locale = '';
16			if (isset($_REQUEST['lang'])) {
17			// User requested language by URL parameter.
18			$locale = $_REQUEST['lang'];
19			$_SESSION['lang'] = $locale;
20			} else if (isset($_SESSION['lang'])) {
21			// Get language from session data.
22			$locale = $_SESSION['lang'];
23			} else if (isset($_SERVER['HTTP_ACCEPT_LANGUAGE'])) {
24			// Get language from browser settings.
25			$locale = Locale::acceptFromHttp($_SERVER['HTTP_ACCEPT_LANGUAGE']);
26			}
27			switch (substr($locale, 0, 2)) {
28			case 'al':
29			// Albanian.
30			$locale = 'al_AL.UTF-8';
31			break;
32			case 'ar':
33			// Arabic.
34			$locale = 'ar.UTF-8';
35			break;
36			case 'de':
37			// German.
38			$locale = 'de_DE.UTF-8';
39			break;
40			case 'en':
41			// English.
42			$locale = 'en_US.UTF-8';
43			break;
44			case 'es':
45			// Spanish.
46			$locale = 'es_ES.UTF-8';
47			break;
48			case 'fr':
49			// French.
50			$locale = 'fr_FR.UTF-8';
51			break;
52			case 'it':
53			// Italian.
54			$locale = 'it_IT.UTF-8';
55			break;
56			case 'lv':
57			// Latvian.
58			$locale = 'lv_LV.UTF-8';
59			break;
60			case 'ru':
61			// Russian.
62			$locale = 'ru_RU.UTF-8';
63			break;
64			case 'ur':
65			// Urdu.
66			$locale = 'ur_PK.UTF-8';
67			break;
68			case 'zh':
69			// Chinese.
70			$locale = 'zh_CN.UTF-8';
71			break;
72			default:
73			$locale = 'en_US.UTF-8';
74			break;
75			}
76			//~ error_log("setlocale $locale");
77			putenv("LANG=$locale");
78			_setlocale(LC_MESSAGES, $locale);
79			_bindtextdomain('palma', 'locale');
80			_bind_textdomain_codeset('palma', 'UTF-8');
81			_textdomain('palma');
82
83			if ($unittest[__FILE__]) {
84
85			function testlocale($locale = false)
86			{
87			if ($locale) {
88			_setlocale(LC_MESSAGES, $locale);
89			}
90			error_log(sprintf('%-12s ', ($locale ? $locale : 'default') . ':') . __('Screen section'));
91			}
92
93			// Run unit test.
94
95			if (locale_emulation()) {
96			print "locale '$locale' is not supported on your system, using custom gettext implementation.\n";
97			}
98			else {
99			print "locale '$locale' is supported on your system, using native gettext implementation.\n";
100			}
101
102			testlocale();
103			testlocale('al_AL.UTF-8');
			0 ignored issues – show Documentation introduced 2016-07-29 11:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'al_AL.UTF-8'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
104			testlocale('ar.UTF-8');
			0 ignored issues – show Documentation introduced 2016-07-29 11:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'ar.UTF-8'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
105			testlocale('de_DE.UTF-8');
			0 ignored issues – show Documentation introduced 2016-07-29 11:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'de_DE.UTF-8'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
106			testlocale('en_US.UTF-8');
			0 ignored issues – show Documentation introduced 2016-07-29 11:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'en_US.UTF-8'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
107			testlocale('es_ES.UTF-8');
			0 ignored issues – show Documentation introduced 2016-07-29 11:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'es_ES.UTF-8'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
108			testlocale('fr_FR.UTF-8');
			0 ignored issues – show Documentation introduced 2018-03-23 17:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'fr_FR.UTF-8'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
109			testlocale('it_IT.UTF-8');
			0 ignored issues – show Documentation introduced 2016-07-29 11:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'it_IT.UTF-8'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
110			testlocale('lv_LV.UTF-8');
			0 ignored issues – show Documentation introduced 2018-03-23 16:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'lv_LV.UTF-8'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
111			testlocale('ru_RU.UTF-8');
			0 ignored issues – show Documentation introduced 2016-07-29 11:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'ru_RU.UTF-8'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
112			testlocale('ur_PK.UTF-8');
			0 ignored issues – show Documentation introduced 2016-07-29 11:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'ur_PK.UTF-8'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
113			testlocale('zh_CN.UTF-8');
			0 ignored issues – show Documentation introduced 2016-07-29 11:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'zh_CN.UTF-8'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
114			}
115

UB-Mannheim / PalMA

Push — master ( 344e9e...630bd5 )

i12n.php (11 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like