ToBootstrap4 - Code Metrics - Inspection of "support Bootstrap version 4. and allow Inputs to s..." - TuumPHP/Pagination - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5cf04a...7a5848 )

by Asao

created 2018-08-14 06:42 UTC

ToBootstrap4 A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	78
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	9
lcom	1
cbo	2
dl	78
loc	78
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	4	4	1
A	setPaginate()	5	5	1
A	__toString()	4	4	1
A	toString()	15	15	2
A	li()	14	14	3
A	liLabel()	4	4	1

How to fix Duplicated Code

<?php
namespace Tuum\Pagination\ToHtml;

use Tuum\Pagination\Paginate\Page;
use Tuum\Pagination\Paginate\Paginate;
use Tuum\Pagination\Paginate\PaginateInterface;

class ToBootstrap4 implements ToHtmlInterface

{
    /**
     * @var Paginate
     */
    private $paginate;

    /**
     * ToBootstrap3 constructor.
     *
     * @param Paginate $paginate
     */
    public function __construct($paginate = null)
    {
        $this->paginate = $paginate;
    }

    /**
     * @param PaginateInterface $paginate
     * @return ToHtmlInterface
     */
    public function setPaginate(PaginateInterface $paginate)
    {
        $this->paginate = $paginate;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
        return $this;
    }

    /**
     * @return string
     */
    public function __toString()
    {
        return $this->toString();
    }

    /**
     * @return string
     */
    public function toString()
    {
        $paginate = $this->paginate;
        $html     = '<nav aria-label="CPD point list"><ul class="pagination">';
        $html     .= $this->liLabel($paginate->getPrevPage(), '&lt;');
        $html     .= $this->li($paginate->getFirstPage());
        foreach ($paginate as $page) {
            $html .= $this->li($page);
        }
        $html .= $this->li($paginate->getLastPage());
        $html     .= $this->liLabel($paginate->getNextPage(), '&gt;');
        $html .= '</ul></nav>';

        return $html;
    }

    /**
     * @param Page $p
     * @return string
     */
    private function li(Page $p)
    {
        $label = $p->isDisabled('...', $p->getPage());
        $href  = $p->isCurrent('#', $p->getUrl());
        $only  = $p->isCurrent('<span class=\'page-link sr-only\'>current</span>', '');
        if ($p->isDisabled()) {
            return "<li class=\"page-item disabled\"><a class='page-link' href=\"{$href}\" >{$label}</a></li>";
        }
        if ($p->isCurrent()) {
            return "<li class=\"page-item active\"><a class='page-link' href=\"{$href}\" >{$label}{$only}</a></li>\n";
        }

        return "<li class='page-item'><a class='page-link' href=\"{$href}\" >{$label}{$only}</a></li>\n";
    }
    
    private function liLabel(Page $p, $label)
    {
        return "<li class=\"{$p->isCurrent('disabled')}\"><a class='page-link' href=\"{$p->isCurrent('#', $p->getUrl())}\" >{$label}</a></li>\n";
    }
}

1		<?php
2		namespace Tuum\Pagination\ToHtml;
3
4		use Tuum\Pagination\Paginate\Page;
5		use Tuum\Pagination\Paginate\Paginate;
6		use Tuum\Pagination\Paginate\PaginateInterface;
7
8	View Code Duplication	class ToBootstrap4 implements ToHtmlInterface
		0 ignored issues – show Duplication introduced 2018-08-14 06:44 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
9		{
10		/**
11		* @var Paginate
12		*/
13		private $paginate;
14
15		/**
16		* ToBootstrap3 constructor.
17		*
18		* @param Paginate $paginate
19		*/
20		public function __construct($paginate = null)
21		{
22		$this->paginate = $paginate;
23		}
24
25		/**
26		* @param PaginateInterface $paginate
27		* @return ToHtmlInterface
28		*/
29		public function setPaginate(PaginateInterface $paginate)
30		{
31		$this->paginate = $paginate;
		0 ignored issues – show Documentation Bug introduced 2018-08-14 06:44 UTC by Report Bug Copy Issue Report `$paginate` is of type `object<Tuum\Pagination\P...nate\PaginateInterface>`, but the property `$paginate` was declared to be of type `object<Tuum\Pagination\Paginate\Paginate>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
32		return $this;
33		}
34
35		/**
36		* @return string
37		*/
38		public function __toString()
39		{
40		return $this->toString();
41		}
42
43		/**
44		* @return string
45		*/
46		public function toString()
47		{
48		$paginate = $this->paginate;
49		$html = '<nav aria-label="CPD point list"><ul class="pagination">';
50		$html .= $this->liLabel($paginate->getPrevPage(), '<');
51		$html .= $this->li($paginate->getFirstPage());
52		foreach ($paginate as $page) {
53		$html .= $this->li($page);
54		}
55		$html .= $this->li($paginate->getLastPage());
56		$html .= $this->liLabel($paginate->getNextPage(), '>');
57		$html .= '</ul></nav>';
58
59		return $html;
60		}
61
62		/**
63		* @param Page $p
64		* @return string
65		*/
66		private function li(Page $p)
67		{
68		$label = $p->isDisabled('...', $p->getPage());
69		$href = $p->isCurrent('#', $p->getUrl());
70		$only = $p->isCurrent('<span class=\'page-link sr-only\'>current</span>', '');
71		if ($p->isDisabled()) {
72		return "<li class=\"page-item disabled\"><a class='page-link' href=\"{$href}\" >{$label}</a></li>";
73		}
74		if ($p->isCurrent()) {
75		return "<li class=\"page-item active\"><a class='page-link' href=\"{$href}\" >{$label}{$only}</a></li>\n";
76		}
77
78		return "<li class='page-item'><a class='page-link' href=\"{$href}\" >{$label}{$only}</a></li>\n";
79		}
80
81		private function liLabel(Page $p, $label)
82		{
83		return "<li class=\"{$p->isCurrent('disabled')}\"><a class='page-link' href=\"{$p->isCurrent('#', $p->getUrl())}\" >{$label}</a></li>\n";
84		}
85		}

TuumPHP / Pagination

GitHub Access Token became invalid

Push — master ( 5cf04a...7a5848 )

ToBootstrap4 A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like