CryptoManana\Utilities\ElementPicker

Complexity

Total Complexity

8

Size/Duplication

Total Lines	68
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	pickCharacterElement()	0	16	3
A	pickArrayElement()	0	34	5

<?php

/**
 * Utility class for random element picking.
 */

namespace CryptoManana\Utilities;

use \CryptoManana\Core\Abstractions\Containers\AbstractRandomnessInjectable as RandomnessContainer;
use \CryptoManana\Core\Interfaces\Randomness\ElementPickingInterface as ElementChoosing;
use \CryptoManana\Core\StringBuilder as StringBuilder;

/**
 * Class ElementPicker - Utility class for random element picking.
 *
 * @package CryptoManana\Utilities
 */
class ElementPicker extends RandomnessContainer implements ElementChoosing
{
    /**
     * Pick a random character from string.
     *
     * @param string $string The string with characters for choosing from.
     *
     * @return string The chosen character string.
     */
    public function pickCharacterElement($string = '')
    {
        // Validate input
        if (!is_string($string)) {
            throw new \InvalidArgumentException('The supplied argument is not of type string.');
        }

        if (empty($string)) {
            return $string;
        }

        // Convert the string to an array
        $array = StringBuilder::stringSplit($string, 1);

        // Reuse the code for array element choosing
        return static::pickArrayElement($array);

The method CryptoManana\Utilities\ElementPicker::pickArrayElement() is not static, but was called statically.

It seems like $array can also be of type false; however, parameter $array of CryptoManana\Utilities\ElementPicker::pickArrayElement() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * Pick a random element from array.
     *
     * @param array $array The array with elements for choosing from.
     *
     * @return mixed The chosen element from the array.
     */
    public function pickArrayElement(array $array = [])
    {
        // Validate input
        if (empty($array)) {
            return $array;
        }

        $count = count($array);

        $iterator = 0;

        // Choose random index
        $elementIndex = ($count === 1) ? 0 : $this->randomnessSource->getInt(0, $count - 1);

The method getInt() does not exist on null.

        // Reset pointer to begging
        reset($array);

        $tmpElement = null;

        // Iterate through array elements
        foreach ($array as $keyName => $value) {
            // If element is found
            if ($elementIndex == $iterator) {
                $tmpElement = $value;

                break;
            }

            // Update the index
            $iterator++;
        }

        // Return the chosen element
        return $tmpElement;
    }
}