Issues in always.js - Fixed Issues - Inspection of "Scrutinizer bump" - TonyBogdanov/jquery-always - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c7dc0e...f45dbd )

by Tony

created 2018-01-26 12:42 UTC

always.js (2 issues)

Labels

Bug 2

Severity

Major 2

(function (jQuery) {
'use strict';

jQuery = jQuery && jQuery.hasOwnProperty('default') ? jQuery['default'] : jQuery;

var AlwaysData = (function () {
    function AlwaysData() {
    }
    AlwaysData.OPERATION_INSERTION = 0;
    AlwaysData.OPERATION_REMOVAL = 1;
    return AlwaysData;
}());

var Always = (function () {
    function Always(element) {
        var _this = this;
        this.insertedCallbacks = {};
        this.removedCallbacks = {};
        this.element = element;
        this.observer = new MutationObserver(function (mutations) { return mutations.forEach(function (mutation) {

            if ('childList' !== mutation.type) {
                return;
            }
            [].forEach.call(mutation.addedNodes, function (node) {
                if (!(node instanceof HTMLElement)) {
                    return;
                }
                _this.notifyInserted(node);
            });
            [].forEach.call(mutation.removedNodes, function (node) {
                if (!(node instanceof HTMLElement)) {
                    return;
                }
                _this.notifyRemoved(node);
            });
        }); });
        this.observer.observe(this.element, {
            childList: true,
            subtree: true
        });
    }
    Always.data = function (element) {
        if (!element.hasOwnProperty('jQueryAlways')) {
            Object.defineProperty(element, 'jQueryAlways', {
                value: new AlwaysData(),
                configurable: true
            });
        }
        return element.jQueryAlways;
    };
    Always.attach = function (element) {
        var data = this.data(element);
        if (!data.instance) {
            data.instance = new Always(element);
        }
        return data.instance;
    };
    Always.detach = function (element) {
        Always.attach(element).observer.disconnect();
        delete element.jQueryAlways;
    };
    Always.normalizeSelector = function (selector) {
        return selector.split(',').map(function (part) {
            return part.trim();
        }).sort().join(',');
    };
    Always.always = function (element, selector, onInserted, onRemoved) {
        var instance = Always.attach(element);
        if ('function' === typeof onInserted) {
            instance.addInsertedCallback(selector, onInserted);
            [].forEach.call(element.querySelectorAll(selector), function (node) {
                onInserted.call(node);
            });
        }
        if ('function' === typeof onRemoved) {
            instance.addRemovedCallback(selector, onRemoved);
        }
    };
    Always.never = function (element, selector, onInserted, onRemoved) {
        if (!selector) {
            Always.detach(element);
            return;
        }
        var instance = Always.attach(element);
        if (!onInserted && !onRemoved) {
            instance.removeInsertedCallback(selector);
            instance.removeRemovedCallback(selector);
            return;
        }
        if (onInserted) {
            instance.removeInsertedCallback(selector, onInserted);
        }
        if (onRemoved) {
            instance.removeRemovedCallback(selector, onRemoved);
        }
    };
    Always.prototype.addCallback = function (callbacks, selector, callback) {
        selector = Always.normalizeSelector(selector);
        if (!callbacks.hasOwnProperty(selector)) {
            callbacks[selector] = [];
        }
        callbacks[selector].push(callback);
        return this;
    };
    Always.prototype.removeCallback = function (callbacks, selector, callback) {
        selector = Always.normalizeSelector(selector);
        if (!callbacks.hasOwnProperty(selector)) {
            return this;
        }
        if (callback) {
            var index = void 0;
            while (-1 < (index = callbacks[selector].indexOf(callback))) {
                callbacks[selector].splice(index, 1);
            }
        }
        else {
            delete callbacks[selector];
        }
        return this;
    };
    Always.prototype.notifyInserted = function (element) {
        var _this = this;
        var data = Always.data(element);
        if (AlwaysData.OPERATION_INSERTION === data.lastOperation) {
            return this;
        }
        data.lastOperation = AlwaysData.OPERATION_INSERTION;
        Object.keys(this.insertedCallbacks).forEach(function (selector) {
            if (element.matches(selector)) {
                _this.insertedCallbacks[selector].forEach(function (callback) {
                    callback.call(element);
                });
            }
        });
        [].forEach.call(element.querySelectorAll('*'), function (node) {
            _this.notifyInserted(node);
        });
        return this;
    };
    Always.prototype.notifyRemoved = function (element) {
        var _this = this;
        var data = Always.data(element);
        if (AlwaysData.OPERATION_REMOVAL === data.lastOperation) {
            return this;
        }
        data.lastOperation = AlwaysData.OPERATION_REMOVAL;
        [].forEach.call(element.querySelectorAll('*'), function (node) {
            _this.notifyRemoved(node);
        });
        Object.keys(this.removedCallbacks).forEach(function (selector) {
            if (element.matches(selector)) {
                _this.removedCallbacks[selector].forEach(function (callback) {
                    callback.call(element);
                });
            }
        });
        return this;
    };
    Always.prototype.addInsertedCallback = function (selector, callback) {
        return this.addCallback(this.insertedCallbacks, selector, callback);
    };
    Always.prototype.addRemovedCallback = function (selector, callback) {
        return this.addCallback(this.removedCallbacks, selector, callback);
    };
    Always.prototype.removeInsertedCallback = function (selector, callback) {
        return this.removeCallback(this.insertedCallbacks, selector, callback);
    };
    Always.prototype.removeRemovedCallback = function (selector, callback) {
        return this.removeCallback(this.removedCallbacks, selector, callback);
    };
    return Always;
}());

function bindingNative() {
    window.Always = {
        always: Always.always,
        never: Always.never
    };
}

function bindingJQuery() {
    if ('undefined' === typeof jQuery) {
        return;
    }
    (function ($) {
        $.extend($.fn, {
            always: function (selector, onInserted, onRemoved) {
                return $(this).each(function () {
                    Always.always(this, selector, onInserted, onRemoved);
                });
            },
            never: function (selector, onInserted, onRemoved) {
                return $(this).each(function () {
                    Always.never(this, selector, onInserted, onRemoved);
                });
            }
        });
    })(jQuery);
}

var Bindings = (function () {
    function Bindings() {
    }
    Bindings.native = bindingNative;
    Bindings.jQuery = bindingJQuery;
    return Bindings;
}());

function polyfillMutationObserver() {
    if (window.MutationObserver) {
        return;
    }
    window.MutationObserver = window.WebKitMutationObserver;
}

function polyfillElementMatches() {
    var _this = this;
    var prototype = Element.prototype;

    if (prototype.matches) {
        return;
    }
    prototype.matches =
        prototype.matchesSelector ||
            prototype.mozMatchesSelector ||
            prototype.msMatchesSelector ||
            prototype.oMatchesSelector ||
            prototype.webkitMatchesSelector ||
            (function (s) {
                var matches = (_this.document || _this.ownerDocument).querySelectorAll(s), i = matches.length;
                while (--i >= 0 && matches.item(i) !== _this) { }
                return i > -1;
            });
}

var Polyfills = (function () {
    function Polyfills() {
    }
    Polyfills.elementMatches = polyfillElementMatches;
    Polyfills.mutationObserver = polyfillMutationObserver;
    return Polyfills;
}());

Polyfills.elementMatches();
Polyfills.mutationObserver();
Bindings.native();
Bindings.jQuery();

}(jQuery));


1			(function (jQuery) {
2			'use strict';
3
4			jQuery = jQuery && jQuery.hasOwnProperty('default') ? jQuery['default'] : jQuery;
5
6			var AlwaysData = (function () {
7			function AlwaysData() {
8			}
9			AlwaysData.OPERATION_INSERTION = 0;
10			AlwaysData.OPERATION_REMOVAL = 1;
11			return AlwaysData;
12			}());
13
14			var Always = (function () {
15			function Always(element) {
16			var _this = this;
17			this.insertedCallbacks = {};
18			this.removedCallbacks = {};
19			this.element = element;
20			this.observer = new MutationObserver(function (mutations) { return mutations.forEach(function (mutation) {
			0 ignored issues – show Bug introduced 2018-01-26 12:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `MutationObserver` seems to be never declared. If this is a global, consider adding a `/** global: MutationObserver */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
21			if ('childList' !== mutation.type) {
22			return;
23			}
24			[].forEach.call(mutation.addedNodes, function (node) {
25			if (!(node instanceof HTMLElement)) {
26			return;
27			}
28			_this.notifyInserted(node);
29			});
30			[].forEach.call(mutation.removedNodes, function (node) {
31			if (!(node instanceof HTMLElement)) {
32			return;
33			}
34			_this.notifyRemoved(node);
35			});
36			}); });
37			this.observer.observe(this.element, {
38			childList: true,
39			subtree: true
40			});
41			}
42			Always.data = function (element) {
43			if (!element.hasOwnProperty('jQueryAlways')) {
44			Object.defineProperty(element, 'jQueryAlways', {
45			value: new AlwaysData(),
46			configurable: true
47			});
48			}
49			return element.jQueryAlways;
50			};
51			Always.attach = function (element) {
52			var data = this.data(element);
53			if (!data.instance) {
54			data.instance = new Always(element);
55			}
56			return data.instance;
57			};
58			Always.detach = function (element) {
59			Always.attach(element).observer.disconnect();
60			delete element.jQueryAlways;
61			};
62			Always.normalizeSelector = function (selector) {
63			return selector.split(',').map(function (part) {
64			return part.trim();
65			}).sort().join(',');
66			};
67			Always.always = function (element, selector, onInserted, onRemoved) {
68			var instance = Always.attach(element);
69			if ('function' === typeof onInserted) {
70			instance.addInsertedCallback(selector, onInserted);
71			[].forEach.call(element.querySelectorAll(selector), function (node) {
72			onInserted.call(node);
73			});
74			}
75			if ('function' === typeof onRemoved) {
76			instance.addRemovedCallback(selector, onRemoved);
77			}
78			};
79			Always.never = function (element, selector, onInserted, onRemoved) {
80			if (!selector) {
81			Always.detach(element);
82			return;
83			}
84			var instance = Always.attach(element);
85			if (!onInserted && !onRemoved) {
86			instance.removeInsertedCallback(selector);
87			instance.removeRemovedCallback(selector);
88			return;
89			}
90			if (onInserted) {
91			instance.removeInsertedCallback(selector, onInserted);
92			}
93			if (onRemoved) {
94			instance.removeRemovedCallback(selector, onRemoved);
95			}
96			};
97			Always.prototype.addCallback = function (callbacks, selector, callback) {
98			selector = Always.normalizeSelector(selector);
99			if (!callbacks.hasOwnProperty(selector)) {
100			callbacks[selector] = [];
101			}
102			callbacks[selector].push(callback);
103			return this;
104			};
105			Always.prototype.removeCallback = function (callbacks, selector, callback) {
106			selector = Always.normalizeSelector(selector);
107			if (!callbacks.hasOwnProperty(selector)) {
108			return this;
109			}
110			if (callback) {
111			var index = void 0;
112			while (-1 < (index = callbacks[selector].indexOf(callback))) {
113			callbacks[selector].splice(index, 1);
114			}
115			}
116			else {
117			delete callbacks[selector];
118			}
119			return this;
120			};
121			Always.prototype.notifyInserted = function (element) {
122			var _this = this;
123			var data = Always.data(element);
124			if (AlwaysData.OPERATION_INSERTION === data.lastOperation) {
125			return this;
126			}
127			data.lastOperation = AlwaysData.OPERATION_INSERTION;
128			Object.keys(this.insertedCallbacks).forEach(function (selector) {
129			if (element.matches(selector)) {
130			_this.insertedCallbacks[selector].forEach(function (callback) {
131			callback.call(element);
132			});
133			}
134			});
135			[].forEach.call(element.querySelectorAll('*'), function (node) {
136			_this.notifyInserted(node);
137			});
138			return this;
139			};
140			Always.prototype.notifyRemoved = function (element) {
141			var _this = this;
142			var data = Always.data(element);
143			if (AlwaysData.OPERATION_REMOVAL === data.lastOperation) {
144			return this;
145			}
146			data.lastOperation = AlwaysData.OPERATION_REMOVAL;
147			[].forEach.call(element.querySelectorAll('*'), function (node) {
148			_this.notifyRemoved(node);
149			});
150			Object.keys(this.removedCallbacks).forEach(function (selector) {
151			if (element.matches(selector)) {
152			_this.removedCallbacks[selector].forEach(function (callback) {
153			callback.call(element);
154			});
155			}
156			});
157			return this;
158			};
159			Always.prototype.addInsertedCallback = function (selector, callback) {
160			return this.addCallback(this.insertedCallbacks, selector, callback);
161			};
162			Always.prototype.addRemovedCallback = function (selector, callback) {
163			return this.addCallback(this.removedCallbacks, selector, callback);
164			};
165			Always.prototype.removeInsertedCallback = function (selector, callback) {
166			return this.removeCallback(this.insertedCallbacks, selector, callback);
167			};
168			Always.prototype.removeRemovedCallback = function (selector, callback) {
169			return this.removeCallback(this.removedCallbacks, selector, callback);
170			};
171			return Always;
172			}());
173
174			function bindingNative() {
175			window.Always = {
176			always: Always.always,
177			never: Always.never
178			};
179			}
180
181			function bindingJQuery() {
182			if ('undefined' === typeof jQuery) {
183			return;
184			}
185			(function ($) {
186			$.extend($.fn, {
187			always: function (selector, onInserted, onRemoved) {
188			return $(this).each(function () {
189			Always.always(this, selector, onInserted, onRemoved);
190			});
191			},
192			never: function (selector, onInserted, onRemoved) {
193			return $(this).each(function () {
194			Always.never(this, selector, onInserted, onRemoved);
195			});
196			}
197			});
198			})(jQuery);
199			}
200
201			var Bindings = (function () {
202			function Bindings() {
203			}
204			Bindings.native = bindingNative;
205			Bindings.jQuery = bindingJQuery;
206			return Bindings;
207			}());
208
209			function polyfillMutationObserver() {
210			if (window.MutationObserver) {
211			return;
212			}
213			window.MutationObserver = window.WebKitMutationObserver;
214			}
215
216			function polyfillElementMatches() {
217			var _this = this;
218			var prototype = Element.prototype;
			0 ignored issues – show Bug introduced 2018-01-26 12:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `Element` seems to be never declared. If this is a global, consider adding a `/** global: Element */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
219			if (prototype.matches) {
220			return;
221			}
222			prototype.matches =
223			prototype.matchesSelector \|\|
224			prototype.mozMatchesSelector \|\|
225			prototype.msMatchesSelector \|\|
226			prototype.oMatchesSelector \|\|
227			prototype.webkitMatchesSelector \|\|
228			(function (s) {
229			var matches = (_this.document \|\| _this.ownerDocument).querySelectorAll(s), i = matches.length;
230			while (--i >= 0 && matches.item(i) !== _this) { }
231			return i > -1;
232			});
233			}
234
235			var Polyfills = (function () {
236			function Polyfills() {
237			}
238			Polyfills.elementMatches = polyfillElementMatches;
239			Polyfills.mutationObserver = polyfillMutationObserver;
240			return Polyfills;
241			}());
242
243			Polyfills.elementMatches();
244			Polyfills.mutationObserver();
245			Bindings.native();
246			Bindings.jQuery();
247
248			}(jQuery));
249

TonyBogdanov / jquery-always

Push — master ( c7dc0e...f45dbd )

always.js (2 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like