Conditions | 12 |
Paths | 36 |
Total Lines | 85 |
Code Lines | 66 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
67 | protected static function generate( |
||
68 | Config $annotation, |
||
69 | string $className, |
||
70 | string $classNamespace, |
||
71 | int &$subClassIteration = 0 |
||
72 | ): string { |
||
73 | $canonicalClassName = $classNamespace . '\\' . $className; |
||
74 | |||
75 | $effectiveClassName = $className . (0 < $subClassIteration ? '_' . $subClassIteration : ''); |
||
76 | $effectiveCanonicalClassName = $canonicalClassName . (0 < $subClassIteration ? '_' . $subClassIteration : ''); |
||
77 | |||
78 | $generator = new ClassGenerator($annotation, $effectiveClassName, $classNamespace); |
||
79 | |||
80 | /** |
||
81 | * @var string $key |
||
82 | * @var ConfigEntryInterface $entry |
||
83 | */ |
||
84 | foreach ($annotation->value as $key => $entry) { |
||
85 | switch (true) { |
||
86 | case $entry instanceof ConfigString: |
||
87 | case $entry instanceof ConfigInteger: |
||
88 | case $entry instanceof ConfigFloat: |
||
89 | case $entry instanceof ConfigBoolean: |
||
90 | case $entry instanceof ConfigObject: |
||
91 | $generator |
||
92 | ->generateProperty($key, $entry->getType(), isset($entry->default) ? $entry->default : null) |
||
93 | ->generateGet($key, $entry->getType()) |
||
94 | ->generateSet($key, $entry->getType()) |
||
95 | ->generateIsset($key) |
||
96 | ->generateUnset($key); |
||
97 | break; |
||
98 | |||
99 | case $entry instanceof ConfigArray: |
||
100 | $generator |
||
101 | ->generateProperty($key, $entry->value->getType() . '[]') |
||
102 | ->generateArrayGet($key, $entry->value->getType() . '[]') |
||
103 | ->generateArraySet($key, $entry->value->getType() . '[]') |
||
104 | ->generateArrayGetAt($key, $entry->value->getType()) |
||
105 | ->generateArraySetAt($key, $entry->value->getType()) |
||
106 | ->generateArrayClear($key) |
||
107 | ->generateArrayPush($key, $entry->value->getType()) |
||
108 | ->generateArrayUnshift($key, $entry->value->getType()) |
||
109 | ->generateArrayPop($key, $entry->value->getType()) |
||
110 | ->generateArrayShift($key, $entry->value->getType()) |
||
111 | ->generateIsset($key) |
||
112 | ->generateUnset($key); |
||
113 | break; |
||
114 | |||
115 | case $entry instanceof Config: |
||
116 | $subClassIteration++; |
||
117 | $entryCanonicalClassName = static::generate( |
||
118 | $entry, |
||
119 | $className, |
||
120 | $classNamespace, |
||
121 | $subClassIteration |
||
122 | ); |
||
123 | $generator |
||
124 | ->generateProperty($key, $entryCanonicalClassName) |
||
125 | ->generateConfigGet($key, $entryCanonicalClassName) |
||
126 | ->generateConfigSet($key) |
||
127 | ->generateConfigIsset($key) |
||
128 | ->generateConfigUnset($key); |
||
129 | break; |
||
130 | |||
131 | default: |
||
132 | throw new \RuntimeException(sprintf( |
||
133 | 'Invalid or unsupported configuration entry type: "%s".', |
||
134 | get_class($entry) |
||
135 | )); |
||
136 | } |
||
137 | } |
||
138 | |||
139 | $generator |
||
140 | ->generateMagicGet() |
||
141 | ->generateMagicSet() |
||
142 | ->generateMagicIsset() |
||
143 | ->generateMagicUnset(); |
||
144 | |||
145 | file_put_contents( |
||
146 | static::getCachePath(true) . '/' . $effectiveClassName . '.php', |
||
147 | (string) $generator |
||
148 | ); |
||
149 | |||
150 | return $effectiveCanonicalClassName; |
||
151 | } |
||
152 | |||
232 | } |