TonisOrmisson / yii2-address-form

controllers/QueryController.php

<?php
namespace tonisormisson\addressform\controllers;

use tonisormisson\addressform\AddressHelper;
use yii\web\Controller;
use Rinvex\Country\Country;

/**
 * Class QueryController
 * @package tonisormisson\addressform
 * @author Tõnis Ormisson <tonis@andmemasin.eu>
 */
class QueryController extends Controller
{
    /**
     * {@inheritdoc}
     */
    public function init()
    {
        parent::init();
        \Yii::$app->response->format = \yii\web\Response::FORMAT_JSON;
    }


    /**
     * @return array
     */
    public function actionRegions()
    {
        $request = \Yii::$app->request;

It seems like Yii::app->request can also be of type yii\web\Request. However, the property $request is declared as type yii\console\Request. Maybe add an additional type check?

        if ($request->isAjax && $request->post('depdrop_parents')) {
            $ids = $request->post('depdrop_parents');
            $countryCode = empty($ids[0]) ? null : $ids[0];
            $country = country($countryCode);
            if ($country instanceof Country) {

$country is always a sub-type of Rinvex\Country\Country.

                return ['output'=> (new AddressHelper())->formatList($country->getDivisions()), 'selected'=>'yee'];
            }
        }
        return ['output'=>'', 'selected'=>''];
    }


}