Message::getMessage() - Code Metrics - Inspection of "changes" - TomasSjosten/Message - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e832f1...3f2565 )

by Tomas

created 2016-02-21 10:28 UTC

Message::getMessage() A

↳ Parent: Message

Complexity

Conditions	3
Paths	3

Size

Total Lines	17
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	17
rs	9.4285
cc	3
eloc	9
nc	3
nop	0

<?php

namespace Tosj\Message;

class Message
{
    private $message = null;
    private $test;

    public function __construct(bool $test = false)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $this->test = $test;

        // Save to object and free Session
        if (session_status() === PHP_SESSION_ACTIVE) {
            $this->message = (isset($_SESSION['message']) && $_SESSION['message']) ? $_SESSION['message'] : null;
            unset($_SESSION['message']);
        }
    }


    public function setMessage($thisMessage)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if ($this->test) {
            $this->message[] = $thisMessage;
        } else {
            // Save new messages to session
            $_SESSION['message'][] = $thisMessage;
        }
    }


    public function getMessage()
    {
        $html = null;
        // Print messages
        if ($this->message && $this->message !== '') {

            $html = '<div id="messagebox">';
            foreach ($this->message as $msg)
            {
                $html .= '
                <div class="message '.htmlentities($msg["type"]).'">
                    <p>'.htmlentities($msg["msg"]).'</p>
                </div>';
            }
            $html .= '</div>';
        }
        return $html;
    }
}


1			<?php
2
3			namespace Tosj\Message;
4
5			class Message
6			{
7			private $message = null;
8			private $test;
9
10			public function __construct(bool $test = false)
			0 ignored issues – show Coding Style introduced 2016-02-20 08:28 UTC by Report Bug Copy Issue Report `__construct` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
11			{
12			$this->test = $test;
13
14			// Save to object and free Session
15			if (session_status() === PHP_SESSION_ACTIVE) {
16			$this->message = (isset($_SESSION['message']) && $_SESSION['message']) ? $_SESSION['message'] : null;
17			unset($_SESSION['message']);
18			}
19			}
20
21
22			public function setMessage($thisMessage)
			0 ignored issues – show Coding Style introduced 2016-02-20 08:28 UTC by Report Bug Copy Issue Report `setMessage` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
23			{
24			if ($this->test) {
25			$this->message[] = $thisMessage;
26			} else {
27			// Save new messages to session
28			$_SESSION['message'][] = $thisMessage;
29			}
30			}
31
32
33			public function getMessage()
34			{
35			$html = null;
36			// Print messages
37			if ($this->message && $this->message !== '') {
			0 ignored issues – show Bug Best Practice introduced 2016-02-21 10:30 UTC by Report Bug Copy Issue Report The expression `$this->message` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
38			$html = '<div id="messagebox">';
39			foreach ($this->message as $msg)
40			{
41			$html .= '
42			<div class="message '.htmlentities($msg["type"]).'">
43			<p>'.htmlentities($msg["msg"]).'</p>
44			</div>';
45			}
46			$html .= '</div>';
47			}
48			return $html;
49			}
50			}
51

TomasSjosten / Message

Push — master ( e832f1...3f2565 )

Message::getMessage() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like