DefaultTransformer::addWhereClause() - Code Metrics - Inspection of "Feature/issue 2/api consumer" - TomHart/laravel-restful-controller - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#14)

by Tom

created 2020-01-14 22:10 UTC

DefaultTransformer::addWhereClause() A

↳ Parent: DefaultTransformer

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.8333
c	0
b	0
f	0
cc	2
nc	2
nop	2

<?php

namespace TomHart\Restful\Transformers;

use TomHart\Restful\Builder;
use TomHart\Restful\Concerns\Transformer;

class DefaultTransformer implements Transformer
{

    /**
     * Assemble the query string from the builder.
     * @param Builder $builder
     * @return mixed[]
     */
    public function buildQueryString(Builder $builder): array
    {
        $queryString = [];

        // Add the where clauses to the query string.
        foreach ($builder->getWheres() as $where) {
            $queryString = $this->addWhereClause($where, $queryString);
        }

        // Add the order.
        if ($builder->getOrder()) {
            $queryString[config('api-database.query_string_keys.order', 'order')] = $builder->getOrder();
        }

        // Add the limit.
        if ($builder->getLimit()) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $queryString[config('api-database.query_string_keys.limit', 'limit')] = $builder->getLimit();
        }

        return $queryString;
    }

    /**
     * Adds a where clause to the query string.
     * @param string[] $where
     * @param mixed[] $queryString
     * @return string[]
     */
    private function addWhereClause(array $where, array $queryString): array
    {
        switch ($where['type']) {
            default:
                $queryString[$where['column']] = $where['value'];
                break;
            case 'In':
                $queryString[$where['column']] = $where['values'];
                break;
        }

        return $queryString;
    }
}


1			<?php
2
3			namespace TomHart\Restful\Transformers;
4
5			use TomHart\Restful\Builder;
6			use TomHart\Restful\Concerns\Transformer;
7
8			class DefaultTransformer implements Transformer
9			{
10
11			/**
12			* Assemble the query string from the builder.
13			* @param Builder $builder
14			* @return mixed[]
15			*/
16			public function buildQueryString(Builder $builder): array
17			{
18			$queryString = [];
19
20			// Add the where clauses to the query string.
21			foreach ($builder->getWheres() as $where) {
22			$queryString = $this->addWhereClause($where, $queryString);
23			}
24
25			// Add the order.
26			if ($builder->getOrder()) {
27			$queryString[config('api-database.query_string_keys.order', 'order')] = $builder->getOrder();
28			}
29
30			// Add the limit.
31			if ($builder->getLimit()) {
			0 ignored issues – show Bug Best Practice introduced 2020-01-14 22:12 UTC by Report Bug Copy Issue Report The expression `$builder->getLimit()` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be zero. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
32			$queryString[config('api-database.query_string_keys.limit', 'limit')] = $builder->getLimit();
33			}
34
35			return $queryString;
36			}
37
38			/**
39			* Adds a where clause to the query string.
40			* @param string[] $where
41			* @param mixed[] $queryString
42			* @return string[]
43			*/
44			private function addWhereClause(array $where, array $queryString): array
45			{
46			switch ($where['type']) {
47			default:
48			$queryString[$where['column']] = $where['value'];
49			break;
50			case 'In':
51			$queryString[$where['column']] = $where['values'];
52			break;
53			}
54
55			return $queryString;
56			}
57			}
58

TomHart / laravel-restful-controller

Pull Request — master (#14)

DefaultTransformer::addWhereClause() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like