RequestServerErrorVoter::shouldCatchThrowable() - Code Metrics - Inspection of "Start to support php-http" - Tolerance/Tolerance - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#91)

by Timothée

created 2017-02-13 10:50 UTC

RequestServerErrorVoter::shouldCatchThrowable() A

↳ Parent: RequestServerErrorVoter

Complexity

Conditions	4
Paths	4

Size

Total Lines	8
Code Lines	5

Duplication

Lines	8
Ratio	100 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	8
loc	8
rs	9.2
cc	4
eloc	5
nc	4
nop	1

<?php

/*
 * This file is part of the Tolerance package.
 *
 * (c) Samuel ROZE <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tolerance\Bridge\PhpHttp;

use Psr\Http\Message\ResponseInterface;
use Tolerance\Operation\Exception\PromiseException;
use Tolerance\Operation\ExceptionCatcher\ThrowableCatcherVoter;

final class RequestServerErrorVoter implements ThrowableCatcherVoter

{
    /**
     * {@inheritdoc}
     */
    public function shouldCatch(\Exception $e)
    {
        return $this->shouldCatchThrowable($e);
    }

    /**
     * {@inheritdoc}
     */
    public function shouldCatchThrowable($throwable)
    {
        return !$throwable instanceof PromiseException
            || $throwable->isRejected()
            || !$throwable->getValue() instanceof ResponseInterface
            || $throwable->getValue()->getStatusCode() >= 500
        ;
    }
}


1		<?php
2
3		/*
4		* This file is part of the Tolerance package.
5		*
6		* (c) Samuel ROZE <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Tolerance\Bridge\PhpHttp;
13
14		use Psr\Http\Message\ResponseInterface;
15		use Tolerance\Operation\Exception\PromiseException;
16		use Tolerance\Operation\ExceptionCatcher\ThrowableCatcherVoter;
17
18	View Code Duplication	final class RequestServerErrorVoter implements ThrowableCatcherVoter
		0 ignored issues – show Duplication introduced 2017-02-10 17:20 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19		{
20		/**
21		* {@inheritdoc}
22		*/
23		public function shouldCatch(\Exception $e)
24		{
25		return $this->shouldCatchThrowable($e);
26		}
27
28		/**
29		* {@inheritdoc}
30		*/
31		public function shouldCatchThrowable($throwable)
32		{
33		return !$throwable instanceof PromiseException
34		\|\| $throwable->isRejected()
35		\|\| !$throwable->getValue() instanceof ResponseInterface
36		\|\| $throwable->getValue()->getStatusCode() >= 500
37		;
38		}
39		}
40

Tolerance / Tolerance

Pull Request — master (#91)

RequestServerErrorVoter::shouldCatchThrowable() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like