ApplicationTest::setUp() - Code Metrics - Inspection of "Remove unused assignment and add scrutinizer" - Tiriel/MyBlog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4c4ab9...532c3a )

by Benjamin

created 2018-05-23 15:17 UTC

ApplicationTest::setUp() A

↳ Parent: ApplicationTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	17
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	13
nc	1
nop	0
dl	0
loc	17
rs	9.4285
c	0
b	0
f	0

<?php

namespace Tests;

use App\Application;
use App\Lib\Http\Request;
use App\Lib\Routing\Router;
use GuzzleHttp\Psr7\Response;
use PHPUnit\Framework\TestCase;

class ApplicationTest extends TestCase
{
    protected $app;

    /* @var PHPUnit_Framework_MockObject_MockObject */

    protected $router;

    public function setUp()
    {
        $this->router = $this

            ->getMockBuilder(Router::class)
            ->disableOriginalConstructor()
            ->disableOriginalClone()
            ->disableArgumentCloning()
            ->disallowMockingUnknownTypes()
            ->setMethods(['route'])
            ->getMock();

        $this->router
             ->expects($this->once())
             ->method('route')
             ->willReturn(['controller' => 'Default', 'action' => 'notFound', 'params' => []]);

        $this->app = new Application($this->router);
    }

    public function testRouterIsCalled()
    {
        $this->app->handleRequest(new Request());
    }

    public function testHandleRequestReturnsResponse()
    {
        $return = $this->app->handleRequest(new Request());
        $this->assertInstanceOf(Response::class, $return);
    }
}


1			<?php
2
3			namespace Tests;
4
5			use App\Application;
6			use App\Lib\Http\Request;
7			use App\Lib\Routing\Router;
8			use GuzzleHttp\Psr7\Response;
9			use PHPUnit\Framework\TestCase;
10
11			class ApplicationTest extends TestCase
12			{
13			protected $app;
14
15			/* @var PHPUnit_Framework_MockObject_MockObject */
			0 ignored issues – show Bug introduced 2018-05-23 15:20 UTC by Report Bug Copy Issue Report The type `Tests\PHPUnit_Framework_MockObject_MockObject` was not found. Did you mean `PHPUnit_Framework_MockObject_MockObject`? If so, make sure to prefix the type with `\`. Loading history...
16			protected $router;
17
18			public function setUp()
19			{
20			$this->router = $this
			0 ignored issues – show Documentation Bug introduced 2018-05-23 15:20 UTC by Report Bug Copy Issue Report It seems like `$this->getMockBuilder(Ap...ay('route'))->getMock()` of type `PHPUnit\Framework\MockObject\MockObject` is incompatible with the declared type `Tests\PHPUnit_Framework_MockObject_MockObject` of property `$router`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
21			->getMockBuilder(Router::class)
22			->disableOriginalConstructor()
23			->disableOriginalClone()
24			->disableArgumentCloning()
25			->disallowMockingUnknownTypes()
26			->setMethods(['route'])
27			->getMock();
28
29			$this->router
30			->expects($this->once())
31			->method('route')
32			->willReturn(['controller' => 'Default', 'action' => 'notFound', 'params' => []]);
33
34			$this->app = new Application($this->router);
35			}
36
37			public function testRouterIsCalled()
38			{
39			$this->app->handleRequest(new Request());
40			}
41
42			public function testHandleRequestReturnsResponse()
43			{
44			$return = $this->app->handleRequest(new Request());
45			$this->assertInstanceOf(Response::class, $return);
46			}
47			}
48

Tiriel / MyBlog

GitHub Access Token became invalid

Push — master ( 4c4ab9...532c3a )

ApplicationTest::setUp() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like