Dbal::query() - Code Metrics - Inspection of "First draft at Dbal wrapper, tests coming" - Tiriel/MyBlog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 50f2fa...d58e83 )

by Benjamin

created 2018-05-30 14:56 UTC

Dbal::query() B

↳ Parent: Dbal

Complexity

Conditions	6
Paths	3

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	42

Importance

Changes

Metric	Value
cc	6
eloc	5
nc	3
nop	4
dl	0
loc	8
ccs	0
cts	8
cp	0
crap	42
rs	8.8571
c	0
b	0
f	0

<?php

namespace Lib\Db\Dbal;

class Dbal
{
    private $conn;

    public function __construct(?Connection $conn)
    {
        $this->conn = $conn ?? new Connection();
    }

    public function beginTransaction()
    {
        return $this->conn->beginTransaction();
    }

    public function commit()
    {
        return $this->conn->commit();
    }

    public function exec(string $statement)
    {
        return $this->conn->exec($statement);
    }

    public function lastInsertId(string $name = null)
    {
        return $this->conn->lastInsertId($name);
    }

    public function prepare(string $statement, array $driverOptions = [])
    {
        return $this->conn->prepare($statement, $driverOptions);
    }

    public function query(string $statement, int $fetch = null, $arg3 = null, $arg4 = null)
    {
        if ($fetch && $arg3 && $arg4) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            return $this->conn->query($statement, $fetch, $arg3, $arg4);
        } elseif ($fetch && $arg3) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            return $this->conn->query($statement, $fetch, $arg3);
        }
        return $this->conn->query($statement);
    }

    public function rollback($param)
    public function rollback(/** @scrutinizer ignore-unused */ $param)
    {
        return $this->conn->rollback();
    }
}


Tiriel / MyBlog

GitHub Access Token became invalid

Push — master ( 50f2fa...d58e83 )

Dbal::query() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like