UrlMatcher::matchCollection() - Code Metrics - Inspection of "Rework architecture and complete README" - Tiriel/MyBlog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 84bb15...86ae46 )

by Benjamin

created 2018-05-24 12:14 UTC

UrlMatcher::matchCollection() A

↳ Parent: UrlMatcher

Complexity

Conditions	3
Paths	3

Size

Total Lines	13
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	10
nc	3
nop	1
dl	0
loc	13
ccs	9
cts	9
cp	1
crap	3
rs	9.4285
c	0
b	0
f	0

<?php

namespace Lib\Routing;

class UrlMatcher
{
    /**
     * @var RouteCollection
     */
    private $collection;

    public function __construct(RouteCollection $collection)
    {
        $this->collection = $collection;
    }

    public function match($path)
    {
        if ($match = $this->matchCollection($path)) {
            return $match;
        }
        return ['controller' => 'Default', 'action' => 'notFound', 'params' => []];
    }

    public function matchCollection($path)
    {
        foreach ($this->collection->all() as $route) {
            $regex = $this->createRegex($route);

            if (preg_match('#^'.$regex.'$#', $path, $matches)) {
                $params = array_filter($matches, function ($key) {
                    return !is_int($key);
                }, ARRAY_FILTER_USE_KEY);
                return [
                    'controller' => $route->getDefault('controller'),
                    'action'     => $route->getDefault('action'),
                    'params'     => $params
                ];
            }
        }
    }

    private function createRegex(RouteDefinition $route): string
    {
        $regex = $route->getPathRegex();
        $reqs  = $route->getRequirements();
        $regex = preg_replace_callback(
            '/{(\w+)}/',
            function ($matches) use ($reqs) {
                $req = $reqs[$matches[1]] ?? '.+';
                return "(?<{$matches[1]}>{$req})";
            },
            $regex
        );

        return $regex;
    }
}


1		<?php
2
3		namespace Lib\Routing;
4
5		class UrlMatcher
6		{
7		/**
8		* @var RouteCollection
9		*/
10		private $collection;
11
12	5	public function __construct(RouteCollection $collection)
13		{
14	5	$this->collection = $collection;
15	5	}
16
17	3	public function match($path)
18		{
19	3	if ($match = $this->matchCollection($path)) {
20	1	return $match;
21		}
22	2	return ['controller' => 'Default', 'action' => 'notFound', 'params' => []];
23		}
24
25	5	public function matchCollection($path)
26		{
27	5	foreach ($this->collection->all() as $route) {
28	5	$regex = $this->createRegex($route);
29
30	5	if (preg_match('#^'.$regex.'$#', $path, $matches)) {
31		$params = array_filter($matches, function ($key) {
32	2	return !is_int($key);
33	2	}, ARRAY_FILTER_USE_KEY);
34		return [
35	2	'controller' => $route->getDefault('controller'),
36	2	'action' => $route->getDefault('action'),
37	5	'params' => $params
38		];
39		}
40		}
41	3	}
42
43	5	private function createRegex(RouteDefinition $route): string
44		{
45	5	$regex = $route->getPathRegex();
46	5	$reqs = $route->getRequirements();
47	5	$regex = preg_replace_callback(
48	5	'/{(\w+)}/',
49		function ($matches) use ($reqs) {
50	4	$req = $reqs[$matches[1]] ?? '.+';
51	4	return "(?<{$matches[1]}>{$req})";
52	5	},
53	5	$regex
54		);
55
56	5	return $regex;
57		}
58		}
59

Tiriel / MyBlog

GitHub Access Token became invalid

Push — master ( 84bb15...86ae46 )

UrlMatcher::matchCollection() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like