Inspection of "Add the CHANGELOG.md" - Tiqr/tiqr-server-libphp - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — develop ( c83d6c...a27d56 )

by Michiel

created 2022-04-20 07:17 UTC

Status

Indentation +96 added lines, -96 removed lines patch added patch discarded remove patch

@@ -1,102 +1,102 @@
 block discarded – undo
 <?php
 class Tiqr_AutoLoader {
 
-	protected static $instance;
-
-	protected $tiqrPath;
-	protected $qrcodePath;
-	protected $zendPath;
-
-	protected function __construct($options) {
-		if ($options !== NULL) {
-			$this->setOptions($options);
-		}
-		spl_autoload_register(array(__CLASS__, 'autoload'));
-	}
-
-	public static function getInstance($options = NULL) {
-		if (null === self::$instance) {
-			self::$instance = new self($options);
-		}
-
-		return self::$instance;
-	}
-
-	public static function autoload($className) {
-		if($className === NULL) {
-			return;
-		}
-
-		$self = self::getInstance();
-
-		$substr5 = substr($className, 0, 5);
-
-		if ($substr5 === 'Tiqr_' || $substr5 === 'OATH_') {
-			$file = $self->tiqrPath . DIRECTORY_SEPARATOR . str_replace('_', DIRECTORY_SEPARATOR, $className) . '.php';
-		} elseif ($className === 'QRcode') {
-			$file = $self->qrcodePath . DIRECTORY_SEPARATOR . 'qrlib.php';
-		} elseif ($substr5 === 'Zend_') {
-			$file = $self->zendPath . DIRECTORY_SEPARATOR . str_replace('_', DIRECTORY_SEPARATOR, $className) . '.php';
+    protected static $instance;
+
+    protected $tiqrPath;
+    protected $qrcodePath;
+    protected $zendPath;
+
+    protected function __construct($options) {
+        if ($options !== NULL) {
+            $this->setOptions($options);
+        }
+        spl_autoload_register(array(__CLASS__, 'autoload'));
+    }
+
+    public static function getInstance($options = NULL) {
+        if (null === self::$instance) {
+            self::$instance = new self($options);
+        }
+
+        return self::$instance;
+    }
+
+    public static function autoload($className) {
+        if($className === NULL) {
+            return;
+        }
+
+        $self = self::getInstance();
+
+        $substr5 = substr($className, 0, 5);
+
+        if ($substr5 === 'Tiqr_' || $substr5 === 'OATH_') {
+            $file = $self->tiqrPath . DIRECTORY_SEPARATOR . str_replace('_', DIRECTORY_SEPARATOR, $className) . '.php';
+        } elseif ($className === 'QRcode') {
+            $file = $self->qrcodePath . DIRECTORY_SEPARATOR . 'qrlib.php';
+        } elseif ($substr5 === 'Zend_') {
+            $file = $self->zendPath . DIRECTORY_SEPARATOR . str_replace('_', DIRECTORY_SEPARATOR, $className) . '.php';
         } elseif ($className === 'ReadWriteException') {
             $file = $self->tiqrPath . DIRECTORY_SEPARATOR . 'Tiqr/Exception/ReadWriteException.php';
-		} else {
-			return;
-		}
-
-		if (file_exists($file)) {
-			require_once($file);
-		}
-	}
-
-	public function setOptions($options) {
-		if (isset($options["tiqr.path"])) {
-			$tiqr_dir = $options["tiqr.path"];
-			$tiqr_path = realpath($tiqr_dir);
-		} else {
-			$tiqr_dir = dirname(__FILE__);
-			$tiqr_path = $tiqr_dir;
-		}
-		if (is_dir($tiqr_path)) {
-			$this->tiqrPath = $tiqr_path;
-		} else {
-			throw new Exception('Directory not found: ' . var_export($tiqr_dir, TRUE));
-		}
-
-		if (isset($options["phpqrcode.path"])) {
-			$qrcode_dir = $options["phpqrcode.path"];
-			$qrcode_path = realpath($qrcode_dir);
-		} else {
-			$qrcode_dir = dirname(dirname(dirname(__FILE__))) . '/phpqrcode';
-			$qrcode_path = $qrcode_dir;
-		}
-
-		if (is_dir($qrcode_path)) {
-			$this->qrcodePath = $qrcode_path;
-		} else {
-			throw new Exception('Directory not found: ' . var_export($qrcode_dir, TRUE));
-		}
-
-		if (isset($options["zend.path"])) {
-			$zend_dir = $options["zend.path"];
-			$zend_path = realpath($zend_dir);
-		} else {
-			$zend_dir = dirname(dirname(dirname(__FILE__))) . "/zend";
-			$zend_path = $zend_dir;
-		}
-		if (is_dir($zend_path)) {
-			$this->zendPath = $zend_path;
-		} else {
-			throw new Exception('Directory not found: ' . var_export($zend_dir, TRUE));
-		}
-	}
-
-
-	public function setIncludePath() {
-		set_include_path(implode(PATH_SEPARATOR, array(
-			$this->tiqrPath,
-			$this->zendPath,
-			$this->qrcodePath,
-			get_include_path(),
-		)));
-	}
+        } else {
+            return;
+        }
+
+        if (file_exists($file)) {
+            require_once($file);
+        }
+    }
+
+    public function setOptions($options) {
+        if (isset($options["tiqr.path"])) {
+            $tiqr_dir = $options["tiqr.path"];
+            $tiqr_path = realpath($tiqr_dir);
+        } else {
+            $tiqr_dir = dirname(__FILE__);
+            $tiqr_path = $tiqr_dir;
+        }
+        if (is_dir($tiqr_path)) {
+            $this->tiqrPath = $tiqr_path;
+        } else {
+            throw new Exception('Directory not found: ' . var_export($tiqr_dir, TRUE));
+        }
+
+        if (isset($options["phpqrcode.path"])) {
+            $qrcode_dir = $options["phpqrcode.path"];
+            $qrcode_path = realpath($qrcode_dir);
+        } else {
+            $qrcode_dir = dirname(dirname(dirname(__FILE__))) . '/phpqrcode';
+            $qrcode_path = $qrcode_dir;
+        }
+
+        if (is_dir($qrcode_path)) {
+            $this->qrcodePath = $qrcode_path;
+        } else {
+            throw new Exception('Directory not found: ' . var_export($qrcode_dir, TRUE));
+        }
+
+        if (isset($options["zend.path"])) {
+            $zend_dir = $options["zend.path"];
+            $zend_path = realpath($zend_dir);
+        } else {
+            $zend_dir = dirname(dirname(dirname(__FILE__))) . "/zend";
+            $zend_path = $zend_dir;
+        }
+        if (is_dir($zend_path)) {
+            $this->zendPath = $zend_path;
+        } else {
+            throw new Exception('Directory not found: ' . var_export($zend_dir, TRUE));
+        }
+    }
+
+
+    public function setIncludePath() {
+        set_include_path(implode(PATH_SEPARATOR, array(
+            $this->tiqrPath,
+            $this->zendPath,
+            $this->qrcodePath,
+            get_include_path(),
+        )));
+    }
 }

Please login to merge, or discard this patch.

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -23,7 +23,7 @@  discard block
 block discarded – undo
 	}
 
 	public static function autoload($className) {
-		if($className === NULL) {
+		if ($className === NULL) {
 			return;
 		}
 
@@ -32,13 +32,13 @@  discard block
 block discarded – undo
 		$substr5 = substr($className, 0, 5);
 
 		if ($substr5 === 'Tiqr_' || $substr5 === 'OATH_') {
-			$file = $self->tiqrPath . DIRECTORY_SEPARATOR . str_replace('_', DIRECTORY_SEPARATOR, $className) . '.php';
+			$file = $self->tiqrPath.DIRECTORY_SEPARATOR.str_replace('_', DIRECTORY_SEPARATOR, $className).'.php';
 		} elseif ($className === 'QRcode') {
-			$file = $self->qrcodePath . DIRECTORY_SEPARATOR . 'qrlib.php';
+			$file = $self->qrcodePath.DIRECTORY_SEPARATOR.'qrlib.php';
 		} elseif ($substr5 === 'Zend_') {
-			$file = $self->zendPath . DIRECTORY_SEPARATOR . str_replace('_', DIRECTORY_SEPARATOR, $className) . '.php';
+			$file = $self->zendPath.DIRECTORY_SEPARATOR.str_replace('_', DIRECTORY_SEPARATOR, $className).'.php';
         } elseif ($className === 'ReadWriteException') {
-            $file = $self->tiqrPath . DIRECTORY_SEPARATOR . 'Tiqr/Exception/ReadWriteException.php';
+            $file = $self->tiqrPath.DIRECTORY_SEPARATOR.'Tiqr/Exception/ReadWriteException.php';
 		} else {
 			return;
 		}
@@ -59,34 +59,34 @@  discard block
 block discarded – undo
 		if (is_dir($tiqr_path)) {
 			$this->tiqrPath = $tiqr_path;
 		} else {
-			throw new Exception('Directory not found: ' . var_export($tiqr_dir, TRUE));
+			throw new Exception('Directory not found: '.var_export($tiqr_dir, TRUE));
 		}
 
 		if (isset($options["phpqrcode.path"])) {
 			$qrcode_dir = $options["phpqrcode.path"];
 			$qrcode_path = realpath($qrcode_dir);
 		} else {
-			$qrcode_dir = dirname(dirname(dirname(__FILE__))) . '/phpqrcode';
+			$qrcode_dir = dirname(dirname(dirname(__FILE__))).'/phpqrcode';
 			$qrcode_path = $qrcode_dir;
 		}
 
 		if (is_dir($qrcode_path)) {
 			$this->qrcodePath = $qrcode_path;
 		} else {
-			throw new Exception('Directory not found: ' . var_export($qrcode_dir, TRUE));
+			throw new Exception('Directory not found: '.var_export($qrcode_dir, TRUE));
 		}
 
 		if (isset($options["zend.path"])) {
 			$zend_dir = $options["zend.path"];
 			$zend_path = realpath($zend_dir);
 		} else {
-			$zend_dir = dirname(dirname(dirname(__FILE__))) . "/zend";
+			$zend_dir = dirname(dirname(dirname(__FILE__)))."/zend";
 			$zend_path = $zend_dir;
 		}
 		if (is_dir($zend_path)) {
 			$this->zendPath = $zend_path;
 		} else {
-			throw new Exception('Directory not found: ' . var_export($zend_dir, TRUE));
+			throw new Exception('Directory not found: '.var_export($zend_dir, TRUE));
 		}
 	}
 

Please login to merge, or discard this patch.

		@@ -23,7 +23,7 @@ discard block
		block discarded – undo
23	23	}
24	24
25	25	public static function autoload($className) {
26		- if($className === NULL) {
	26	+ if ($className === NULL) {
27	27	return;
28	28	}
29	29
		@@ -32,13 +32,13 @@ discard block
		block discarded – undo
32	32	$substr5 = substr($className, 0, 5);
33	33
34	34	if ($substr5 === 'Tiqr_' \|\| $substr5 === 'OATH_') {
35		- $file = $self->tiqrPath . DIRECTORY_SEPARATOR . str_replace('_', DIRECTORY_SEPARATOR, $className) . '.php';
	35	+ $file = $self->tiqrPath.DIRECTORY_SEPARATOR.str_replace('_', DIRECTORY_SEPARATOR, $className).'.php';
36	36	} elseif ($className === 'QRcode') {
37		- $file = $self->qrcodePath . DIRECTORY_SEPARATOR . 'qrlib.php';
	37	+ $file = $self->qrcodePath.DIRECTORY_SEPARATOR.'qrlib.php';
38	38	} elseif ($substr5 === 'Zend_') {
39		- $file = $self->zendPath . DIRECTORY_SEPARATOR . str_replace('_', DIRECTORY_SEPARATOR, $className) . '.php';
	39	+ $file = $self->zendPath.DIRECTORY_SEPARATOR.str_replace('_', DIRECTORY_SEPARATOR, $className).'.php';
40	40	} elseif ($className === 'ReadWriteException') {
41		- $file = $self->tiqrPath . DIRECTORY_SEPARATOR . 'Tiqr/Exception/ReadWriteException.php';
	41	+ $file = $self->tiqrPath.DIRECTORY_SEPARATOR.'Tiqr/Exception/ReadWriteException.php';
42	42	} else {
43	43	return;
44	44	}
		@@ -59,34 +59,34 @@ discard block
		block discarded – undo
59	59	if (is_dir($tiqr_path)) {
60	60	$this->tiqrPath = $tiqr_path;
61	61	} else {
62		- throw new Exception('Directory not found: ' . var_export($tiqr_dir, TRUE));
	62	+ throw new Exception('Directory not found: '.var_export($tiqr_dir, TRUE));
63	63	}
64	64
65	65	if (isset($options["phpqrcode.path"])) {
66	66	$qrcode_dir = $options["phpqrcode.path"];
67	67	$qrcode_path = realpath($qrcode_dir);
68	68	} else {
69		- $qrcode_dir = dirname(dirname(dirname(__FILE__))) . '/phpqrcode';
	69	+ $qrcode_dir = dirname(dirname(dirname(__FILE__))).'/phpqrcode';
70	70	$qrcode_path = $qrcode_dir;
71	71	}
72	72
73	73	if (is_dir($qrcode_path)) {
74	74	$this->qrcodePath = $qrcode_path;
75	75	} else {
76		- throw new Exception('Directory not found: ' . var_export($qrcode_dir, TRUE));
	76	+ throw new Exception('Directory not found: '.var_export($qrcode_dir, TRUE));
77	77	}
78	78
79	79	if (isset($options["zend.path"])) {
80	80	$zend_dir = $options["zend.path"];
81	81	$zend_path = realpath($zend_dir);
82	82	} else {
83		- $zend_dir = dirname(dirname(dirname(__FILE__))) . "/zend";
	83	+ $zend_dir = dirname(dirname(dirname(__FILE__)))."/zend";
84	84	$zend_path = $zend_dir;
85	85	}
86	86	if (is_dir($zend_path)) {
87	87	$this->zendPath = $zend_path;
88	88	} else {
89		- throw new Exception('Directory not found: ' . var_export($zend_dir, TRUE));
	89	+ throw new Exception('Directory not found: '.var_export($zend_dir, TRUE));
90	90	}
91	91	}
92	92

		@@ -1,102 +1,102 @@
		block discarded – undo
1	1	<?php
2	2	class Tiqr_AutoLoader {
3	3
4		- protected static $instance;
5		-
6		- protected $tiqrPath;
7		- protected $qrcodePath;
8		- protected $zendPath;
9		-
10		- protected function __construct($options) {
11		- if ($options !== NULL) {
12		- $this->setOptions($options);
13		- }
14		- spl_autoload_register(array(__CLASS__, 'autoload'));
15		- }
16		-
17		- public static function getInstance($options = NULL) {
18		- if (null === self::$instance) {
19		- self::$instance = new self($options);
20		- }
21		-
22		- return self::$instance;
23		- }
24		-
25		- public static function autoload($className) {
26		- if($className === NULL) {
27		- return;
28		- }
29		-
30		- $self = self::getInstance();
31		-
32		- $substr5 = substr($className, 0, 5);
33		-
34		- if ($substr5 === 'Tiqr_' \|\| $substr5 === 'OATH_') {
35		- $file = $self->tiqrPath . DIRECTORY_SEPARATOR . str_replace('_', DIRECTORY_SEPARATOR, $className) . '.php';
36		- } elseif ($className === 'QRcode') {
37		- $file = $self->qrcodePath . DIRECTORY_SEPARATOR . 'qrlib.php';
38		- } elseif ($substr5 === 'Zend_') {
39		- $file = $self->zendPath . DIRECTORY_SEPARATOR . str_replace('_', DIRECTORY_SEPARATOR, $className) . '.php';
	4	+ protected static $instance;
	5	+
	6	+ protected $tiqrPath;
	7	+ protected $qrcodePath;
	8	+ protected $zendPath;
	9	+
	10	+ protected function __construct($options) {
	11	+ if ($options !== NULL) {
	12	+ $this->setOptions($options);
	13	+ }
	14	+ spl_autoload_register(array(__CLASS__, 'autoload'));
	15	+ }
	16	+
	17	+ public static function getInstance($options = NULL) {
	18	+ if (null === self::$instance) {
	19	+ self::$instance = new self($options);
	20	+ }
	21	+
	22	+ return self::$instance;
	23	+ }
	24	+
	25	+ public static function autoload($className) {
	26	+ if($className === NULL) {
	27	+ return;
	28	+ }
	29	+
	30	+ $self = self::getInstance();
	31	+
	32	+ $substr5 = substr($className, 0, 5);
	33	+
	34	+ if ($substr5 === 'Tiqr_' \|\| $substr5 === 'OATH_') {
	35	+ $file = $self->tiqrPath . DIRECTORY_SEPARATOR . str_replace('_', DIRECTORY_SEPARATOR, $className) . '.php';
	36	+ } elseif ($className === 'QRcode') {
	37	+ $file = $self->qrcodePath . DIRECTORY_SEPARATOR . 'qrlib.php';
	38	+ } elseif ($substr5 === 'Zend_') {
	39	+ $file = $self->zendPath . DIRECTORY_SEPARATOR . str_replace('_', DIRECTORY_SEPARATOR, $className) . '.php';
40	40	} elseif ($className === 'ReadWriteException') {
41	41	$file = $self->tiqrPath . DIRECTORY_SEPARATOR . 'Tiqr/Exception/ReadWriteException.php';
42		- } else {
43		- return;
44		- }
45		-
46		- if (file_exists($file)) {
47		- require_once($file);
48		- }
49		- }
50		-
51		- public function setOptions($options) {
52		- if (isset($options["tiqr.path"])) {
53		- $tiqr_dir = $options["tiqr.path"];
54		- $tiqr_path = realpath($tiqr_dir);
55		- } else {
56		- $tiqr_dir = dirname(__FILE__);
57		- $tiqr_path = $tiqr_dir;
58		- }
59		- if (is_dir($tiqr_path)) {
60		- $this->tiqrPath = $tiqr_path;
61		- } else {
62		- throw new Exception('Directory not found: ' . var_export($tiqr_dir, TRUE));
63		- }
64		-
65		- if (isset($options["phpqrcode.path"])) {
66		- $qrcode_dir = $options["phpqrcode.path"];
67		- $qrcode_path = realpath($qrcode_dir);
68		- } else {
69		- $qrcode_dir = dirname(dirname(dirname(__FILE__))) . '/phpqrcode';
70		- $qrcode_path = $qrcode_dir;
71		- }
72		-
73		- if (is_dir($qrcode_path)) {
74		- $this->qrcodePath = $qrcode_path;
75		- } else {
76		- throw new Exception('Directory not found: ' . var_export($qrcode_dir, TRUE));
77		- }
78		-
79		- if (isset($options["zend.path"])) {
80		- $zend_dir = $options["zend.path"];
81		- $zend_path = realpath($zend_dir);
82		- } else {
83		- $zend_dir = dirname(dirname(dirname(__FILE__))) . "/zend";
84		- $zend_path = $zend_dir;
85		- }
86		- if (is_dir($zend_path)) {
87		- $this->zendPath = $zend_path;
88		- } else {
89		- throw new Exception('Directory not found: ' . var_export($zend_dir, TRUE));
90		- }
91		- }
92		-
93		-
94		- public function setIncludePath() {
95		- set_include_path(implode(PATH_SEPARATOR, array(
96		- $this->tiqrPath,
97		- $this->zendPath,
98		- $this->qrcodePath,
99		- get_include_path(),
100		- )));
101		- }
	42	+ } else {
	43	+ return;
	44	+ }
	45	+
	46	+ if (file_exists($file)) {
	47	+ require_once($file);
	48	+ }
	49	+ }
	50	+
	51	+ public function setOptions($options) {
	52	+ if (isset($options["tiqr.path"])) {
	53	+ $tiqr_dir = $options["tiqr.path"];
	54	+ $tiqr_path = realpath($tiqr_dir);
	55	+ } else {
	56	+ $tiqr_dir = dirname(__FILE__);
	57	+ $tiqr_path = $tiqr_dir;
	58	+ }
	59	+ if (is_dir($tiqr_path)) {
	60	+ $this->tiqrPath = $tiqr_path;
	61	+ } else {
	62	+ throw new Exception('Directory not found: ' . var_export($tiqr_dir, TRUE));
	63	+ }
	64	+
	65	+ if (isset($options["phpqrcode.path"])) {
	66	+ $qrcode_dir = $options["phpqrcode.path"];
	67	+ $qrcode_path = realpath($qrcode_dir);
	68	+ } else {
	69	+ $qrcode_dir = dirname(dirname(dirname(__FILE__))) . '/phpqrcode';
	70	+ $qrcode_path = $qrcode_dir;
	71	+ }
	72	+
	73	+ if (is_dir($qrcode_path)) {
	74	+ $this->qrcodePath = $qrcode_path;
	75	+ } else {
	76	+ throw new Exception('Directory not found: ' . var_export($qrcode_dir, TRUE));
	77	+ }
	78	+
	79	+ if (isset($options["zend.path"])) {
	80	+ $zend_dir = $options["zend.path"];
	81	+ $zend_path = realpath($zend_dir);
	82	+ } else {
	83	+ $zend_dir = dirname(dirname(dirname(__FILE__))) . "/zend";
	84	+ $zend_path = $zend_dir;
	85	+ }
	86	+ if (is_dir($zend_path)) {
	87	+ $this->zendPath = $zend_path;
	88	+ } else {
	89	+ throw new Exception('Directory not found: ' . var_export($zend_dir, TRUE));
	90	+ }
	91	+ }
	92	+
	93	+
	94	+ public function setIncludePath() {
	95	+ set_include_path(implode(PATH_SEPARATOR, array(
	96	+ $this->tiqrPath,
	97	+ $this->zendPath,
	98	+ $this->qrcodePath,
	99	+ get_include_path(),
	100	+ )));
	101	+ }
102	102	}

Tiqr / tiqr-server-libphp

Push — develop ( c83d6c...a27d56 )

Status

Category

Indentation +96 added lines, -96 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch