Passed
Pull Request — develop (#31)
by Pieter van der
06:27 queued 10s
created
library/tiqr/Tiqr/UserStorage/GenericStore.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
     public function createUser($userId, $displayName) 
44 44
     {
45 45
         $user = array("userId"=>$userId,
46
-                      "displayName"=>$displayName);
46
+                        "displayName"=>$displayName);
47 47
         return $this->_saveUser($userId, $user);
48 48
     }
49 49
 
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
     {
78 78
         if ($data = $this->_loadUser($userId)) {
79 79
             if (isset($data["notificationType"])) {
80
-               return $data["notificationType"];
80
+                return $data["notificationType"];
81 81
             }
82 82
         }
83 83
         return NULL;
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
     {
103 103
         if ($data = $this->_loadUser($userId)) {
104 104
             if (isset($data["notificationAddress"])) {
105
-               return $data["notificationAddress"];
105
+                return $data["notificationAddress"];
106 106
             }
107 107
         }
108 108
         return NULL;
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
     public function userExists($userId)
55 55
     {
56 56
         $user = $this->_loadUser($userId, FALSE);
57
-        return (is_array($user)||is_object($user)); 
57
+        return (is_array($user) || is_object($user)); 
58 58
     }
59 59
 
60 60
     /**
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
         if ($data = $this->_loadUser($userId)) {
154 154
             $timestamp = $this->getTemporaryBlockTimestamp($userId);
155 155
             // if not blocked or block is expired, return false
156
-            if (!isset($data["blocked"]) || $data["blocked"]==false || (false !== $timestamp && false != $duration && (strtotime($timestamp) + $duration * 60) < time())) {
156
+            if (!isset($data["blocked"]) || $data["blocked"] == false || (false !== $timestamp && false != $duration && (strtotime($timestamp) + $duration * 60) < time())) {
157 157
                 return false;
158 158
             }
159 159
         }
Please login to merge, or discard this patch.
library/tiqr/Tiqr/UserStorage/Encryption.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@
 block discarded – undo
38 38
      *
39 39
      * @return Tiqr_UserStorage_Encryption_Interface
40 40
      */
41
-    public static function getEncryption($type="dummy", $options=array())
41
+    public static function getEncryption($type = "dummy", $options = array())
42 42
     {
43 43
         switch ($type) {
44 44
             case "dummy":
Please login to merge, or discard this patch.
library/tiqr/Tiqr/UserStorage/File.php 3 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -94,8 +94,8 @@
 block discarded – undo
94 94
      */
95 95
     public function getPath()
96 96
     {
97
-         if (substr($this->_path, -1)!="/") return $this->_path."/";
98
-         return $this->_path;
97
+            if (substr($this->_path, -1)!="/") return $this->_path."/";
98
+            return $this->_path;
99 99
     }
100 100
     
101 101
 }
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 
68 68
         if ($data === NULL) {
69 69
             if ($failIfNotFound) {
70
-                throw new Exception('Error loading data for user: ' . var_export($userId, TRUE));
70
+                throw new Exception('Error loading data for user: '.var_export($userId, TRUE));
71 71
             } else {
72 72
                 return false;
73 73
             }
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
      */
95 95
     public function getPath()
96 96
     {
97
-         if (substr($this->_path, -1)!="/") return $this->_path."/";
97
+         if (substr($this->_path, -1) != "/") return $this->_path."/";
98 98
          return $this->_path;
99 99
     }
100 100
     
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,9 @@
 block discarded – undo
94 94
      */
95 95
     public function getPath()
96 96
     {
97
-         if (substr($this->_path, -1)!="/") return $this->_path."/";
97
+         if (substr($this->_path, -1)!="/") {
98
+             return $this->_path."/";
99
+         }
98 100
          return $this->_path;
99 101
     }
100 102
     
Please login to merge, or discard this patch.
library/tiqr/Tiqr/OcraService.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
      *
37 37
      * @return Tiqr_OcraService_Interface
38 38
      */
39
-    public static function getOcraService($type="tiqr", $options=array())
39
+    public static function getOcraService($type = "tiqr", $options = array())
40 40
     {
41 41
         switch ($type) {
42 42
             case "tiqr":
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
                 if (!isset($type)) {
52 52
                     throw new Exception('Class name not set');
53 53
                 } elseif (!class_exists($type)) {
54
-                    throw new Exception('Class not found: ' . var_export($type, TRUE));
54
+                    throw new Exception('Class not found: '.var_export($type, TRUE));
55 55
                 }
56 56
                 $instance = new $type($options);
57 57
         }
Please login to merge, or discard this patch.
library/tiqr/Tiqr/DeviceStorage/Abstract.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
      * the Tiqr_DeviceStorage factory will call this for you.
54 54
      * @param array $options The options for the s
55 55
      */
56
-    public function __construct($options=array())
56
+    public function __construct($options = array())
57 57
     {
58 58
         $this->_options = $options;        
59 59
     }
Please login to merge, or discard this patch.
library/tiqr/Tiqr/DeviceStorage/TokenExchange.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -41,11 +41,11 @@
 block discarded – undo
41 41
     {
42 42
         $url = $this->_options["url"]."?appId=".$this->_options["appid"];
43 43
         
44
-        $url.= "&notificationToken=".$notificationToken;
44
+        $url .= "&notificationToken=".$notificationToken;
45 45
         
46 46
         $output = file_get_contents($url);
47
-        if (stripos($output, "not found")!==false) return false;
48
-        if (stripos($output, "error")!==false) return false;
47
+        if (stripos($output, "not found") !== false) return false;
48
+        if (stripos($output, "error") !== false) return false;
49 49
         return trim($output);
50 50
     }
51 51
 }
52 52
\ No newline at end of file
Please login to merge, or discard this patch.
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -44,8 +44,12 @@
 block discarded – undo
44 44
         $url.= "&notificationToken=".$notificationToken;
45 45
         
46 46
         $output = file_get_contents($url);
47
-        if (stripos($output, "not found")!==false) return false;
48
-        if (stripos($output, "error")!==false) return false;
47
+        if (stripos($output, "not found")!==false) {
48
+            return false;
49
+        }
50
+        if (stripos($output, "error")!==false) {
51
+            return false;
52
+        }
49 53
         return trim($output);
50 54
     }
51 55
 }
52 56
\ No newline at end of file
Please login to merge, or discard this patch.
library/tiqr/Tiqr/DeviceStorage.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
      *                       config options per type.
43 43
      * @throws Exception An exception if an unknown storage is requested.
44 44
      */
45
-    public static function getStorage($type="dummy", $options=array())
45
+    public static function getStorage($type = "dummy", $options = array())
46 46
     {
47 47
         switch ($type) {
48 48
             case "dummy":
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
             default:
58 58
                 $instance = NULL;
59 59
         }
60
-        if ($instance!=NULL) {
60
+        if ($instance != NULL) {
61 61
             $instance->init();
62 62
             return $instance;
63 63
         }
Please login to merge, or discard this patch.
library/tiqr/Tiqr/UserSecretStorage.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
      *
37 37
      * @return Tiqr_UserSecretStorage_Interface
38 38
      */
39
-    public static function getSecretStorage($type="file", $options=array())
39
+    public static function getSecretStorage($type = "file", $options = array())
40 40
     {
41 41
         switch ($type) {
42 42
             case "file":
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
                 if (!isset($type)) {
60 60
                     throw new Exception('Class name not set');
61 61
                 } elseif (!class_exists($type)) {
62
-                    throw new Exception('Class not found: ' . var_export($type, TRUE));
62
+                    throw new Exception('Class not found: '.var_export($type, TRUE));
63 63
                 }
64 64
                 $instance = new $type($options);
65 65
         }
Please login to merge, or discard this patch.
library/tiqr/Tiqr/OATH/OCRAWrapper_v1.php 3 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -90,9 +90,9 @@
 block discarded – undo
90 90
      */
91 91
     public function verifyResponse($response, $secret, $challenge, $sessionKey)
92 92
     {
93
-         $expected = $this->calculateResponse($secret, $challenge, $sessionKey);
93
+            $expected = $this->calculateResponse($secret, $challenge, $sessionKey);
94 94
 
95
-         return ($expected == $response);
95
+            return ($expected == $response);
96 96
     }
97 97
 
98 98
     /**
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -107,7 +107,9 @@
 block discarded – undo
107 107
     {
108 108
         // find the :QN10, -QN10, QH10 etc. bit
109 109
         $pos = stripos($ocraSuite, ":q");
110
-        if ($pos===false) $pos = stripos($ocraSuite, "-q");
110
+        if ($pos===false) {
111
+            $pos = stripos($ocraSuite, "-q");
112
+        }
111 113
         if ($pos===false) {
112 114
             // No challenge config specified. Since we only support challenge based OCRA, we fallback to default 10 digit hexadecimal.
113 115
             return array("format"=>"H", "length"=>10);
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
      */
64 64
     public function generateSessionKey() 
65 65
     {
66
-        return bin2hex( Tiqr_Random::randomBytes(self::SESSIONKEY_SIZE) );
66
+        return bin2hex(Tiqr_Random::randomBytes(self::SESSIONKEY_SIZE));
67 67
     }
68 68
     
69 69
     /**
@@ -107,19 +107,19 @@  discard block
 block discarded – undo
107 107
     {
108 108
         // find the :QN10, -QN10, QH10 etc. bit
109 109
         $pos = stripos($ocraSuite, ":q");
110
-        if ($pos===false) $pos = stripos($ocraSuite, "-q");
111
-        if ($pos===false) {
110
+        if ($pos === false) $pos = stripos($ocraSuite, "-q");
111
+        if ($pos === false) {
112 112
             // No challenge config specified. Since we only support challenge based OCRA, we fallback to default 10 digit hexadecimal.
113 113
             return array("format"=>"H", "length"=>10);
114 114
         }
115
-        $format = substr($ocraSuite, $pos+2, 1);
115
+        $format = substr($ocraSuite, $pos + 2, 1);
116 116
         if (!in_array($format, array("N", "A", "H"))) {
117 117
             $format = "H";
118 118
         }
119 119
         
120
-        $length = (int)substr($ocraSuite, $pos+3, 2);
120
+        $length = (int) substr($ocraSuite, $pos + 3, 2);
121 121
                 
122
-        if ($length<=0) {
122
+        if ($length <= 0) {
123 123
             $length = 10;
124 124
         }
125 125
         
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
      */
191 191
     protected function _calculateResponse($ocraSuite, $secret, $challenge, $sessionKey)
192 192
     {       
193
-        if (strpos(strtolower($ocraSuite), "qn")!==false) {
193
+        if (strpos(strtolower($ocraSuite), "qn") !== false) {
194 194
             
195 195
             // challenge is decimal, but generateOcra always wants it in hex.
196 196
             $challenge = dechex($challenge);
Please login to merge, or discard this patch.