Tiqr /
tiqr-server-libphp
| Conditions | 9 |
| Paths | 8 |
| Total Lines | 62 |
| Code Lines | 40 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 90 |
| Changes | 9 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.
There are several approaches to avoid long parameter lists:
| 1 | <?php |
||
| 96 | private function _sendFirebase(string $deviceToken, string $alert, string $challenge, string $projectId, string $credentialsFile, bool $cacheTokens, string $tokenCacheDir, bool $retry=false) |
||
| 97 | { |
||
| 98 | $apiurl = sprintf('https://fcm.googleapis.com/v1/projects/%s/messages:send',$projectId); |
||
| 99 | |||
| 100 | $fields = [ |
||
| 101 | 'message' => [ |
||
| 102 | 'token' => $deviceToken, |
||
| 103 | 'data' => [ |
||
| 104 | 'challenge' => $challenge, |
||
| 105 | 'text' => $alert, |
||
| 106 | ], |
||
| 107 | "android" => [ |
||
| 108 | "ttl" => "300s", |
||
| 109 | ], |
||
| 110 | ], |
||
| 111 | ]; |
||
| 112 | |||
| 113 | try { |
||
| 114 | $headers = array( |
||
| 115 | 'Authorization: Bearer ' . $this->getGoogleAccessToken($credentialsFile, $cacheTokens, $tokenCacheDir), |
||
| 116 | 'Content-Type: application/json', |
||
| 117 | ); |
||
| 118 | } catch (\Google\Exception $e) { |
||
| 119 | throw new Tiqr_Message_Exception_SendFailure(sprintf("Error getting Goosle access token : %s", $e->getMessage()), true); |
||
| 120 | } |
||
| 121 | |||
| 122 | $ch = curl_init(); |
||
| 123 | curl_setopt($ch, CURLOPT_URL, $apiurl); |
||
| 124 | curl_setopt($ch, CURLOPT_POST, true); |
||
| 125 | curl_setopt($ch, CURLOPT_HTTPHEADER, $headers); |
||
| 126 | curl_setopt($ch, CURLOPT_RETURNTRANSFER, true); |
||
| 127 | curl_setopt($ch, CURLOPT_POSTFIELDS, json_encode($fields)); |
||
| 128 | $result = curl_exec($ch); |
||
| 129 | $errors = curl_error($ch); |
||
| 130 | $statusCode = curl_getinfo($ch, CURLINFO_HTTP_CODE); |
||
| 131 | $remoteip = curl_getinfo($ch, CURLINFO_PRIMARY_IP); |
||
| 132 | curl_close($ch); |
||
| 133 | |||
| 134 | if ($result === false) { |
||
| 135 | throw new Tiqr_Message_Exception_SendFailure("Server unavailable", true); |
||
| 136 | } |
||
| 137 | |||
| 138 | if (!empty($errors)) { |
||
| 139 | throw new Tiqr_Message_Exception_SendFailure("Http error occurred: ". $errors, true); |
||
| 140 | } |
||
| 141 | |||
| 142 | // Wait and retry once in case of a 502 Bad Gateway error |
||
| 143 | if ($statusCode === 502 && !($retry)) { |
||
| 144 | sleep(2); |
||
| 145 | $this->_sendFirebase($deviceToken, $alert, $challenge, $projectId, $credentialsFile, $cacheTokens, $tokenCacheDir, true); |
||
| 146 | return; |
||
| 147 | } |
||
| 148 | |||
| 149 | if ($statusCode !== 200) { |
||
| 150 | throw new Tiqr_Message_Exception_SendFailure(sprintf('Invalid status code : %s. Server : %s. Response : "%s".', $statusCode, $remoteip, $result), true); |
||
| 151 | } |
||
| 152 | |||
| 153 | // handle errors, ignoring registration_id's |
||
| 154 | $response = json_decode($result, true); |
||
| 155 | foreach ($response as $k => $v) { |
||
| 156 | if ($k=="error") { |
||
| 157 | throw new Tiqr_Message_Exception_SendFailure(sprintf("Error in FCM response: %s", $result), true); |
||
| 158 | } |
||
| 162 |
Loading history...
This check looks for parameters that have been defined for a function or method, but which are not used in the method body.