Passed
Pull Request — develop (#43)
by Pieter van der
02:56
created
library/tiqr/Tiqr/OcraService/Tiqr.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-require_once __DIR__ . '/../OATH/OCRA.php';
3
+require_once __DIR__.'/../OATH/OCRA.php';
4 4
 
5 5
 /**
6 6
  * This file is part of the tiqr project.
Please login to merge, or discard this patch.
library/tiqr/Tiqr/UserStorage/Pdo.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -89,21 +89,21 @@  discard block
 block discarded – undo
89 89
      */
90 90
     private function _getStringValue(string $columnName, string $userId): string
91 91
     {
92
-        if ( !in_array($columnName, $this->_allowedStringColumns) ) {
92
+        if (!in_array($columnName, $this->_allowedStringColumns)) {
93 93
             throw new InvalidArgumentException('Unsupported column name');
94 94
         }
95 95
 
96 96
         try {
97
-            $sth = $this->handle->prepare('SELECT ' . $columnName . ' FROM ' . $this->tablename . ' WHERE userid = ?');
97
+            $sth = $this->handle->prepare('SELECT '.$columnName.' FROM '.$this->tablename.' WHERE userid = ?');
98 98
             $sth->execute(array($userId));
99
-            $res=$sth->fetchColumn();
99
+            $res = $sth->fetchColumn();
100 100
             if ($res === false) {
101 101
                 // No result
102 102
                 $this->logger->error(sprintf('No result getting "%s" for user "%s"', $columnName, $userId));
103 103
                 throw new RuntimeException('User not found');
104 104
             }
105 105
             if ($res === NULL) {
106
-                return '';  // Value unset
106
+                return ''; // Value unset
107 107
             }
108 108
             if (!is_string($res)) {
109 109
                 $this->logger->error(sprintf('Expected string type while getting "%s" for user "%s"', $columnName, $userId));
@@ -127,28 +127,28 @@  discard block
 block discarded – undo
127 127
      */
128 128
     private function _getIntValue(string $columnName, string $userId): int
129 129
     {
130
-        if ( !in_array($columnName, $this->_allowedIntColumns) ) {
130
+        if (!in_array($columnName, $this->_allowedIntColumns)) {
131 131
             throw new InvalidArgumentException('Unsupported column name');
132 132
         }
133 133
 
134 134
         try {
135
-            $sth = $this->handle->prepare('SELECT ' . $columnName . ' FROM ' . $this->tablename . ' WHERE userid = ?');
135
+            $sth = $this->handle->prepare('SELECT '.$columnName.' FROM '.$this->tablename.' WHERE userid = ?');
136 136
             $sth->execute(array($userId));
137
-            $res=$sth->fetchColumn();
137
+            $res = $sth->fetchColumn();
138 138
             if ($res === false) {
139 139
                 // No result
140 140
                 $this->logger->error(sprintf('No result getting "%s" for user "%s"', $columnName, $userId));
141 141
                 throw new RuntimeException('User not found');
142 142
             }
143 143
             if ($res === NULL) {
144
-                return 0;  // Value unset
144
+                return 0; // Value unset
145 145
             }
146 146
             // Return type for integers depends on the PDO driver, can be string
147 147
             if (!is_numeric($res)) {
148 148
                 $this->logger->error(sprintf('Expected int type while getting "%s" for user "%s"', $columnName, $userId));
149 149
                 throw new RuntimeException('Unexpected return type');
150 150
             }
151
-            return (int)$res;
151
+            return (int) $res;
152 152
         }
153 153
         catch (Exception $e) {
154 154
             $this->logger->error('PDO error getting user', array('exception' => $e, 'userId' => $userId, 'columnName'=>$columnName));
@@ -165,11 +165,11 @@  discard block
 block discarded – undo
165 165
      */
166 166
     private function _setStringValue(string $columnName, string $userId, string $value): void
167 167
     {
168
-        if ( !in_array($columnName, $this->_allowedStringColumns) ) {
168
+        if (!in_array($columnName, $this->_allowedStringColumns)) {
169 169
             throw new InvalidArgumentException('Unsupported column name');
170 170
         }
171 171
         try {
172
-            $sth = $this->handle->prepare('UPDATE ' . $this->tablename . ' SET ' . $columnName . ' = ? WHERE userid = ?');
172
+            $sth = $this->handle->prepare('UPDATE '.$this->tablename.' SET '.$columnName.' = ? WHERE userid = ?');
173 173
             $sth->execute(array($value, $userId));
174 174
             if ($sth->rowCount() == 0) {
175 175
                 // Required for mysql which only returns the number of rows that were actually updated
@@ -193,11 +193,11 @@  discard block
 block discarded – undo
193 193
      */
194 194
     private function _setIntValue(string $columnName, string $userId, int $value): void
195 195
     {
196
-        if ( !in_array($columnName, $this->_allowedIntColumns) ) {
196
+        if (!in_array($columnName, $this->_allowedIntColumns)) {
197 197
             throw new InvalidArgumentException('Unsupported column name');
198 198
         }
199 199
         try {
200
-            $sth = $this->handle->prepare('UPDATE ' . $this->tablename . ' SET ' . $columnName . ' = ? WHERE userid = ?');
200
+            $sth = $this->handle->prepare('UPDATE '.$this->tablename.' SET '.$columnName.' = ? WHERE userid = ?');
201 201
             $sth->execute(array($value, $userId));
202 202
             if ($sth->rowCount() == 0) {
203 203
                 // Required for mysql which only returns the number of rows that were actually updated
@@ -309,17 +309,17 @@  discard block
 block discarded – undo
309 309
     {
310 310
         // Check for blocked
311 311
         if ($this->_getIntValue('blocked', $userId) != 0) {
312
-            return true;   // Blocked
312
+            return true; // Blocked
313 313
         }
314 314
 
315 315
         if (0 == $tempBlockDuration) {
316
-            return false;   // No check for temporary block
316
+            return false; // No check for temporary block
317 317
         }
318 318
 
319 319
         // Check for temporary block
320 320
         $timestamp = $this->getTemporaryBlockTimestamp($userId);
321 321
         // if no temporary block timestamp is set or if the temporary block is expired, return false
322
-        if ( 0 == $timestamp || ($timestamp + $tempBlockDuration * 60) < time()) {
322
+        if (0 == $timestamp || ($timestamp + $tempBlockDuration * 60) < time()) {
323 323
             return false;
324 324
         }
325 325
         return true;
Please login to merge, or discard this patch.