UserSecretStorageTrait

Complexity

Total Complexity

2

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getSecret()	0	4	1
A	setSecret()	0	4	1

<?php

/**
 * Copyright 2022 SURF B.V.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

trait UserSecretStorageTrait
{
    private $encryption;

    /**
     * Get the user's secret
     * @param String $userId
     * @return String The user's secret
     */
    public function getSecret($userId)
    {
        $encryptedSecret = $this->getUserSecret($userId);

It seems like getUserSecret() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $this->encryption->decrypt($encryptedSecret);
    }

    /**
     * Store a secret for a user.
     * @param String $userId
     * @param String $secret
     */
    public function setSecret($userId, $secret)
    {
        $encryptedSecret = $this->encryption->encrypt($secret);
        $this->setUserSecret($userId, $encryptedSecret);

It seems like setUserSecret() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
}