Tiqr / tiqr-server-libphp

library/tiqr/Tiqr/OATH/OCRAWrapper_v1.php

Braces +3 added lines, -1 removed lines

@@ -107,7 +107,9 @@
     {
         // find the :QN10, -QN10, QH10 etc. bit
         $pos = stripos($ocraSuite, ":q");
-        if ($pos===false) $pos = stripos($ocraSuite, "-q");
+        if ($pos===false) {
+            $pos = stripos($ocraSuite, "-q");
+        }
         if ($pos===false) {
             // No challenge config specified. Since we only support challenge based OCRA, we fallback to default 10 digit hexadecimal.
             return array("format"=>"H", "length"=>10);

library/tiqr/Tiqr/OATH/OCRA_v1.php

Braces +24 added lines, -16 removed lines

@@ -101,12 +101,15 @@ 
         $sessionInformationLength = 0;
         $timeStampLength = 0;
 
-        if(stripos($ocraSuite, "sha1")!==false)
-            $crypto = "sha1";
-        if(stripos($ocraSuite, "sha256")!==false)
-            $crypto = "sha256";
-        if(stripos($ocraSuite, "sha512")!==false)
-            $crypto = "sha512";
+        if(stripos($ocraSuite, "sha1")!==false) {
+                    $crypto = "sha1";
+        }
+        if(stripos($ocraSuite, "sha256")!==false) {
+                    $crypto = "sha256";
+        }
+        if(stripos($ocraSuite, "sha512")!==false) {
+                    $crypto = "sha512";
+        }
 
         // How many digits should we return
         $oS = substr($ocraSuite, strpos($ocraSuite, ":")+1, strpos($ocraSuite, ":", strpos($ocraSuite, ":")+1) -strpos($ocraSuite, ":")-1);
@@ -116,31 +119,35 @@ 
         // Counter
         if(stripos($ocraSuite, ":c") !==false) {
             // Fix the length of the HEX string
-            while(strlen($counter) < 16)
-                $counter = "0" . $counter;
+            while(strlen($counter) < 16) {
+                            $counter = "0" . $counter;
+            }
             $counterLength=8;
         }
         // Question
         if(stripos($ocraSuite, ":q")!==false ||
                 stripos($ocraSuite, "-q")!==false) {
-            while(strlen($question) < 256)
-                $question = $question . "0";
+            while(strlen($question) < 256) {
+                            $question = $question . "0";
+            }
             $questionLength=128;
         }
 
         // Password
         if(stripos($ocraSuite, ":p")!==false ||
                 stripos($ocraSuite, "-p") !==false) {
-            while(strlen($password) < 40)
-                $password = "0" . $password;
+            while(strlen($password) < 40) {
+                            $password = "0" . $password;
+            }
             $passwordLength=20;
         }
 
         // sessionInformation
         if(stripos($ocraSuite, ":s") !==false ||
                 stripos($ocraSuite, "-s", strpos($ocraSuite, ":", strpos($ocraSuite, ":")+1)) !== false) {
-            while(strlen($sessionInformation) < 128)
-                $sessionInformation = "0" . $sessionInformation;
+            while(strlen($sessionInformation) < 128) {
+                            $sessionInformation = "0" . $sessionInformation;
+            }
 
             $sessionInformationLength=64;
         }
@@ -148,8 +155,9 @@ 
         // TimeStamp
         if(stripos($ocraSuite, ":t") !==false ||
                 stripos($ocraSuite, "-t") !== false) {
-            while(strlen($timeStamp) < 16)
-                $timeStamp = "0" . $timeStamp;
+            while(strlen($timeStamp) < 16) {
+                            $timeStamp = "0" . $timeStamp;
+            }
             $timeStampLength=8;
         }
 

library/tiqr/Tiqr/Service.php

Braces +3 added lines, -1 removed lines

@@ -453,7 +453,9 @@
             $sessionId = session_id(); 
         }
         $status = $this->_stateStorage->getValue("enrollstatus".$sessionId);
-        if (is_null($status)) return self::ENROLLMENT_STATUS_IDLE;
+        if (is_null($status)) {
+            return self::ENROLLMENT_STATUS_IDLE;
+        }
         return $status;
     }
         

library/tiqr/Tiqr/UserStorage/FileTrait.php

Braces +3 added lines, -1 removed lines

@@ -47,7 +47,9 @@
      */
     public function getPath()
     {
-        if (substr($this->path, -1)!="/") return $this->path."/";
+        if (substr($this->path, -1)!="/") {
+            return $this->path."/";
+        }
         return $this->path;
     }
 }

library/tiqr/Tiqr/OATH/OCRA.php

Braces +42 added lines, -28 removed lines

@@ -122,12 +122,15 @@ 
         $cryptoFunction = $components[1];
         $dataInput = strtolower($components[2]); // lower here so we can do case insensitive comparisons
         
-        if(stripos($cryptoFunction, "sha1")!==false)
-            $crypto = "sha1";
-        if(stripos($cryptoFunction, "sha256")!==false)
-            $crypto = "sha256";
-        if(stripos($cryptoFunction, "sha512")!==false)
-            $crypto = "sha512";
+        if(stripos($cryptoFunction, "sha1")!==false) {
+                    $crypto = "sha1";
+        }
+        if(stripos($cryptoFunction, "sha256")!==false) {
+                    $crypto = "sha256";
+        }
+        if(stripos($cryptoFunction, "sha512")!==false) {
+                    $crypto = "sha512";
+        }
         
         $codeDigits = substr($cryptoFunction, strrpos($cryptoFunction, "-")+1);
                 
@@ -135,56 +138,65 @@ 
         // Counter
         if($dataInput[0] == "c" ) {
             // Fix the length of the HEX string
-            while(strlen($counter) < 16)
-                $counter = "0" . $counter;
+            while(strlen($counter) < 16) {
+                            $counter = "0" . $counter;
+            }
             $counterLength=8;
         }
         // Question
         if($dataInput[0] == "q" ||
                 stripos($dataInput, "-q")!==false) {
-            while(strlen($question) < 256)
-                $question = $question . "0";
+            while(strlen($question) < 256) {
+                            $question = $question . "0";
+            }
             $questionLength=128;
         }
 
         // Password
         if(stripos($dataInput, "psha1")!==false) {
-            while(strlen($password) < 40)
-                $password = "0" . $password;
+            while(strlen($password) < 40) {
+                            $password = "0" . $password;
+            }
             $passwordLength=20;
         }
     
         if(stripos($dataInput, "psha256")!==false) {
-            while(strlen($password) < 64)
-                $password = "0" . $password;
+            while(strlen($password) < 64) {
+                            $password = "0" . $password;
+            }
             $passwordLength=32;
         }
         
         if(stripos($dataInput, "psha512")!==false) {
-            while(strlen($password) < 128)
-                $password = "0" . $password;
+            while(strlen($password) < 128) {
+                            $password = "0" . $password;
+            }
             $passwordLength=64;
         }
         
         // sessionInformation
         if(stripos($dataInput, "s064") !==false) {
-            while(strlen($sessionInformation) < 128)
-                $sessionInformation = "0" . $sessionInformation;
+            while(strlen($sessionInformation) < 128) {
+                            $sessionInformation = "0" . $sessionInformation;
+            }
 
             $sessionInformationLength=64;
         } else if(stripos($dataInput, "s128") !==false) {
-            while(strlen($sessionInformation) < 256)
-                $sessionInformation = "0" . $sessionInformation;
+            while(strlen($sessionInformation) < 256) {
+                            $sessionInformation = "0" . $sessionInformation;
+            }
         
             $sessionInformationLength=128;
         } else if(stripos($dataInput, "s256") !==false) {
-            while(strlen($sessionInformation) < 512)
-                $sessionInformation = "0" . $sessionInformation;
+            while(strlen($sessionInformation) < 512) {
+                            $sessionInformation = "0" . $sessionInformation;
+            }
         
             $sessionInformationLength=256;
         } else if(stripos($dataInput, "s512") !==false) {
-            while(strlen($sessionInformation) < 128)
-                $sessionInformation = "0" . $sessionInformation;
+            while(strlen($sessionInformation) < 128) {
+                            $sessionInformation = "0" . $sessionInformation;
+            }
         
             $sessionInformationLength=64;
         } else if (stripos($dataInput, "-s") !== false ) {
@@ -196,8 +208,9 @@ 
             // to prevent matching the "s" in the password input e.g. "psha1".
             // [C] | QFxx | [PH | Snnn | TG] : Challenge-Response computation
             // [C] | QFxx | [PH | TG] : Plain Signature computation
-            while(strlen($sessionInformation) < 128)
-                $sessionInformation = "0" . $sessionInformation;
+            while(strlen($sessionInformation) < 128) {
+                            $sessionInformation = "0" . $sessionInformation;
+            }
             
             $sessionInformationLength=64;
         }
@@ -207,8 +220,9 @@ 
         // TimeStamp
         if($dataInput[0] == "t" ||
                 stripos($dataInput, "-t") !== false) {
-            while(strlen($timeStamp) < 16)
-                $timeStamp = "0" . $timeStamp;
+            while(strlen($timeStamp) < 16) {
+                            $timeStamp = "0" . $timeStamp;
+            }
             $timeStampLength=8;
         }