Passed
Push — develop ( 339f21...34e8b6 )
by Pieter van der
14:45
created
library/tiqr/Tiqr/UserSecretStorage.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@
 block discarded – undo
74 74
                 $password = $options['password'];
75 75
 
76 76
                 try {
77
-                    $handle = new PDO($dsn, $userName, $password, array(PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION) );
77
+                    $handle = new PDO($dsn, $userName, $password, array(PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION));
78 78
                 } catch (PDOException $e) {
79 79
                     $logger->error(
80 80
                         sprintf('Unable to establish a PDO connection. Error message from PDO: %s', $e->getMessage())
Please login to merge, or discard this patch.
library/tiqr/Tiqr/OcraService.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -39,10 +39,10 @@
 block discarded – undo
39 39
      * @return Tiqr_OcraService_Interface
40 40
      * @throws Exception An exception if an unknown orca service type is requested.
41 41
      */
42
-    public static function getOcraService(string $type="tiqr", array $options=array(), LoggerInterface $logger=null)
42
+    public static function getOcraService(string $type = "tiqr", array $options = array(), LoggerInterface $logger = null)
43 43
     {
44 44
         if (!$logger)
45
-            $logger=new \Psr\Log\NullLogger();
45
+            $logger = new \Psr\Log\NullLogger();
46 46
 
47 47
         switch ($type) {
48 48
             case "tiqr":
Please login to merge, or discard this patch.
library/tiqr/Tiqr/OATH/OCRAParser.php 1 patch
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
 	 */
46 46
 	private function parseOCRASuite($ocraSuite) {
47 47
 		if (!is_string($ocraSuite)) {
48
-			throw new Exception('OCRASuite not in string format: ' . var_export($ocraSuite, TRUE));
48
+			throw new Exception('OCRASuite not in string format: '.var_export($ocraSuite, TRUE));
49 49
 		}
50 50
 
51 51
 		$ocraSuite = strtoupper($ocraSuite);
@@ -53,54 +53,54 @@  discard block
 block discarded – undo
53 53
 
54 54
 		$s = explode(':', $ocraSuite);
55 55
 		if (count($s) != 3) {
56
-			throw new Exception('Invalid OCRASuite format: ' . var_export($ocraSuite, TRUE));
56
+			throw new Exception('Invalid OCRASuite format: '.var_export($ocraSuite, TRUE));
57 57
 		}
58 58
 
59 59
 		$algo = explode('-', $s[0]);
60 60
 		if (count($algo) != 2) {
61
-			throw new Exception('Invalid OCRA version: ' . var_export($s[0], TRUE));
61
+			throw new Exception('Invalid OCRA version: '.var_export($s[0], TRUE));
62 62
 		}
63 63
 
64 64
 		if ($algo[0] !== 'OCRA') {
65
-			throw new Exception('Unsupported OCRA algorithm: ' . var_export($algo[0], TRUE));
65
+			throw new Exception('Unsupported OCRA algorithm: '.var_export($algo[0], TRUE));
66 66
 		}
67 67
 
68 68
 		if ($algo[1] !== '1') {
69
-			throw new Exception('Unsupported OCRA version: ' . var_export($algo[1], TRUE));
69
+			throw new Exception('Unsupported OCRA version: '.var_export($algo[1], TRUE));
70 70
 		}
71 71
 		$this->OCRAVersion = $algo[1];
72 72
 
73 73
 		$cf = explode('-', $s[1]);
74 74
 		if (count($cf) != 3) {
75
-			throw new Exception('Invalid OCRA suite crypto function: ' . var_export($s[1], TRUE));
75
+			throw new Exception('Invalid OCRA suite crypto function: '.var_export($s[1], TRUE));
76 76
 		}
77 77
 
78 78
 		if ($cf[0] !== 'HOTP') {
79
-			throw new Exception('Unsupported OCRA suite crypto function: ' . var_export($cf[0], TRUE));
79
+			throw new Exception('Unsupported OCRA suite crypto function: '.var_export($cf[0], TRUE));
80 80
 		}
81 81
 		$this->CryptoFunctionType = $cf[0];
82 82
 
83 83
 		if (!array_key_exists($cf[1], $this->supportedHashFunctions)) {
84
-			throw new Exception('Unsupported hash function in OCRA suite crypto function: ' . var_export($cf[1], TRUE));
84
+			throw new Exception('Unsupported hash function in OCRA suite crypto function: '.var_export($cf[1], TRUE));
85 85
 		}
86 86
 		$this->CryptoFunctionHash = $cf[1];
87 87
 		$this->CryptoFunctionHashLength = $this->supportedHashFunctions[$cf[1]];
88 88
 
89 89
 		if (!preg_match('/^\d+$/', $cf[2]) || (($cf[2] < 4 || $cf[2] > 10) && $cf[2] != 0)) {
90
-			throw new Exception('Invalid OCRA suite crypto function truncation length: ' . var_export($cf[2], TRUE));
90
+			throw new Exception('Invalid OCRA suite crypto function truncation length: '.var_export($cf[2], TRUE));
91 91
 		}
92 92
 		$this->CryptoFunctionTruncation = intval($cf[2]);
93 93
 
94 94
 		$di = explode('-', $s[2]);
95 95
 		if (count($cf) == 0) {
96
-			throw new Exception('Invalid OCRA suite data input: ' . var_export($s[2], TRUE));
96
+			throw new Exception('Invalid OCRA suite data input: '.var_export($s[2], TRUE));
97 97
 		}
98 98
 
99 99
 		$data_input = array();
100
-		foreach($di as $elem) {
100
+		foreach ($di as $elem) {
101 101
 			$letter = $elem[0];
102 102
 			if (array_key_exists($letter, $data_input)) {
103
-				throw new Exception('Duplicate field in OCRA suite data input: ' . var_export($elem, TRUE));
103
+				throw new Exception('Duplicate field in OCRA suite data input: '.var_export($elem, TRUE));
104 104
 			}
105 105
 			$data_input[$letter] = 1;
106 106
 
@@ -112,13 +112,13 @@  discard block
 block discarded – undo
112 112
 				} elseif (preg_match('/^Q([AHN])(\d+)$/', $elem, $match)) {
113 113
 					$q_len = intval($match[2]);
114 114
 					if ($q_len < 4 || $q_len > 64) {
115
-						throw new Exception('Invalid OCRA suite data input question length: ' . var_export($q_len, TRUE));
115
+						throw new Exception('Invalid OCRA suite data input question length: '.var_export($q_len, TRUE));
116 116
 					}
117 117
 					$this->Q = TRUE;
118 118
 					$this->QType = $match[1];
119 119
 					$this->QLength = $q_len;
120 120
 				} else {
121
-					throw new Exception('Invalid OCRA suite data input question: ' . var_export($elem, TRUE));
121
+					throw new Exception('Invalid OCRA suite data input question: '.var_export($elem, TRUE));
122 122
 				}
123 123
 			} elseif ($letter === 'P') {
124 124
 				if (strlen($elem) == 1) {
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
 				} else {
127 127
 					$p_algo = substr($elem, 1);
128 128
 					if (!array_key_exists($p_algo, $this->supportedHashFunctions)) {
129
-						throw new Exception('Unsupported OCRA suite PIN hash function: ' . var_export($elem, TRUE));
129
+						throw new Exception('Unsupported OCRA suite PIN hash function: '.var_export($elem, TRUE));
130 130
 					}
131 131
 					$this->P = TRUE;
132 132
 					$this->PType = $p_algo;
@@ -138,13 +138,13 @@  discard block
 block discarded – undo
138 138
 				} elseif (preg_match('/^S(\d+)$/', $elem, $match)) {
139 139
 					$s_len = intval($match[1]);
140 140
 					if ($s_len <= 0 || $s_len > 512) {
141
-						throw new Exception('Invalid OCRA suite data input session information length: ' . var_export($s_len, TRUE));
141
+						throw new Exception('Invalid OCRA suite data input session information length: '.var_export($s_len, TRUE));
142 142
 					}
143 143
 
144 144
 					$this->S = TRUE;
145 145
 					$this->SLength = $s_len;
146 146
 				} else {
147
-					throw new Exception('Invalid OCRA suite data input session information length: ' . var_export($elem, TRUE));
147
+					throw new Exception('Invalid OCRA suite data input session information length: '.var_export($elem, TRUE));
148 148
 				}
149 149
 			} elseif ($letter === 'T') {
150 150
 				if (strlen($elem) == 1) {
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
 					preg_match_all('/(\d+)([HMS])/', $elem, $match);
154 154
 
155 155
 					if (count($match[1]) !== count(array_unique($match[2]))) {
156
-						throw new Exception('Duplicate definitions in OCRA suite data input timestamp: ' . var_export($elem, TRUE));
156
+						throw new Exception('Duplicate definitions in OCRA suite data input timestamp: '.var_export($elem, TRUE));
157 157
 					}
158 158
 
159 159
 					$length = 0;
@@ -161,21 +161,21 @@  discard block
 block discarded – undo
161 161
 						$length += intval($match[1][$i]) * $this->TPeriods[$match[2][$i]];
162 162
 					}
163 163
 					if ($length <= 0) {
164
-						throw new Exception('Invalid OCRA suite data input timestamp: ' . var_export($elem, TRUE));
164
+						throw new Exception('Invalid OCRA suite data input timestamp: '.var_export($elem, TRUE));
165 165
 					}
166 166
 
167 167
 					$this->T = TRUE;
168 168
 					$this->TLength = $length;
169 169
 				} else {
170
-					throw new Exception('Invalid OCRA suite data input timestamp: ' . var_export($elem, TRUE));
170
+					throw new Exception('Invalid OCRA suite data input timestamp: '.var_export($elem, TRUE));
171 171
 				}
172 172
 			} else {
173
-				throw new Exception('Unsupported OCRA suite data input field: ' . var_export($elem, TRUE));
173
+				throw new Exception('Unsupported OCRA suite data input field: '.var_export($elem, TRUE));
174 174
 			}
175 175
 		}
176 176
 
177 177
 		if (!$this->Q) {
178
-			throw new Exception('OCRA suite data input question not defined: ' . var_export($s[2], TRUE));
178
+			throw new Exception('OCRA suite data input question not defined: '.var_export($s[2], TRUE));
179 179
 		}
180 180
 	}
181 181
 
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
 
197 197
         $bytes = Tiqr_Random::randomBytes($q_length);
198 198
 
199
-		switch($q_type) {
199
+		switch ($q_type) {
200 200
 			case 'A':
201 201
 				$challenge = base64_encode($bytes);
202 202
 				$tr = implode("", unpack('H*', $bytes));
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
209 209
 				$challenge = implode("", unpack('N*', $bytes));
210 210
 				break;
211 211
 			default:
212
-				throw new Exception('Unsupported OCRASuite challenge type: ' . var_export($q_type, TRUE));
212
+				throw new Exception('Unsupported OCRASuite challenge type: '.var_export($q_type, TRUE));
213 213
 				break;
214 214
 		}
215 215
 
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
 			$result &= ($s1[$i] == $s2[$i]);
234 234
 		}
235 235
 
236
-		return (boolean)$result;
236
+		return (boolean) $result;
237 237
 	}
238 238
 
239 239
 }
Please login to merge, or discard this patch.
library/tiqr/Tiqr/OcraService/Abstract.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
         $this->logger = $logger;
36 36
 
37 37
         // Set the OCRA suite
38
-        $this->_ocraSuite = $config['ocra.suite'] ?? 'OCRA-1:HOTP-SHA1-6:QH10-S';   // Use tiqr server default suite
38
+        $this->_ocraSuite = $config['ocra.suite'] ?? 'OCRA-1:HOTP-SHA1-6:QH10-S'; // Use tiqr server default suite
39 39
         $this->_ocraParser = new OATH_OCRAParser($this->_ocraSuite);
40 40
     }
41 41
 
Please login to merge, or discard this patch.
library/tiqr/Tiqr/DeviceStorage.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -40,10 +40,10 @@
 block discarded – undo
40 40
      * @param LoggerInterface $logger
41 41
      * @throws Exception An exception if an unknown storage is requested.
42 42
      */
43
-    public static function getStorage(string $type="dummy", Array $options=array(), LoggerInterface $logger=null)
43
+    public static function getStorage(string $type = "dummy", Array $options = array(), LoggerInterface $logger = null)
44 44
     {
45 45
         if (!$logger)
46
-            $logger=new \Psr\Log\NullLogger();
46
+            $logger = new \Psr\Log\NullLogger();
47 47
 
48 48
         switch ($type) {
49 49
             case "dummy":
Please login to merge, or discard this patch.
library/tiqr/Tiqr/UserSecretStorage/Encryption.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@
 block discarded – undo
38 38
      *
39 39
      * @return Tiqr_UserSecretStorage_Encryption_Interface
40 40
      */
41
-    public static function getEncryption(LoggerInterface $logger, string $type="dummy", array $options=array()): Tiqr_UserSecretStorage_Encryption_Interface
41
+    public static function getEncryption(LoggerInterface $logger, string $type = "dummy", array $options = array()): Tiqr_UserSecretStorage_Encryption_Interface
42 42
     {
43 43
         $instance = null;
44 44
         $logger->info(sprintf('Using "%s" as UserSecretStorage encryption type', $type));
Please login to merge, or discard this patch.
library/tiqr/Tiqr/UserSecretStorage/Encryption/OpenSSL.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -48,22 +48,22 @@  discard block
 block discarded – undo
48 48
     */
49 49
 
50 50
     private $_supportedCiphers = [
51
-        'aes-128-cbc' => [ 'tag' => false, 'key' => 16 ],
52
-        'aes-128-gcm' => [ 'tag' => true, 'key' => 16 ],
53
-        'aes-192-cbc' => [ 'tag' => false, 'key' => 24 ],
54
-        'aes-192-gcm' => [ 'tag' => true, 'key' => 24 ],
55
-        'aes-256-cbc' => [ 'tag' => false, 'key' => 32 ],
56
-        'aes-256-gcm' => [ 'tag' => true, 'key' => 32 ],
57
-        'chacha20' => [ 'tag' => false, 'key' => 32 ],
58
-        'camellia-128-cbc' => [ 'tag' => false, 'key' => 16 ],
59
-        'camellia-192-cbc' => [ 'tag' => false, 'key' => 24 ],
60
-        'camellia-256-cbc' => [ 'tag' => false, 'key' => 32 ],
61
-        'aria-128-cbc' => [ 'tag' => false, 'key' => 16 ],
62
-        'aria-128-gcm' => [ 'tag' => true, 'key' => 16 ],
63
-        'aria-192-cbc' => [ 'tag' => false, 'key' => 24 ],
64
-        'aria-192-gcm' => [ 'tag' => true, 'key' => 24 ],
65
-        'aria-256-cbc' => [ 'tag' => false, 'key' => 32 ],
66
-        'aria-256-gcm' => [ 'tag' => true, 'key' => 32 ],
51
+        'aes-128-cbc' => ['tag' => false, 'key' => 16],
52
+        'aes-128-gcm' => ['tag' => true, 'key' => 16],
53
+        'aes-192-cbc' => ['tag' => false, 'key' => 24],
54
+        'aes-192-gcm' => ['tag' => true, 'key' => 24],
55
+        'aes-256-cbc' => ['tag' => false, 'key' => 32],
56
+        'aes-256-gcm' => ['tag' => true, 'key' => 32],
57
+        'chacha20' => ['tag' => false, 'key' => 32],
58
+        'camellia-128-cbc' => ['tag' => false, 'key' => 16],
59
+        'camellia-192-cbc' => ['tag' => false, 'key' => 24],
60
+        'camellia-256-cbc' => ['tag' => false, 'key' => 32],
61
+        'aria-128-cbc' => ['tag' => false, 'key' => 16],
62
+        'aria-128-gcm' => ['tag' => true, 'key' => 16],
63
+        'aria-192-cbc' => ['tag' => false, 'key' => 24],
64
+        'aria-192-gcm' => ['tag' => true, 'key' => 24],
65
+        'aria-256-cbc' => ['tag' => false, 'key' => 32],
66
+        'aria-256-gcm' => ['tag' => true, 'key' => 32],
67 67
     ];
68 68
 
69 69
     /**
@@ -136,12 +136,12 @@  discard block
 block discarded – undo
136 136
         // A longer key is not a problem, but could indicate a configuration error
137 137
         $key_length = $this->_supportedCiphers[$this->_cipher]['key'];
138 138
         if (strlen($key) != $key_length) {
139
-            throw new RuntimeException("Invalid length of key with key_id '{$this->_key_id}' used with cipher '{$this->_cipher}', expected {$key_length} bytes, got " . strlen($key) . " bytes");
139
+            throw new RuntimeException("Invalid length of key with key_id '{$this->_key_id}' used with cipher '{$this->_cipher}', expected {$key_length} bytes, got ".strlen($key)." bytes");
140 140
         }
141 141
 
142 142
         // openssl_encrypt returns the ciphertext as a base64 encoded string, so we don't need to encode it again
143 143
         // The tag is returned as a binary string, but only if the cipher requires a tag
144
-        $tag='';
144
+        $tag = '';
145 145
         if ($this->_supportedCiphers[$this->_cipher]['tag']) {
146 146
             $encrypted = openssl_encrypt($data, $this->_cipher, $key, 0, $iv, $tag, '', 16);
147 147
         } else {
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
         $tag = $this->_supportedCiphers[$this->_cipher]['tag'] ? $tag : '';
154 154
         // Return the encoded ciphertext, including the IV, tag and cipher
155 155
         // <cipher>:<key_id>:iv<>:<tag>:<ciphertext>
156
-        $encoded = $this->_cipher . ":" . $this->_key_id . ":" . base64_encode($iv) . ":" . base64_encode($tag) . ":" . $encrypted;
156
+        $encoded = $this->_cipher.":".$this->_key_id.":".base64_encode($iv).":".base64_encode($tag).":".$encrypted;
157 157
 
158 158
         return $encoded;
159 159
     }
@@ -192,19 +192,19 @@  discard block
 block discarded – undo
192 192
         }
193 193
 
194 194
         // IV
195
-        $iv = base64_decode($split_data[2],true);
195
+        $iv = base64_decode($split_data[2], true);
196 196
         if ($iv === false) {
197 197
             throw new RuntimeException("Error decoding IV");
198 198
         }
199 199
 
200 200
         // Tag
201
-        $tag = base64_decode($split_data[3],true);
201
+        $tag = base64_decode($split_data[3], true);
202 202
         if ($tag === false) {
203 203
             throw new RuntimeException("Error decoding tag");
204 204
         }
205 205
         $ciphertext = $split_data[4];
206 206
 
207
-        $plaintext=openssl_decrypt($ciphertext, $cipher, $key, 0, $iv, $tag);
207
+        $plaintext = openssl_decrypt($ciphertext, $cipher, $key, 0, $iv, $tag);
208 208
         if ($plaintext === false) {
209 209
             throw new RuntimeException("Error decrypting data");
210 210
         }
Please login to merge, or discard this patch.
library/tiqr/Tiqr/DeviceStorage/TokenExchange.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
     {
41 41
         $url = $this->_options["url"]."?appId=".$this->_options["appid"];
42 42
         
43
-        $url.= "&notificationToken=".$notificationToken;
43
+        $url .= "&notificationToken=".$notificationToken;
44 44
 
45 45
         $ch = curl_init();
46 46
 
@@ -53,12 +53,12 @@  discard block
 block discarded – undo
53 53
         $output = curl_exec($ch);
54 54
         curl_close($ch);
55 55
 
56
-        if (stripos($output, "not found")!==false) {
56
+        if (stripos($output, "not found") !== false) {
57 57
             $this->logger->error('Token Exchange failed and responded with: not found', ['full output' => $output]);
58 58
             return false;
59 59
         }
60 60
 
61
-        if (stripos($output, "error")!==false) {
61
+        if (stripos($output, "error") !== false) {
62 62
             $this->logger->error('Token Exchange failed and responded with: error', ['full output' => $output]);
63 63
             return false;
64 64
         }
Please login to merge, or discard this patch.
library/tiqr/Tiqr/OATH/OCRA.php 1 patch
Spacing   +75 added lines, -75 removed lines patch added patch discarded remove patch
@@ -58,18 +58,18 @@  discard block
 block discarded – undo
58 58
     private static function _hexStr2Bytes(string $hex, int $maxBytes, string $parameterName) : string
59 59
     {
60 60
         $len = strlen($hex);
61
-        if ( ($len !== 0) && (! ctype_xdigit($hex)) ) {
61
+        if (($len !== 0) && (!ctype_xdigit($hex))) {
62 62
             throw new InvalidArgumentException("Parameter '$parameterName' contains non hex digits");
63 63
         }
64
-        if ( $len % 2 !== 0 ) {
64
+        if ($len % 2 !== 0) {
65 65
             throw new InvalidArgumentException("Parameter '$parameterName' contains odd number of hex digits");
66 66
         }
67
-        if ( $len > $maxBytes * 2) {
67
+        if ($len > $maxBytes * 2) {
68 68
             throw new InvalidArgumentException("Parameter '$parameterName' too long");
69 69
         }
70 70
         // hex2bin logs PHP warnings when $hex contains invalid characters or has uneven length. Because we
71 71
         // check for these conditions above hex2bin() should always be silent
72
-        $res=hex2bin($hex);
72
+        $res = hex2bin($hex);
73 73
         if (false === $res) {
74 74
             throw new InvalidArgumentException("Parameter '$parameterName' could not be decoded");
75 75
         }
@@ -125,83 +125,83 @@  discard block
 block discarded – undo
125 125
         $cryptoFunction = $components[1];
126 126
         $dataInput = strtolower($components[2]); // lower here so we can do case insensitive comparisons
127 127
 
128
-        if(stripos($cryptoFunction, "hotp-sha1")!==false)
128
+        if (stripos($cryptoFunction, "hotp-sha1") !== false)
129 129
             $crypto = "sha1";
130
-        elseif(stripos($cryptoFunction, "hotp-sha256")!==false)
130
+        elseif (stripos($cryptoFunction, "hotp-sha256") !== false)
131 131
             $crypto = "sha256";
132
-        elseif(stripos($cryptoFunction, "hotp-sha512")!==false)
132
+        elseif (stripos($cryptoFunction, "hotp-sha512") !== false)
133 133
             $crypto = "sha512";
134 134
         else {
135 135
             throw new InvalidArgumentException('Unsupported OCRA CryptoFunction');
136 136
         }
137 137
 
138 138
         // The Cryptofucntion must ha a truncation of 0, 4-10
139
-        $codeDigits_str = substr($cryptoFunction, strrpos($cryptoFunction, "-")+1);
140
-        if (! ctype_digit($codeDigits_str)) {
139
+        $codeDigits_str = substr($cryptoFunction, strrpos($cryptoFunction, "-") + 1);
140
+        if (!ctype_digit($codeDigits_str)) {
141 141
             throw new InvalidArgumentException('Unsupported OCRA CryptoFunction');
142 142
         }
143
-        $codeDigits = (integer)$codeDigits_str;
143
+        $codeDigits = (integer) $codeDigits_str;
144 144
         if (($codeDigits != 0) && (($codeDigits < 4) || ($codeDigits > 10))) {
145 145
             throw new InvalidArgumentException('Unsupported OCRA CryptoFunction');
146 146
         }
147 147
                 
148 148
         // The size of the byte array message to be encrypted
149 149
         // Counter
150
-        if($dataInput[0] == "c" ) {
150
+        if ($dataInput[0] == "c") {
151 151
             // Fix the length of the HEX string
152
-            while(strlen($counter) < 16)
153
-                $counter = "0" . $counter;
154
-            $counterLength=8;
152
+            while (strlen($counter) < 16)
153
+                $counter = "0".$counter;
154
+            $counterLength = 8;
155 155
         }
156 156
         // Question
157
-        if($dataInput[0] == "q" ||
158
-                stripos($dataInput, "-q")!==false) {
159
-            while(strlen($question) < 256)
160
-                $question = $question . "0";
161
-            $questionLength=128;
157
+        if ($dataInput[0] == "q" ||
158
+                stripos($dataInput, "-q") !== false) {
159
+            while (strlen($question) < 256)
160
+                $question = $question."0";
161
+            $questionLength = 128;
162 162
         }
163 163
 
164 164
         // Password
165
-        if(stripos($dataInput, "psha1")!==false) {
166
-            while(strlen($password) < 40)
167
-                $password = "0" . $password;
168
-            $passwordLength=20;
165
+        if (stripos($dataInput, "psha1") !== false) {
166
+            while (strlen($password) < 40)
167
+                $password = "0".$password;
168
+            $passwordLength = 20;
169 169
         }
170 170
     
171
-        if(stripos($dataInput, "psha256")!==false) {
172
-            while(strlen($password) < 64)
173
-                $password = "0" . $password;
174
-            $passwordLength=32;
171
+        if (stripos($dataInput, "psha256") !== false) {
172
+            while (strlen($password) < 64)
173
+                $password = "0".$password;
174
+            $passwordLength = 32;
175 175
         }
176 176
         
177
-        if(stripos($dataInput, "psha512")!==false) {
178
-            while(strlen($password) < 128)
179
-                $password = "0" . $password;
180
-            $passwordLength=64;
177
+        if (stripos($dataInput, "psha512") !== false) {
178
+            while (strlen($password) < 128)
179
+                $password = "0".$password;
180
+            $passwordLength = 64;
181 181
         }
182 182
         
183 183
         // sessionInformation
184
-        if(stripos($dataInput, "s064") !==false) {
185
-            while(strlen($sessionInformation) < 128)
186
-                $sessionInformation = "0" . $sessionInformation;
184
+        if (stripos($dataInput, "s064") !== false) {
185
+            while (strlen($sessionInformation) < 128)
186
+                $sessionInformation = "0".$sessionInformation;
187 187
 
188
-            $sessionInformationLength=64;
189
-        } else if(stripos($dataInput, "s128") !==false) {
190
-            while(strlen($sessionInformation) < 256)
191
-                $sessionInformation = "0" . $sessionInformation;
188
+            $sessionInformationLength = 64;
189
+        } else if (stripos($dataInput, "s128") !== false) {
190
+            while (strlen($sessionInformation) < 256)
191
+                $sessionInformation = "0".$sessionInformation;
192 192
         
193
-            $sessionInformationLength=128;
194
-        } else if(stripos($dataInput, "s256") !==false) {
195
-            while(strlen($sessionInformation) < 512)
196
-                $sessionInformation = "0" . $sessionInformation;
193
+            $sessionInformationLength = 128;
194
+        } else if (stripos($dataInput, "s256") !== false) {
195
+            while (strlen($sessionInformation) < 512)
196
+                $sessionInformation = "0".$sessionInformation;
197 197
         
198
-            $sessionInformationLength=256;
199
-        } else if(stripos($dataInput, "s512") !==false) {
200
-            while(strlen($sessionInformation) < 128)
201
-                $sessionInformation = "0" . $sessionInformation;
198
+            $sessionInformationLength = 256;
199
+        } else if (stripos($dataInput, "s512") !== false) {
200
+            while (strlen($sessionInformation) < 128)
201
+                $sessionInformation = "0".$sessionInformation;
202 202
         
203
-            $sessionInformationLength=64;
204
-        } else if (stripos($dataInput, "-s") !== false ) {
203
+            $sessionInformationLength = 64;
204
+        } else if (stripos($dataInput, "-s") !== false) {
205 205
             // deviation from spec. Officially 's' without a length indicator is not in the reference implementation.
206 206
             // RFC is ambigious. However we have supported this in Tiqr since day 1, so we continue to support it.
207 207
 
@@ -210,27 +210,27 @@  discard block
 block discarded – undo
210 210
             // to prevent matching the "s" in the password input e.g. "psha1".
211 211
             // [C] | QFxx | [PH | Snnn | TG] : Challenge-Response computation
212 212
             // [C] | QFxx | [PH | TG] : Plain Signature computation
213
-            while(strlen($sessionInformation) < 128)
214
-                $sessionInformation = "0" . $sessionInformation;
213
+            while (strlen($sessionInformation) < 128)
214
+                $sessionInformation = "0".$sessionInformation;
215 215
             
216
-            $sessionInformationLength=64;
216
+            $sessionInformationLength = 64;
217 217
         }
218 218
         
219 219
         
220 220
              
221 221
         // TimeStamp
222
-        if($dataInput[0] == "t" ||
222
+        if ($dataInput[0] == "t" ||
223 223
                 stripos($dataInput, "-t") !== false) {
224
-            while(strlen($timeStamp) < 16)
225
-                $timeStamp = "0" . $timeStamp;
226
-            $timeStampLength=8;
224
+            while (strlen($timeStamp) < 16)
225
+                $timeStamp = "0".$timeStamp;
226
+            $timeStampLength = 8;
227 227
         }
228 228
 
229 229
         // Put the bytes of "ocraSuite" parameters into the message
230 230
         
231
-        $msg = array_fill(0,$ocraSuiteLength+$counterLength+$questionLength+$passwordLength+$sessionInformationLength+$timeStampLength+1, 0);
231
+        $msg = array_fill(0, $ocraSuiteLength + $counterLength + $questionLength + $passwordLength + $sessionInformationLength + $timeStampLength + 1, 0);
232 232
                 
233
-        for($i=0;$i<strlen($ocraSuite);$i++) {
233
+        for ($i = 0; $i < strlen($ocraSuite); $i++) {
234 234
             $msg[$i] = $ocraSuite[$i];
235 235
         }
236 236
         
@@ -239,9 +239,9 @@  discard block
 block discarded – undo
239 239
 
240 240
         // Put the bytes of "Counter" to the message
241 241
         // Input is HEX encoded
242
-        if($counterLength > 0 ) {
242
+        if ($counterLength > 0) {
243 243
             $bArray = self::_hexStr2Bytes($counter, $counterLength, 'counter');
244
-            for ($i=0;$i<strlen($bArray);$i++) {
244
+            for ($i = 0; $i < strlen($bArray); $i++) {
245 245
                 $msg [$i + $ocraSuiteLength + 1] = $bArray[$i];
246 246
             }
247 247
         }
@@ -249,41 +249,41 @@  discard block
 block discarded – undo
249 249
 
250 250
         // Put the bytes of "question" to the message
251 251
         // Input is text encoded
252
-        if($questionLength > 0 ) {
252
+        if ($questionLength > 0) {
253 253
             $bArray = self::_hexStr2Bytes($question, $questionLength, 'question');
254
-            for ($i=0;$i<strlen($bArray);$i++) {
254
+            for ($i = 0; $i < strlen($bArray); $i++) {
255 255
                 $msg [$i + $ocraSuiteLength + 1 + $counterLength] = $bArray[$i];
256 256
             }
257 257
         }
258 258
 
259 259
         // Put the bytes of "password" to the message
260 260
         // Input is HEX encoded
261
-        if($passwordLength > 0){
261
+        if ($passwordLength > 0) {
262 262
             $bArray = self::_hexStr2Bytes($password, $passwordLength, 'password');
263
-            for ($i=0;$i<strlen($bArray);$i++) {
263
+            for ($i = 0; $i < strlen($bArray); $i++) {
264 264
                 $msg [$i + $ocraSuiteLength + 1 + $counterLength + $questionLength] = $bArray[$i];
265 265
             }
266 266
         }
267 267
 
268 268
         // Put the bytes of "sessionInformation" to the message
269 269
         // Input is HEX encoded
270
-        if($sessionInformationLength > 0 ){
270
+        if ($sessionInformationLength > 0) {
271 271
             $bArray = self::_hexStr2Bytes($sessionInformation, $sessionInformationLength, 'sessionInformation');
272
-            for ($i=0;$i<strlen($bArray);$i++) {
272
+            for ($i = 0; $i < strlen($bArray); $i++) {
273 273
                 $msg [$i + $ocraSuiteLength + 1 + $counterLength + $questionLength + $passwordLength] = $bArray[$i];
274 274
             }
275 275
         }
276 276
 
277 277
         // Put the bytes of "time" to the message
278 278
         // Input is HEX encoded value of minutes
279
-        if($timeStampLength > 0){
279
+        if ($timeStampLength > 0) {
280 280
             $bArray = self::_hexStr2Bytes($timeStamp, $timeStampLength, 'timeStamp');
281
-            for ($i=0;$i<strlen($bArray);$i++) {
281
+            for ($i = 0; $i < strlen($bArray); $i++) {
282 282
                 $msg [$i + $ocraSuiteLength + 1 + $counterLength + $questionLength + $passwordLength + $sessionInformationLength] = $bArray[$i];
283 283
             }
284 284
         }
285 285
         
286
-        $byteKey = self::_hexStr2Bytes($key, strlen($key)/2, 'key');
286
+        $byteKey = self::_hexStr2Bytes($key, strlen($key) / 2, 'key');
287 287
               
288 288
         $msg = implode("", $msg);
289 289
 
@@ -308,23 +308,23 @@  discard block
 block discarded – undo
308 308
     static function _oath_truncate(string $hash, int $length = 6) : string
309 309
     {
310 310
         // Convert to dec
311
-        foreach(str_split($hash,2) as $hex)
311
+        foreach (str_split($hash, 2) as $hex)
312 312
         {
313
-            $hmac_result[]=hexdec($hex);
313
+            $hmac_result[] = hexdec($hex);
314 314
         }
315 315
     
316 316
         // Find offset
317 317
         $offset = $hmac_result[count($hmac_result) - 1] & 0xf;
318 318
     
319 319
         $v = strval(
320
-            (($hmac_result[$offset+0] & 0x7f) << 24 ) |
321
-            (($hmac_result[$offset+1] & 0xff) << 16 ) |
322
-            (($hmac_result[$offset+2] & 0xff) << 8 ) |
323
-            ($hmac_result[$offset+3] & 0xff)
320
+            (($hmac_result[$offset + 0] & 0x7f) << 24) |
321
+            (($hmac_result[$offset + 1] & 0xff) << 16) |
322
+            (($hmac_result[$offset + 2] & 0xff) << 8) |
323
+            ($hmac_result[$offset + 3] & 0xff)
324 324
         );
325 325
 
326 326
         // Prefix truncated string with 0's to ensure it always has the required length
327
-        $v=str_pad($v, $length, "0", STR_PAD_LEFT);
327
+        $v = str_pad($v, $length, "0", STR_PAD_LEFT);
328 328
 
329 329
         $v = substr($v, strlen($v) - $length);
330 330
         return $v;
Please login to merge, or discard this patch.