Tiqr_DeviceStorage_TokenExchange

Complexity

Total Complexity

3

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	3
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	getDeviceToken()	0	28	3

<?php
/**
 * This file is part of the tiqr project.
 * 
 * The tiqr project aims to provide an open implementation for 
 * authentication using mobile devices. It was initiated by 
 * SURFnet and developed by Egeniq.
 *
 * More information: http://www.tiqr.org
 *
 * @author Ivo Jansch <ivo@egeniq.com>
 * 
 * @package tiqr
 *
 * @license New BSD License - See LICENSE file for details.
 *
 * @copyright (C) 2010-2011 SURFnet BV
 */


/**
 * A DeviceStorage implementation that uses a tokenexhange server to swap
 * notificationTokens for deviceTokens.
 * 
 * The following options can be passed when creating a tokenexchange instance
 * (which should be done through the Tiqr_DeviceStorage factory):
 * - 'appid' the app identifier of the client app used to exchange tokens, 
 *           must match the appid used in the mobile client apps.
 * - 'url' the url of the tokenexchange service
 * 
 * @author ivo
 *
 */
class Tiqr_DeviceStorage_TokenExchange extends Tiqr_DeviceStorage_Abstract
{  
    /**
     * @see Tiqr_DeviceStorage_Abstract::getDeviceToken()
     */ 
    public function getDeviceToken(string $notificationToken)
    {
        $url = $this->_options["url"]."?appId=".$this->_options["appid"];
        
        $url.= "&notificationToken=".$notificationToken;

        $ch = curl_init();

        curl_setopt($ch, CURLOPT_AUTOREFERER, TRUE);
        curl_setopt($ch, CURLOPT_HEADER, 0);
        curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
        curl_setopt($ch, CURLOPT_URL, $url);
        curl_setopt($ch, CURLOPT_FOLLOWLOCATION, TRUE);

        $output = curl_exec($ch);
        curl_close($ch);

        if (stripos($output, "not found")!==false) {

It seems like $output can also be of type true; however, parameter $haystack of stripos() does only seem to accept string, maybe add an additional type check?

            $this->logger->error('Token Exchange failed and responded with: not found', ['full output' => $output]);
            return false;
        }

        if (stripos($output, "error")!==false) {
            $this->logger->error('Token Exchange failed and responded with: error', ['full output' => $output]);
            return false;
        }
        $this->logger->notice(sprintf('Token exchange returned output: %s', $output));

It seems like $output can also be of type true; however, parameter $values of sprintf() does only seem to accept double|integer|string, maybe add an additional type check?

        return trim($output);

It seems like $output can also be of type true; however, parameter $string of trim() does only seem to accept string, maybe add an additional type check?

    }
}