Issues in AbstractSeeder.php (master) - Issues in master - TildBJ/seeder - Measure and Improve Code Quality continuously with Scrutinizer

Issues (94)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Classes/AbstractSeeder.php (1 issue)

Labels

Bug 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace TildBJ\Seeder;

/***************************************************************
 *  Copyright notice
 *
 *  (c) 2016 Dennis Römmich <[email protected]>
 *
 *  All rights reserved
 *
 *  This script is part of the TYPO3 project. The TYPO3 project is
 *  free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 2 of the License, or
 *  (at your option) any later version.
 *
 *  The GNU General Public License can be found at
 *  http://www.gnu.org/copyleft/gpl.html.
 *
 *  This script is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *
 *  This copyright notice MUST APPEAR in all copies of the script!
 ***************************************************************/
use TildBJ\Seeder\Collection\SeedCollection;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use TYPO3\CMS\Core\Utility\GeneralUtility;

/**
 * Seeder
 *
 * @author Dennis Römmich<[email protected]>
 * @copyright Copyright belongs to the respective authors
 * @license http://www.gnu.org/licenses/gpl.html GNU General Public License, version 3 or later
 */
abstract class AbstractSeeder implements Seeder
{
    /**
     * connection
     *
     * @var Connection $connection
     */
    protected $connection = null;

    /**
     * factory
     *
     * @var SeederFactory $factory
     */
    protected $factory = null;

    /**
     * AbstractSeeder constructor.
     */
    public function __construct()
    {
        $this->factory = GeneralUtility::makeInstance(
            Factory\SeederFactory::class,
            \TildBJ\Seeder\Factory\FakerFactory::createFaker()
        );
    }

    /**
     * setConnection
     *
     * @param Connection $connection
     * @return void
     */
    public function setConnection(Connection $connection)
    {
        $this->connection = $connection;
    }

    /**
     * preProcess
     *
     * @return void
     */
    abstract protected function before();

    /**
     * after
     *
     * @return void
     */
    abstract protected function after();

    /**
     * seed
     *
     * @throws Connection\NotFoundException
     * @return bool
     */
    final public function seed()
    {
        $this->before();

        if (is_null($this->connection)) {
            throw new Connection\NotFoundException('Connection not found.');
        }

        /** @var SeedCollection $seedCollection */
        $seedCollection = GeneralUtility::makeInstance(SeedCollection::class);

        $success = $this->connection->fetch($seedCollection->toArray());

        $this->after();

        return $success;
    }

    protected function getKeys()
    {
        /** @var SeedCollection $seedCollection */
        $seedCollection = GeneralUtility::makeInstance(SeedCollection::class);

        $keyArray = $seedCollection->get($this);
        if (!is_array($keyArray)) {
            return '';
        }
        return implode(',', array_keys($keyArray));
    }

    /**
     * @return string
     */
    public function getClass()
    {
        return get_class($this);
    }

    /**
     * @param $className
     * @throws \TYPO3\CMS\Extbase\Object\InvalidClassException
     * @return string
     */
    final protected function call($className)
    {
        if ($className === $this->getClass()) {
            throw new \TYPO3\CMS\Extbase\Object\InvalidClassException('Invalid loop detected in ' . $className);
        }
        /** @var self $class */
        $class = new $className;
        $class->run();
        $keys = $class->getKeys();

        return $keys;
    }
}


1		<?php
2		namespace TildBJ\Seeder;
3
4		/***************************************************************
5		* Copyright notice
6		*
7		* (c) 2016 Dennis Römmich <[email protected]>
8		*
9		* All rights reserved
10		*
11		* This script is part of the TYPO3 project. The TYPO3 project is
12		* free software; you can redistribute it and/or modify
13		* it under the terms of the GNU General Public License as published by
14		* the Free Software Foundation; either version 2 of the License, or
15		* (at your option) any later version.
16		*
17		* The GNU General Public License can be found at
18		* http://www.gnu.org/copyleft/gpl.html.
19		*
20		* This script is distributed in the hope that it will be useful,
21		* but WITHOUT ANY WARRANTY; without even the implied warranty of
22		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
23		* GNU General Public License for more details.
24		*
25		* This copyright notice MUST APPEAR in all copies of the script!
26		***************************************************************/
27		use TildBJ\Seeder\Collection\SeedCollection;
		0 ignored issues – show Bug introduced 2018-03-19 19:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `TildBJ\Seeder\SeedCollection`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
28		use TYPO3\CMS\Core\Utility\GeneralUtility;
29
30		/**
31		* Seeder
32		*
33		* @author Dennis Römmich<[email protected]>
34		* @copyright Copyright belongs to the respective authors
35		* @license http://www.gnu.org/licenses/gpl.html GNU General Public License, version 3 or later
36		*/
37		abstract class AbstractSeeder implements Seeder
38		{
39		/**
40		* connection
41		*
42		* @var Connection $connection
43		*/
44		protected $connection = null;
45
46		/**
47		* factory
48		*
49		* @var SeederFactory $factory
50		*/
51		protected $factory = null;
52
53		/**
54		* AbstractSeeder constructor.
55		*/
56	7	public function __construct()
57		{
58	7	$this->factory = GeneralUtility::makeInstance(
59	7	Factory\SeederFactory::class,
60	7	\TildBJ\Seeder\Factory\FakerFactory::createFaker()
61		);
62	7	}
63
64		/**
65		* setConnection
66		*
67		* @param Connection $connection
68		* @return void
69		*/
70		public function setConnection(Connection $connection)
71		{
72		$this->connection = $connection;
73		}
74
75		/**
76		* preProcess
77		*
78		* @return void
79		*/
80		abstract protected function before();
81
82		/**
83		* after
84		*
85		* @return void
86		*/
87		abstract protected function after();
88
89		/**
90		* seed
91		*
92		* @throws Connection\NotFoundException
93		* @return bool
94		*/
95		final public function seed()
96		{
97		$this->before();
98
99		if (is_null($this->connection)) {
100		throw new Connection\NotFoundException('Connection not found.');
101		}
102
103		/** @var SeedCollection $seedCollection */
104		$seedCollection = GeneralUtility::makeInstance(SeedCollection::class);
105
106		$success = $this->connection->fetch($seedCollection->toArray());
107
108		$this->after();
109
110		return $success;
111		}
112
113	7	protected function getKeys()
114		{
115		/** @var SeedCollection $seedCollection */
116	7	$seedCollection = GeneralUtility::makeInstance(SeedCollection::class);
117
118	7	$keyArray = $seedCollection->get($this);
119	7	if (!is_array($keyArray)) {
120		return '';
121		}
122	7	return implode(',', array_keys($keyArray));
123		}
124
125		/**
126		* @return string
127		*/
128	7	public function getClass()
129		{
130	7	return get_class($this);
131		}
132
133		/**
134		* @param $className
135		* @throws \TYPO3\CMS\Extbase\Object\InvalidClassException
136		* @return string
137		*/
138	7	final protected function call($className)
139		{
140	7	if ($className === $this->getClass()) {
141		throw new \TYPO3\CMS\Extbase\Object\InvalidClassException('Invalid loop detected in ' . $className);
142		}
143		/** @var self $class */
144	7	$class = new $className;
145	7	$class->run();
146	7	$keys = $class->getKeys();
147
148	7	return $keys;
149		}
150		}
151

TildBJ / seeder

Issues (94)

Security Analysis no request data

Classes/AbstractSeeder.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like