EmConfiguration::get() - Code Metrics - Inspection of "[FEATURE] Locale is configurable now" - TildBJ/seeder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d58d53...96e397 )

by Dennis

created 2018-03-19 19:25 UTC

EmConfiguration::get() A

↳ Parent: EmConfiguration

Complexity

Conditions	3
Paths	4

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	10
rs	9.4285
cc	3
eloc	6
nc	4
nop	1

<?php
namespace Dennis\Seeder\Utility;

/***************************************************************
 *
 *  Copyright notice
 *
 *  (c) 2016 Dennis Römmich <[email protected]>
 *
 *  All rights reserved
 *
 *  This script is part of the TYPO3 project. The TYPO3 project is
 *  free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 3 of the License, or
 *  (at your option) any later version.
 *
 *  The GNU General Public License can be found at
 *  http://www.gnu.org/copyleft/gpl.html.
 *
 *  This script is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *
 *  This copyright notice MUST APPEAR in all copies of the script!
 ***************************************************************/

/**
 * Class EmConfiguration
 *
 * @package Dennis\Seeder\Utility
 */
class EmConfiguration
{
    /**
     * pathToFaker
     *
     * @var string $pathToFaker
     */
    public $pathToFaker = 'vendor/fzaninotto/faker/';

    /**
     * @var array $configuration
     */
    protected static $configuration = [];

    /**
     * EmConfiguration constructor.
     */
    public function __construct()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $extConf = unserialize($GLOBALS['TYPO3_CONF_VARS']['EXT']['extConf']['seeder']);

        if (isset($extConf['pathToFaker'])) {
            $this->pathToFaker = $extConf['pathToFaker'];
        }
    }

    /**
     * @param $key
     * @return mixed|string
     */
    public static function get($key)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (empty(self::$configuration)) {
            self::$configuration = unserialize($GLOBALS['TYPO3_CONF_VARS']['EXT']['extConf']['seeder']);
        }
        if (isset(self::$configuration[$key])) {
            return self::$configuration[$key];
        }
        return '';
    }
}


1			<?php
2			namespace Dennis\Seeder\Utility;
3
4			/***************************************************************
5			*
6			* Copyright notice
7			*
8			* (c) 2016 Dennis Römmich <[email protected]>
9			*
10			* All rights reserved
11			*
12			* This script is part of the TYPO3 project. The TYPO3 project is
13			* free software; you can redistribute it and/or modify
14			* it under the terms of the GNU General Public License as published by
15			* the Free Software Foundation; either version 3 of the License, or
16			* (at your option) any later version.
17			*
18			* The GNU General Public License can be found at
19			* http://www.gnu.org/copyleft/gpl.html.
20			*
21			* This script is distributed in the hope that it will be useful,
22			* but WITHOUT ANY WARRANTY; without even the implied warranty of
23			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
24			* GNU General Public License for more details.
25			*
26			* This copyright notice MUST APPEAR in all copies of the script!
27			***************************************************************/
28
29			/**
30			* Class EmConfiguration
31			*
32			* @package Dennis\Seeder\Utility
33			*/
34			class EmConfiguration
35			{
36			/**
37			* pathToFaker
38			*
39			* @var string $pathToFaker
40			*/
41			public $pathToFaker = 'vendor/fzaninotto/faker/';
42
43			/**
44			* @var array $configuration
45			*/
46			protected static $configuration = [];
47
48			/**
49			* EmConfiguration constructor.
50			*/
51			public function __construct()
			0 ignored issues – show Coding Style introduced 2018-01-24 11:47 UTC by Report Bug Copy Issue Report `__construct` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
52			{
53			$extConf = unserialize($GLOBALS['TYPO3_CONF_VARS']['EXT']['extConf']['seeder']);
54
55			if (isset($extConf['pathToFaker'])) {
56			$this->pathToFaker = $extConf['pathToFaker'];
57			}
58			}
59
60			/**
61			* @param $key
62			* @return mixed\|string
63			*/
64			public static function get($key)
			0 ignored issues – show Coding Style introduced 2018-03-19 19:27 UTC by Report Bug Copy Issue Report `get` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
65			{
66			if (empty(self::$configuration)) {
67			self::$configuration = unserialize($GLOBALS['TYPO3_CONF_VARS']['EXT']['extConf']['seeder']);
68			}
69			if (isset(self::$configuration[$key])) {
70			return self::$configuration[$key];
71			}
72			return '';
73			}
74			}
75

TildBJ / seeder

Push — master ( d58d53...96e397 )

EmConfiguration::get() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like