Completed
Pull Request — master (#21)
by Dennis
21:11 queued 02:37
created

DatabaseConnection::__construct()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 7

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 0
CRAP Score 2

Importance

Changes 0
Metric Value
dl 0
loc 7
ccs 0
cts 4
cp 0
rs 10
c 0
b 0
f 0
cc 1
nc 1
nop 2
crap 2
1
<?php
2
3
namespace TildBJ\Seeder\Connection;
4
5
/***************************************************************
6
 *  Copyright notice
7
 *
8
 *  (c) 2016 Dennis Römmich <[email protected]>
9
 *
10
 *  All rights reserved
11
 *
12
 *  This script is part of the TYPO3 project. The TYPO3 project is
13
 *  free software; you can redistribute it and/or modify
14
 *  it under the terms of the GNU General Public License as published by
15
 *  the Free Software Foundation; either version 2 of the License, or
16
 *  (at your option) any later version.
17
 *
18
 *  The GNU General Public License can be found at
19
 *  http://www.gnu.org/copyleft/gpl.html.
20
 *
21
 *  This script is distributed in the hope that it will be useful,
22
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
23
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
24
 *  GNU General Public License for more details.
25
 *
26
 *  This copyright notice MUST APPEAR in all copies of the script!
27
 ***************************************************************/
28
use TildBJ\Seeder\Connection;
29
use TildBJ\Seeder;
30
use TYPO3\CMS\Core\Utility\GeneralUtility;
31
32
/**
33
 * DatabaseConnection
34
 *
35
 * @author Dennis Römmich<[email protected]>
36
 * @copyright Copyright belongs to the respective authors
37
 * @license http://www.gnu.org/licenses/gpl.html GNU General Public License, version 3 or later
38
 */
39
class DatabaseConnection implements Connection
40
{
41
    /**
42
     * fetch
43
     *
44
     * @param array $seedArray
45
     * @throws Seeder\Exception
46
     * @return bool
47
     */
48
    public function fetch(array $seedArray)
49
    {
50
        /** @var \TYPO3\CMS\Core\DataHandling\DataHandler $dataHandler */
51
        $dataHandler = GeneralUtility::makeInstance(\TYPO3\CMS\Core\DataHandling\DataHandler::class);
52
        $GLOBALS['BE_USER']->user['admin'] = true;
53
        $dataHandler->start($seedArray, '');
0 ignored issues
show
Documentation introduced by
'' is of type string, but the function expects a array.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
54
        $dataHandler->process_datamap();
55
        $dataHandler->clear_cacheCmd('pages');
56
57
        return true;
58
    }
59
}
60