DatabaseSeeder::before() - Code Metrics - Inspection of "[TASK] Define more unique vendor name" - TildBJ/seeder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 96e397...a65e1b )

by Dennis

created 2018-03-19 19:51 UTC

DatabaseSeeder::before() A

↳ Parent: DatabaseSeeder

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0
cc	1
eloc	6
nc	1
nop	0

<?php
namespace TildBJ\Seeder\Seeder;

/***************************************************************
 *  Copyright notice
 *
 *  (c) 2016 Dennis Römmich <[email protected]>
 *
 *  All rights reserved
 *
 *  This script is part of the TYPO3 project. The TYPO3 project is
 *  free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 2 of the License, or
 *  (at your option) any later version.
 *
 *  The GNU General Public License can be found at
 *  http://www.gnu.org/copyleft/gpl.html.
 *
 *  This script is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *
 *  This copyright notice MUST APPEAR in all copies of the script!
 ***************************************************************/
use TildBJ\Seeder\AbstractSeeder;
use TildBJ\Seeder\Connection\DatabaseConnection;
use TYPO3\CMS\Core\Utility\GeneralUtility;

/**
 * DatabaseSeeder
 *
 * @author Dennis Römmich<[email protected]>
 * @copyright Copyright belongs to the respective authors
 * @license http://www.gnu.org/licenses/gpl.html GNU General Public License, version 3 or later
 */
abstract class DatabaseSeeder extends AbstractSeeder

{
    /**
     * Initialize Database Connection
     *
     * @return void
     */
    protected function before()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $connection = GeneralUtility::makeInstance(
            DatabaseConnection::class,
            $GLOBALS['TYPO3_DB'],
            GeneralUtility::makeInstance(\TildBJ\Seeder\Message\FlashMessage::class)
        );
        $this->setConnection($connection);
    }

    /**
     * after
     *
     * @return void
     */
    protected function after()
    {
    }
}


1			<?php
2			namespace TildBJ\Seeder\Seeder;
3
4			/***************************************************************
5			* Copyright notice
6			*
7			* (c) 2016 Dennis Römmich <[email protected]>
8			*
9			* All rights reserved
10			*
11			* This script is part of the TYPO3 project. The TYPO3 project is
12			* free software; you can redistribute it and/or modify
13			* it under the terms of the GNU General Public License as published by
14			* the Free Software Foundation; either version 2 of the License, or
15			* (at your option) any later version.
16			*
17			* The GNU General Public License can be found at
18			* http://www.gnu.org/copyleft/gpl.html.
19			*
20			* This script is distributed in the hope that it will be useful,
21			* but WITHOUT ANY WARRANTY; without even the implied warranty of
22			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
23			* GNU General Public License for more details.
24			*
25			* This copyright notice MUST APPEAR in all copies of the script!
26			***************************************************************/
27			use TildBJ\Seeder\AbstractSeeder;
28			use TildBJ\Seeder\Connection\DatabaseConnection;
29			use TYPO3\CMS\Core\Utility\GeneralUtility;
30
31			/**
32			* DatabaseSeeder
33			*
34			* @author Dennis Römmich<[email protected]>
35			* @copyright Copyright belongs to the respective authors
36			* @license http://www.gnu.org/licenses/gpl.html GNU General Public License, version 3 or later
37			*/
38			abstract class DatabaseSeeder extends AbstractSeeder
			0 ignored issues – show Coding Style introduced 2018-01-24 11:47 UTC by Report Bug Copy Issue Report `DatabaseSeeder` does not seem to conform to the naming convention (`^Abstract\|Factory$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
39			{
40			/**
41			* Initialize Database Connection
42			*
43			* @return void
44			*/
45			protected function before()
			0 ignored issues – show Coding Style introduced 2018-01-24 11:47 UTC by Report Bug Copy Issue Report `before` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
46			{
47			$connection = GeneralUtility::makeInstance(
48			DatabaseConnection::class,
49			$GLOBALS['TYPO3_DB'],
50			GeneralUtility::makeInstance(\TildBJ\Seeder\Message\FlashMessage::class)
51			);
52			$this->setConnection($connection);
53			}
54
55			/**
56			* after
57			*
58			* @return void
59			*/
60			protected function after()
61			{
62			}
63			}
64

TildBJ / seeder

Push — master ( 96e397...a65e1b )

DatabaseSeeder::before() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like