None::getRows() - Code Metrics - Inspection of "[TASK] Define more unique vendor name" - TildBJ/seeder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 96e397...a65e1b )

by Dennis

created 2018-03-19 19:51 UTC

None::getRows() A

↳ Parent: None

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php
namespace TildBJ\Seeder\Domain\Model\Column;

/***************************************************************
 *
 *  Copyright notice
 *
 *  (c) 2016 Dennis Römmich <[email protected]>
 *
 *  All rights reserved
 *
 *  This script is part of the TYPO3 project. The TYPO3 project is
 *  free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 3 of the License, or
 *  (at your option) any later version.
 *
 *  The GNU General Public License can be found at
 *  http://www.gnu.org/copyleft/gpl.html.
 *
 *  This script is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *
 *  This copyright notice MUST APPEAR in all copies of the script!
 ***************************************************************/
use TildBJ\Seeder\Domain\Model\Column;

/**
 * Class None
 *
 * @package TildBJ\Seeder\Domain\Model\None
 */
class None extends Column implements NoneInterface
{
    /**
     * @var int
     */
    protected $cols;

    /**
     * @var array
     */
    protected $rows;

    /**
     * Input constructor.
     *
     * @param string $columnName
     * @param $configuration
     */
    public function __construct($columnName, $configuration)
    {
        parent::__construct($columnName);
        $this->cols = $configuration['cols'];
        $this->rows = $configuration['rows'];
    }

    /**
     * @return int
     */
    public function getCols()
    {
        return $this->cols;
    }

    /**
     * @return array
     */
    public function getRows()
    {
        return $this->rows;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


1			<?php
2			namespace TildBJ\Seeder\Domain\Model\Column;
3
4			/***************************************************************
5			*
6			* Copyright notice
7			*
8			* (c) 2016 Dennis Römmich <[email protected]>
9			*
10			* All rights reserved
11			*
12			* This script is part of the TYPO3 project. The TYPO3 project is
13			* free software; you can redistribute it and/or modify
14			* it under the terms of the GNU General Public License as published by
15			* the Free Software Foundation; either version 3 of the License, or
16			* (at your option) any later version.
17			*
18			* The GNU General Public License can be found at
19			* http://www.gnu.org/copyleft/gpl.html.
20			*
21			* This script is distributed in the hope that it will be useful,
22			* but WITHOUT ANY WARRANTY; without even the implied warranty of
23			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
24			* GNU General Public License for more details.
25			*
26			* This copyright notice MUST APPEAR in all copies of the script!
27			***************************************************************/
28			use TildBJ\Seeder\Domain\Model\Column;
29
30			/**
31			* Class None
32			*
33			* @package TildBJ\Seeder\Domain\Model\None
34			*/
35			class None extends Column implements NoneInterface
36			{
37			/**
38			* @var int
39			*/
40			protected $cols;
41
42			/**
43			* @var array
44			*/
45			protected $rows;
46
47			/**
48			* Input constructor.
49			*
50			* @param string $columnName
51			* @param $configuration
52			*/
53			public function __construct($columnName, $configuration)
54			{
55			parent::__construct($columnName);
56			$this->cols = $configuration['cols'];
57			$this->rows = $configuration['rows'];
58			}
59
60			/**
61			* @return int
62			*/
63			public function getCols()
64			{
65			return $this->cols;
66			}
67
68			/**
69			* @return array
70			*/
71			public function getRows()
72			{
73			return $this->rows;
			0 ignored issues – show Bug Best Practice introduced 2018-03-19 19:54 UTC by Report Bug Copy Issue Report The return type of `return $this->rows;` (`array`) is incompatible with the return type declared by the interface `TildBJ\Seeder\Domain\Mod...\TextInterface::getRows` of type `integer`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
74			}
75			}
76

TildBJ / seeder

Push — master ( 96e397...a65e1b )

None::getRows() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like