TableConfiguration - Code Metrics - Inspection of "[TASK] Define more unique vendor name" - TildBJ/seeder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 96e397...a65e1b )

by Dennis

created 2018-03-19 19:51 UTC

TableConfiguration A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	98
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	10
lcom	1
cbo	1
dl	0
loc	98
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Size	Complexity
A	__construct()	10	2
A	getName()	4	1
A	getTitle()	4	1
A	getColumns()	4	1
A	getColumnConfiguration()	15	3
A	getAllTables()	8	2

<?php
namespace TildBJ\Seeder\Provider;

/***************************************************************
 *  Copyright notice
 *
 *  (c) 2016 Dennis Römmich <[email protected]>
 *
 *  All rights reserved
 *
 *  This script is part of the TYPO3 project. The TYPO3 project is
 *  free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 2 of the License, or
 *  (at your option) any later version.
 *
 *  The GNU General Public License can be found at
 *  http://www.gnu.org/copyleft/gpl.html.
 *
 *  This script is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *
 *  This copyright notice MUST APPEAR in all copies of the script!
 ***************************************************************/
use TildBJ\Seeder\Traits;

/**
 * TableConfiguration
 *
 * @author Dennis Römmich<[email protected]>
 * @copyright Copyright belongs to the respective authors
 * @license http://www.gnu.org/licenses/gpl.html GNU General Public License, version 3 or later
 */
class TableConfiguration
{
    use Traits\Language;

    /**
     * extensionConfiguration
     *
     * @var array $tableConfiguration
     */
    protected $tableConfiguration;

    /**
     * table
     *
     * @var string $name
     */
    protected $name;

    /**
     * ExtensionConfigurationUtility constructor.
     *
     * @param $tableName
     */
    public function __construct($tableName)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (!isset($GLOBALS['TCA'][$tableName])) {
            throw new \InvalidArgumentException(
                'Configuration for table ' . $tableName . ' not found!'
            );
        }
        $this->name = $tableName;
        $this->tableConfiguration = $GLOBALS['TCA'][$tableName];
    }

    /**
     * getName
     *
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * getName
     *
     * @return string
     */
    public function getTitle()
    {
        return $this->translate($this->tableConfiguration['ctrl']['title']);
    }

    /**
     * getColumns
     *
     * @return array
     */
    public function getColumns()
    {
        return array_keys($this->tableConfiguration['columns']);
    }

    /**
     * getColumnConfiguration
     *
     * @param string $columnName
     * @return array
     */
    public function getColumnConfiguration($columnName)
    {
        if (!is_string($columnName)) {
            throw new \InvalidArgumentException(
                'Columns must be type of string. Type of ' . gettype($columnName) . ' given.'
            );
        }
        if (!isset($this->tableConfiguration['columns'][$columnName])) {
            throw new \InvalidArgumentException(
                'Column ' . $columnName . ' does not exist for table ' . $this->name
            );
        }

        return array($columnName => $this->tableConfiguration['columns'][$columnName]['config']);
    }

    /**
     * @return array
     */
    public static function getAllTables()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $tables = array();
        foreach (array_keys($GLOBALS['TCA']) as $tableName) {
            $tables[$tableName] = $tableName;
        }
        return $tables;
    }
}


1			<?php
2			namespace TildBJ\Seeder\Provider;
3
4			/***************************************************************
5			* Copyright notice
6			*
7			* (c) 2016 Dennis Römmich <[email protected]>
8			*
9			* All rights reserved
10			*
11			* This script is part of the TYPO3 project. The TYPO3 project is
12			* free software; you can redistribute it and/or modify
13			* it under the terms of the GNU General Public License as published by
14			* the Free Software Foundation; either version 2 of the License, or
15			* (at your option) any later version.
16			*
17			* The GNU General Public License can be found at
18			* http://www.gnu.org/copyleft/gpl.html.
19			*
20			* This script is distributed in the hope that it will be useful,
21			* but WITHOUT ANY WARRANTY; without even the implied warranty of
22			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
23			* GNU General Public License for more details.
24			*
25			* This copyright notice MUST APPEAR in all copies of the script!
26			***************************************************************/
27			use TildBJ\Seeder\Traits;
28
29			/**
30			* TableConfiguration
31			*
32			* @author Dennis Römmich<[email protected]>
33			* @copyright Copyright belongs to the respective authors
34			* @license http://www.gnu.org/licenses/gpl.html GNU General Public License, version 3 or later
35			*/
36			class TableConfiguration
37			{
38			use Traits\Language;
39
40			/**
41			* extensionConfiguration
42			*
43			* @var array $tableConfiguration
44			*/
45			protected $tableConfiguration;
46
47			/**
48			* table
49			*
50			* @var string $name
51			*/
52			protected $name;
53
54			/**
55			* ExtensionConfigurationUtility constructor.
56			*
57			* @param $tableName
58			*/
59			public function __construct($tableName)
			0 ignored issues – show Coding Style introduced 2018-01-24 11:47 UTC by Report Bug Copy Issue Report `__construct` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
60			{
61			if (!isset($GLOBALS['TCA'][$tableName])) {
62			throw new \InvalidArgumentException(
63			'Configuration for table ' . $tableName . ' not found!'
64			);
65			}
66			$this->name = $tableName;
67			$this->tableConfiguration = $GLOBALS['TCA'][$tableName];
68			}
69
70			/**
71			* getName
72			*
73			* @return string
74			*/
75			public function getName()
76			{
77			return $this->name;
78			}
79
80			/**
81			* getName
82			*
83			* @return string
84			*/
85			public function getTitle()
86			{
87			return $this->translate($this->tableConfiguration['ctrl']['title']);
88			}
89
90			/**
91			* getColumns
92			*
93			* @return array
94			*/
95			public function getColumns()
96			{
97			return array_keys($this->tableConfiguration['columns']);
98			}
99
100			/**
101			* getColumnConfiguration
102			*
103			* @param string $columnName
104			* @return array
105			*/
106			public function getColumnConfiguration($columnName)
107			{
108			if (!is_string($columnName)) {
109			throw new \InvalidArgumentException(
110			'Columns must be type of string. Type of ' . gettype($columnName) . ' given.'
111			);
112			}
113			if (!isset($this->tableConfiguration['columns'][$columnName])) {
114			throw new \InvalidArgumentException(
115			'Column ' . $columnName . ' does not exist for table ' . $this->name
116			);
117			}
118
119			return array($columnName => $this->tableConfiguration['columns'][$columnName]['config']);
120			}
121
122			/**
123			* @return array
124			*/
125			public static function getAllTables()
			0 ignored issues – show Coding Style introduced 2018-01-24 11:47 UTC by Report Bug Copy Issue Report `getAllTables` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
126			{
127			$tables = array();
128			foreach (array_keys($GLOBALS['TCA']) as $tableName) {
129			$tables[$tableName] = $tableName;
130			}
131			return $tables;
132			}
133			}
134

TildBJ / seeder

Push — master ( 96e397...a65e1b )

TableConfiguration A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

Duplication Side-by-Side

Filter issues like