Dennis\Seeder\Factory\SeederFactory

Complexity

Total Complexity

7

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	create()	0	4	1
A	make()	0	4	1
B	makeOrCreate()	0	22	4

<?php
namespace Dennis\Seeder\Factory;

/***************************************************************
 *
 *  Copyright notice
 *
 *  (c) 2016 Dennis Römmich <dennis@roemmich.eu>
 *
 *  All rights reserved
 *
 *  This script is part of the TYPO3 project. The TYPO3 project is
 *  free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 3 of the License, or
 *  (at your option) any later version.
 *
 *  The GNU General Public License can be found at
 *  http://www.gnu.org/copyleft/gpl.html.
 *
 *  This script is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *
 *  This copyright notice MUST APPEAR in all copies of the script!
 ***************************************************************/
use Dennis\Seeder;
use TYPO3\CMS\Core\Utility\GeneralUtility;

/**
 * Class SeederFactory
 *
 * @package Dennis\Seeder\Factory\SeederFactory
 */
class SeederFactory implements \Dennis\Seeder\SeederFactory, \TYPO3\CMS\Core\SingletonInterface
{
    /**
     * @var Seeder\Faker
     */
    protected $faker;

    public function __construct(Seeder\Faker $faker)
    {
        $this->faker = $faker;
    }

    /**
     * Creates a new SeedCollection
     *
     * @param string $name
     * @param int $limit
     * @return Seeder\SeedCollection
     */
    public function create($name, $limit = 1)
    {
        return $this->makeOrCreate($name, $limit);
    }

    /**
     * @param $name
     * @param int $limit
     * @return Seeder\SeedCollection|mixed

Consider making the return type a bit more specific; maybe use Seeder\SeedCollection.

     */
    public function make($name, $limit = 1)
    {
        return $this->makeOrCreate($name, $limit, false);
    }

    /**
     * @param $name
     * @param int $limit
     * @param bool $create
     */
    protected function makeOrCreate($name, $limit = 1, $create = true)
    {
        /** @var Seeder\Provider\TableConfiguration $tableConfiguration */
        $tableConfiguration = GeneralUtility::makeInstance(Seeder\Provider\TableConfiguration::class, $name);
        /** @var Seeder\SeedCollection $seedCollection */
        $seedCollection = GeneralUtility::makeInstance(Seeder\Collection\SeedCollection::class);

        for ($i = 1; $i <= $limit; $i++) {
            $calledClass = debug_backtrace(false, 3)[2];
            if ($create || !$seed = $seedCollection->random($calledClass['class'], $i)) {
                /** @var Seeder\Seed $seed */
                $seed = GeneralUtility::makeInstance(Seeder\Domain\Model\Seed::class);
                $seed->setTarget($name)
                    ->setTitle($calledClass['class'])
                    ->setProperties($tableConfiguration->getColumns());
            }
            $seedCollection->attach($seed);
            $seedCollection->amount = $limit;

Accessing amount on the interface Dennis\Seeder\SeedCollection suggest that you code against a concrete implementation. How about adding an instanceof check?

        }

        return $seedCollection;
    }
}