TableFactory::getColumn() - Code Metrics - TildBJ/seeder - Measure and Improve Code Quality continuously with Scrutinizer

TableFactory::getColumn() C
last analyzed 2018-11-16 08:00 UTC

↳ Parent: TableFactory

Complexity

Conditions	12
Paths	12

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	156

Importance

Changes

Metric	Value
dl	0
loc	37
ccs	0
cts	32
cp	0
rs	6.9666
c	0
b	0
f	0
cc	12
nc	12
nop	2
crap	156

How to fix Complexity

<?php
namespace TildBJ\Seeder\Factory;

/***************************************************************
 *
 *  Copyright notice
 *
 *  (c) 2016 Dennis Römmich <[email protected]>
 *
 *  All rights reserved
 *
 *  This script is part of the TYPO3 project. The TYPO3 project is
 *  free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 3 of the License, or
 *  (at your option) any later version.
 *
 *  The GNU General Public License can be found at
 *  http://www.gnu.org/copyleft/gpl.html.
 *
 *  This script is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *
 *  This copyright notice MUST APPEAR in all copies of the script!
 ***************************************************************/
use TildBJ\Seeder\Provider\TableConfiguration;
use TildBJ\Seeder\Domain\Model;
use TYPO3\CMS\Core\Utility\GeneralUtility;

/**
 * Class TableFactory
 *
 * @package TildBJ\Seeder\Factory\TableFactory
 */
class TableFactory implements \TYPO3\CMS\Core\SingletonInterface

{
    /**
     * @var array $tables
     */
    protected static $tables = [];

    /**
     * @var array $columns
     */
    protected static $columns = [];

    /**
     * Provides a Table
     *
     * @param string $tableName
     * @return Model\TableInterface
     */
    public static function createTable($tableName)
    {
        /** @var TableConfiguration $tableConfiguration */
        $tableConfiguration = GeneralUtility::makeInstance(TableConfiguration::class, $tableName);
        if (!in_array($tableName, self::$tables)) {
            self::$tables[$tableName] = new Model\Table($tableConfiguration);
        }

        return self::$tables[$tableName];
    }

    /**
     * createColumn
     *
     * @param string $tableName
     * @param string $columnName
     * @return Model\ColumnInterface
     */
    public static function createColumn($tableName, $columnName)
    {
        $tableConfiguration = new TableConfiguration($tableName);
        $columnConfiguration = $tableConfiguration->getColumnConfiguration($columnName);
        $key = $tableName . '.' . key($columnConfiguration);
        if (!in_array($key, self::$columns)) {
            self::$columns[$key] = self::getColumn($columnName, $columnConfiguration[key($columnConfiguration)]);
        }

        return self::$columns[$key];
    }

    /**
     * @param string $columnName
     * @param array $configuration
     * @return Model\ColumnInterface
     */
    protected static function getColumn($columnName, $configuration)
    {
        $column = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        switch ($configuration['type']) {
            case 'input':
                $column = new Model\Column\Input($columnName, $configuration);
                break;
            case 'text':
                $column = new Model\Column\Text($columnName, $configuration);
                break;
            case 'check':
                $column = new Model\Column\Check($columnName, $configuration);
                break;
            case 'radio':
                $column = new Model\Column\Radio($columnName, $configuration);
                break;
            case 'select':
                $column = new Model\Column\Select($columnName, $configuration);
                break;
            case 'group':
                $column = new Model\Column\Group($columnName, $configuration);
                break;
            case 'none':
                $column = new Model\Column\None($columnName, $configuration);
                break;
            case 'inline':
                $column = new Model\Column\Inline($columnName, $configuration);
                break;
            case 'passthrough':
            case 'user':
            case 'flex':
            default:
                $column = new Model\Column\None($columnName, $configuration);
        }

        return $column;
    }
}


1			<?php
2			namespace TildBJ\Seeder\Factory;
3
4			/***************************************************************
5			*
6			* Copyright notice
7			*
8			* (c) 2016 Dennis Römmich <[email protected]>
9			*
10			* All rights reserved
11			*
12			* This script is part of the TYPO3 project. The TYPO3 project is
13			* free software; you can redistribute it and/or modify
14			* it under the terms of the GNU General Public License as published by
15			* the Free Software Foundation; either version 3 of the License, or
16			* (at your option) any later version.
17			*
18			* The GNU General Public License can be found at
19			* http://www.gnu.org/copyleft/gpl.html.
20			*
21			* This script is distributed in the hope that it will be useful,
22			* but WITHOUT ANY WARRANTY; without even the implied warranty of
23			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
24			* GNU General Public License for more details.
25			*
26			* This copyright notice MUST APPEAR in all copies of the script!
27			***************************************************************/
28			use TildBJ\Seeder\Provider\TableConfiguration;
29			use TildBJ\Seeder\Domain\Model;
30			use TYPO3\CMS\Core\Utility\GeneralUtility;
31
32			/**
33			* Class TableFactory
34			*
35			* @package TildBJ\Seeder\Factory\TableFactory
36			*/
37			class TableFactory implements \TYPO3\CMS\Core\SingletonInterface
			0 ignored issues – show Coding Style introduced 2018-01-24 11:47 UTC by Report Bug Copy Issue Report `TableFactory` does not seem to conform to the naming convention (`Utils?$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
38			{
39			/**
40			* @var array $tables
41			*/
42			protected static $tables = [];
43
44			/**
45			* @var array $columns
46			*/
47			protected static $columns = [];
48
49			/**
50			* Provides a Table
51			*
52			* @param string $tableName
53			* @return Model\TableInterface
54			*/
55			public static function createTable($tableName)
56			{
57			/** @var TableConfiguration $tableConfiguration */
58			$tableConfiguration = GeneralUtility::makeInstance(TableConfiguration::class, $tableName);
59			if (!in_array($tableName, self::$tables)) {
60			self::$tables[$tableName] = new Model\Table($tableConfiguration);
61			}
62
63			return self::$tables[$tableName];
64			}
65
66			/**
67			* createColumn
68			*
69			* @param string $tableName
70			* @param string $columnName
71			* @return Model\ColumnInterface
72			*/
73			public static function createColumn($tableName, $columnName)
74			{
75			$tableConfiguration = new TableConfiguration($tableName);
76			$columnConfiguration = $tableConfiguration->getColumnConfiguration($columnName);
77			$key = $tableName . '.' . key($columnConfiguration);
78			if (!in_array($key, self::$columns)) {
79			self::$columns[$key] = self::getColumn($columnName, $columnConfiguration[key($columnConfiguration)]);
80			}
81
82			return self::$columns[$key];
83			}
84
85			/**
86			* @param string $columnName
87			* @param array $configuration
88			* @return Model\ColumnInterface
89			*/
90			protected static function getColumn($columnName, $configuration)
91			{
92			$column = null;
			0 ignored issues – show Unused Code introduced 2018-01-24 11:47 UTC by Report Bug Copy Issue Report `$column` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
93			switch ($configuration['type']) {
94			case 'input':
95			$column = new Model\Column\Input($columnName, $configuration);
96			break;
97			case 'text':
98			$column = new Model\Column\Text($columnName, $configuration);
99			break;
100			case 'check':
101			$column = new Model\Column\Check($columnName, $configuration);
102			break;
103			case 'radio':
104			$column = new Model\Column\Radio($columnName, $configuration);
105			break;
106			case 'select':
107			$column = new Model\Column\Select($columnName, $configuration);
108			break;
109			case 'group':
110			$column = new Model\Column\Group($columnName, $configuration);
111			break;
112			case 'none':
113			$column = new Model\Column\None($columnName, $configuration);
114			break;
115			case 'inline':
116			$column = new Model\Column\Inline($columnName, $configuration);
117			break;
118			case 'passthrough':
119			case 'user':
120			case 'flex':
121			default:
122			$column = new Model\Column\None($columnName, $configuration);
123			}
124
125			return $column;
126			}
127			}
128

TildBJ / seeder

TableFactory::getColumn() C last analyzed 2018-11-16 08:00 UTC

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like

TableFactory::getColumn() C
last analyzed 2018-11-16 08:00 UTC