Element::initializeFrom() - Code Metrics - ThrusterIO/xml-iterator - Measure and Improve Code Quality continuously with Scrutinizer

Element::initializeFrom() A
last analyzed 2016-09-22 13:16 UTC

↳ Parent: Element

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2.351

Importance

Changes

Metric	Value
dl	0
loc	14
ccs	5
cts	9
cp	0.5556
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	8
nc	2
nop	1
crap	2.351

<?php

namespace Thruster\Component\XMLIterator;

use RuntimeException;

/**
 * Class Element
 *
 * @package Thruster\Component\XMLIterator
 * @author  Aurimas Niekis <[email protected]>
 */
class Element extends Node
{
    private $name_;
    private $attributes_;

    public function __construct(XMLReader $reader)
    {
        parent::__construct($reader);

        $this->initializeFrom($reader);
    }

    public function getXMLElementAround($innerXML = '')
    {
        return XMLBuild::wrapTag($this->name_, $this->attributes_, $innerXML);
    }

    public function getAttributes()
    {
        return $this->attributes_;
    }

    public function getAttribute(string $name, $default = null)
    {
        return $this->attributes_[$name] ?? $default;
    }

    public function __toString()
    {
        return $this->name_;
    }

    private function initializeFrom(XMLReader $reader)
    {
        if ($reader->nodeType !== XMLReader::ELEMENT) {
            $node = new Node($reader);

            throw new RuntimeException(sprintf(
                'Reader must be at an XMLReader::ELEMENT, is XMLReader::%s given.',
                $node->getNodeTypeName()
            ));
        }

        $this->name_       = $reader->name;
        $this->attributes_ = parent::getAttributes()->getArrayCopy();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }
}


1		<?php
2
3		namespace Thruster\Component\XMLIterator;
4
5		use RuntimeException;
6
7		/**
8		* Class Element
9		*
10		* @package Thruster\Component\XMLIterator
11		* @author Aurimas Niekis <[email protected]>
12		*/
13		class Element extends Node
14		{
15		private $name_;
16		private $attributes_;
17
18	18	public function __construct(XMLReader $reader)
19		{
20	18	parent::__construct($reader);
21
22	18	$this->initializeFrom($reader);
23	18	}
24
25	1	public function getXMLElementAround($innerXML = '')
26		{
27	1	return XMLBuild::wrapTag($this->name_, $this->attributes_, $innerXML);
28		}
29
30		public function getAttributes()
31		{
32		return $this->attributes_;
33		}
34
35		public function getAttribute(string $name, $default = null)
36		{
37		return $this->attributes_[$name] ?? $default;
38		}
39
40		public function __toString()
41		{
42		return $this->name_;
43		}
44
45	18	private function initializeFrom(XMLReader $reader)
46		{
47	18	if ($reader->nodeType !== XMLReader::ELEMENT) {
48		$node = new Node($reader);
49
50		throw new RuntimeException(sprintf(
51		'Reader must be at an XMLReader::ELEMENT, is XMLReader::%s given.',
52		$node->getNodeTypeName()
53		));
54		}
55
56	18	$this->name_ = $reader->name;
57	18	$this->attributes_ = parent::getAttributes()->getArrayCopy();
		0 ignored issues – show Comprehensibility Bug introduced 2016-09-22 13:16 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getAttributes()` instead of `initializeFrom()`). Are you sure this is correct? If so, you might want to change this to `$this->getAttributes()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
58	18	}
59		}
60

ThrusterIO / xml-iterator

Element::initializeFrom() A last analyzed 2016-09-22 13:16 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

Element::initializeFrom() A
last analyzed 2016-09-22 13:16 UTC