Thruster\Component\XMLIterator\ChildElementIterator

Complexity

Total Complexity

14

Size/Duplication

Total Lines	97
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	rewind()	0	19	3
B	next()	0	14	5
A	valid()	0	8	2
A	current()	0	6	2
A	key()	0	4	1

<?php

namespace Thruster\Component\XMLIterator;

use UnexpectedValueException;

/**
 * Class ChildElementIterator
 *
 * @package Thruster\Component\XMLIterator
 * @author  Aurimas Niekis <aurimas@niekis.lt>
 */
class ChildElementIterator extends ElementIterator
{
    /**
     * @var int
     */
    private $stopDepth;

    /**
     * @var bool
     */
    private $descendTree;

    /**
     * @var bool
     */
    private $didRewind;

Consider using a different property name as you override a private property of the parent class.

    /**
     * @var int
     */
    private $index;

Consider using a different property name as you override a private property of the parent class.

    /**
     * @inheritdoc
     *
     * @param bool $descendantAxis traverse children of children
     */
    public function __construct(XMLReader $reader, $name = null, bool $descendantAxis = false)
    {
        parent::__construct($reader, $name);

        $this->descendTree = $descendantAxis;
    }

    /**
     * @throws UnexpectedValueException
     * @return void
     */
    public function rewind()
    {
        // this iterator can not really rewind. instead it places itself onto the
        // first children.
        if ($this->reader->nodeType === XMLReader::NONE) {
            $this->moveToNextElement();
        }

        if ($this->stopDepth === null) {
            $this->stopDepth = $this->reader->depth;
        }

        // move to first child - if any
        parent::next();

It seems like you call parent on a different method (next() instead of rewind()). Are you sure this is correct? If so, you might want to change this to $this->next().

        parent::rewind();

        $this->index     = 0;
        $this->didRewind = true;
    }

    public function next()
    {
        if ($this->valid()) {
            $this->index++;
        }

        while ($this->valid()) {
            parent::next();

            if ($this->descendTree || $this->reader->depth === $this->stopDepth + 1) {
                break;
            }
        };
    }

    public function valid()
    {
        if (!($valid = parent::valid())) {
            return $valid;
        }

        return $this->reader->depth > $this->stopDepth;
    }

    /**
     * @return Node
     */
    public function current()
    {
        $this->didRewind || self::rewind();

        return parent::current();
    }

    public function key()
    {
        return $this->index;
    }
}