Controller::view() - Code Metrics - Inspection of "Moved out ->view method to Trait" - ThrusterIO/view-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8ae3e6...6d116a )

by Aurimas

created 2018-05-04 15:05 UTC

Controller::view() A

↳ Parent: Controller

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	0
cts	11
cp	0
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	2
crap	6

<?php

namespace Thruster\Bundle\ViewBundle\Controller;

use Symfony\Bundle\FrameworkBundle\Controller\Controller as BaseController;
use Symfony\Component\HttpFoundation\JsonResponse;
use Thruster\Bundle\ViewBundle\Traits\ViewAwareTrait;

class Controller extends BaseController
{
    use ViewAwareTrait;

    /**
     * @param string $view  A short notation view (a:b:c) "AppBundle:Default:homepage" or "homepage"
     *                      (for same name view class as controller under View folder with suffix View instead of
     *                      Controller for e.g. For AppBundle\Controller\DefaultController AppBundle\View\DefaultView
     * @param mixed  $data
     * @param int    $status
     * @param array  $headers
     * @param array  $context
     *
     * @return JsonResponse
     * @throws \InvalidArgumentException
     */
    protected function jsonView($view, $data, $status = 200, $headers = [], $context = [])
    {
        $data = $this->view($view, $data);

        return parent::json($data, $status, $headers, $context);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }
}


1			<?php
2
3			namespace Thruster\Bundle\ViewBundle\Controller;
4
5			use Symfony\Bundle\FrameworkBundle\Controller\Controller as BaseController;
6			use Symfony\Component\HttpFoundation\JsonResponse;
7			use Thruster\Bundle\ViewBundle\Traits\ViewAwareTrait;
8
9			class Controller extends BaseController
10			{
11			use ViewAwareTrait;
12
13			/**
14			* @param string $view A short notation view (a:b:c) "AppBundle:Default:homepage" or "homepage"
15			* (for same name view class as controller under View folder with suffix View instead of
16			* Controller for e.g. For AppBundle\Controller\DefaultController AppBundle\View\DefaultView
17			* @param mixed $data
18			* @param int $status
19			* @param array $headers
20			* @param array $context
21			*
22			* @return JsonResponse
23			* @throws \InvalidArgumentException
24			*/
25			protected function jsonView($view, $data, $status = 200, $headers = [], $context = [])
26			{
27			$data = $this->view($view, $data);
28
29			return parent::json($data, $status, $headers, $context);
			0 ignored issues – show Comprehensibility Bug introduced 2016-07-05 13:55 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`json()` instead of `jsonView()`). Are you sure this is correct? If so, you might want to change this to `$this->json()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
30			}
31			}
32

ThrusterIO / view-bundle

Push — master ( 8ae3e6...6d116a )

Controller::view() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like