Issues in StreamEncryption.php (master) - Issues in master - ThrusterIO/socket-client - Measure and Improve Code Quality continuously with Scrutinizer

Issues (6)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/StreamEncryption.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Thruster\Component\SocketClient;

use Thruster\Component\EventLoop\EventLoopInterface;
use Thruster\Component\Promise\Deferred;
use Thruster\Component\Stream\Stream;
use UnexpectedValueException;

/**
 * Class StreamEncryption
 *
 * @package Thruster\Component\SocketClient
 * @author  Aurimas Niekis <[email protected]>
 */
class StreamEncryption
{
    /**
     * @var EventLoopInterface
     */
    private $loop;

    /**
     * @var int
     */
    private $method;

    /**
     * @var string
     */
    private $errStr;

    /**
     * @var int
     */
    private $errno;

    /**
     * @var bool
     */
    private $wrapSecure;

    public function __construct(EventLoopInterface $loop)
    {
        $this->method     = STREAM_CRYPTO_METHOD_TLS_CLIENT;
        $this->wrapSecure = false;

        $this->loop = $loop;

        if (defined('STREAM_CRYPTO_METHOD_TLSv1_0_CLIENT')) {
            $this->method |= STREAM_CRYPTO_METHOD_TLSv1_0_CLIENT;
        }
        if (defined('STREAM_CRYPTO_METHOD_TLSv1_1_CLIENT')) {
            $this->method |= STREAM_CRYPTO_METHOD_TLSv1_1_CLIENT;
        }
        if (defined('STREAM_CRYPTO_METHOD_TLSv1_2_CLIENT')) {
            $this->method |= STREAM_CRYPTO_METHOD_TLSv1_2_CLIENT;
        }
    }

    public function enable(Stream $stream)
    {
        return $this->toggle($stream, true);
    }

    public function disable(Stream $stream)
    {
        return $this->toggle($stream, false);
    }

    public function toggle(Stream $stream, $toggle)
    {
        if ($stream instanceof SecureStream) {
            $stream = $stream->getDecorating();
        }

        // pause actual stream instance to continue operation on raw stream socket
        $stream->pause();

        // TODO: add write() event to make sure we're not sending any excessive data

        $deferred = new Deferred();

        // get actual stream socket from stream instance
        $socket = $stream->getStream();

        $toggleCrypto = function () use ($socket, $deferred, $toggle) {
            $this->toggleCrypto($socket, $deferred, $toggle);
        };

        $this->loop->addReadStream($socket, $toggleCrypto);
        $toggleCrypto();

        return $deferred->promise()->then(function () use ($stream, $toggle) {
            if ($toggle && $this->wrapSecure) {
                return new SecureStream($stream, $this->loop);
            }

            $stream->resume();

            return $stream;
        }, function ($error) use ($stream) {
            $stream->resume();
            throw $error;
        });
    }

    public function toggleCrypto($socket, Deferred $deferred, $toggle)
    {
        //set_error_handler([$this, 'handleError']);
        $result = stream_socket_enable_crypto($socket, $toggle, $this->method);
        //restore_error_handler();

        if (true === $result) {
            $this->loop->removeReadStream($socket);

            $deferred->resolve();
        } elseif (false === $result) {
            $this->loop->removeReadStream($socket);

            $deferred->reject(new UnexpectedValueException(
                sprintf('Unable to complete SSL/TLS handshake: %s', $this->errStr),
                $this->errno
            ));
        } else {
            // need more data, will retry
        }
    }

    public function handleError($errNo, $errStr)
    {
        $this->errstr = str_replace(["\r", "\n"], ' ', $errStr);

        $this->errno  = $errNo;
    }
}


1		<?php
2
3		namespace Thruster\Component\SocketClient;
4
5		use Thruster\Component\EventLoop\EventLoopInterface;
6		use Thruster\Component\Promise\Deferred;
7		use Thruster\Component\Stream\Stream;
8		use UnexpectedValueException;
9
10		/**
11		* Class StreamEncryption
12		*
13		* @package Thruster\Component\SocketClient
14		* @author Aurimas Niekis <[email protected]>
15		*/
16		class StreamEncryption
17		{
18		/**
19		* @var EventLoopInterface
20		*/
21		private $loop;
22
23		/**
24		* @var int
25		*/
26		private $method;
27
28		/**
29		* @var string
30		*/
31		private $errStr;
32
33		/**
34		* @var int
35		*/
36		private $errno;
37
38		/**
39		* @var bool
40		*/
41		private $wrapSecure;
42
43	1	public function __construct(EventLoopInterface $loop)
44		{
45	1	$this->method = STREAM_CRYPTO_METHOD_TLS_CLIENT;
46	1	$this->wrapSecure = false;
47
48	1	$this->loop = $loop;
49
50	1	if (defined('STREAM_CRYPTO_METHOD_TLSv1_0_CLIENT')) {
51	1	$this->method \|= STREAM_CRYPTO_METHOD_TLSv1_0_CLIENT;
52		}
53	1	if (defined('STREAM_CRYPTO_METHOD_TLSv1_1_CLIENT')) {
54	1	$this->method \|= STREAM_CRYPTO_METHOD_TLSv1_1_CLIENT;
55		}
56	1	if (defined('STREAM_CRYPTO_METHOD_TLSv1_2_CLIENT')) {
57	1	$this->method \|= STREAM_CRYPTO_METHOD_TLSv1_2_CLIENT;
58		}
59	1	}
60
61	1	public function enable(Stream $stream)
62		{
63	1	return $this->toggle($stream, true);
64		}
65
66		public function disable(Stream $stream)
67		{
68		return $this->toggle($stream, false);
69		}
70
71	1	public function toggle(Stream $stream, $toggle)
72		{
73	1	if ($stream instanceof SecureStream) {
74		$stream = $stream->getDecorating();
75		}
76
77		// pause actual stream instance to continue operation on raw stream socket
78	1	$stream->pause();
79
80		// TODO: add write() event to make sure we're not sending any excessive data
81
82	1	$deferred = new Deferred();
83
84		// get actual stream socket from stream instance
85	1	$socket = $stream->getStream();
86
87		$toggleCrypto = function () use ($socket, $deferred, $toggle) {
88	1	$this->toggleCrypto($socket, $deferred, $toggle);
89	1	};
90
91	1	$this->loop->addReadStream($socket, $toggleCrypto);
92	1	$toggleCrypto();
93
94		return $deferred->promise()->then(function () use ($stream, $toggle) {
95	1	if ($toggle && $this->wrapSecure) {
96		return new SecureStream($stream, $this->loop);
97		}
98
99	1	$stream->resume();
100
101	1	return $stream;
102	1	}, function ($error) use ($stream) {
103		$stream->resume();
104		throw $error;
105	1	});
106		}
107
108	1	public function toggleCrypto($socket, Deferred $deferred, $toggle)
109		{
110		//set_error_handler([$this, 'handleError']);
111	1	$result = stream_socket_enable_crypto($socket, $toggle, $this->method);
112		//restore_error_handler();
113
114	1	if (true === $result) {
115	1	$this->loop->removeReadStream($socket);
116
117	1	$deferred->resolve();
118	1	} elseif (false === $result) {
119		$this->loop->removeReadStream($socket);
120
121		$deferred->reject(new UnexpectedValueException(
122		sprintf('Unable to complete SSL/TLS handshake: %s', $this->errStr),
123		$this->errno
124		));
125		} else {
126		// need more data, will retry
127		}
128	1	}
129
130		public function handleError($errNo, $errStr)
131		{
132		$this->errstr = str_replace(["\r", "\n"], ' ', $errStr);
		0 ignored issues – show Bug introduced 2016-01-24 18:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `errstr` does not seem to exist. Did you mean `errStr`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
133		$this->errno = $errNo;
134		}
135		}
136

ThrusterIO / socket-client

Issues (6)

Security Analysis no request data

src/StreamEncryption.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like