Issues in PumpStream.php (master) - Issues in master - ThrusterIO/http-message - Measure and Improve Code Quality continuously with Scrutinizer

Issues (57)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/PumpStream.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Thruster\Component\HttpMessage;

use Psr\Http\Message\StreamInterface;

/**
 * Class PumpStream
 *
 * @package Thruster\Component\HttpMessage
 * @author  Aurimas Niekis <[email protected]>
 */
class PumpStream implements StreamInterface
{
    /**
     * @var callable
     */
    private $source;

    /**
     * @var int
     */
    private $size;

    /**
     * @var int
     */
    private $tellPos;

    /**
     * @var array
     */
    private $metadata;

    /**
     * @var BufferStream
     */
    private $buffer;

    /**
     * @param callable $source Source of the stream data. The callable MAY
     *                         accept an integer argument used to control the
     *                         amount of data to return. The callable MUST
     *                         return a string when called, or false on error
     *                         or EOF.
     * @param array $options   Stream options:
     *                         - metadata: Hash of metadata to use with stream.
     *                         - size: Size of the stream, if known.
     */
    public function __construct(callable $source, array $options = [])
    {
        $this->tellPos = 0;
        $this->source = $source;
        $this->size = $options['size'] ?? null;
        $this->metadata = $options['metadata'] ?? [];
        $this->buffer = new BufferStream();
    }

    public function __toString()
    {
        try {
            return copy_to_string($this);
        } catch (\Exception $e) {
            return '';
        }
    }

    public function close()
    {
        $this->detach();
    }

    public function detach()
    {
        $this->tellPos = false;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $this->source = null;
    }

    public function getSize()
    {
        return $this->size;
    }

    public function tell()
    {
        return $this->tellPos;
    }

    public function eof() : bool
    {
        return !$this->source;
    }

    public function isSeekable() : bool
    {
        return false;
    }

    public function rewind()
    {
        $this->seek(0);
    }

    public function seek($offset, $whence = SEEK_SET)
    {
        throw new \RuntimeException('Cannot seek a PumpStream');
    }

    public function isWritable() : bool
    {
        return false;
    }

    public function write($string)
    {
        throw new \RuntimeException('Cannot write to a PumpStream');
    }

    public function isReadable() : bool
    {
        return true;
    }

    public function read($length)
    {
        $data = $this->buffer->read($length);
        $readLen = strlen($data);
        $this->tellPos += $readLen;
        $remaining = $length - $readLen;

        if ($remaining) {
            $this->pump($remaining);
            $data .= $this->buffer->read($remaining);
            $this->tellPos += strlen($data) - $readLen;
        }

        return $data;
    }

    public function getContents()
    {
        $result = '';
        while (!$this->eof()) {
            $result .= $this->read(1000000);
        }

        return $result;
    }

    public function getMetadata($key = null)
    {
        if (!$key) {
            return $this->metadata;
        }

        return isset($this->metadata[$key]) ? $this->metadata[$key] : null;
    }

    private function pump($length)
    {
        if ($this->source) {
            do {
                $data = call_user_func($this->source, $length);
                if ($data === false || $data === null) {
                    $this->source = null;
                    return;
                }
                $this->buffer->write($data);
                $length -= strlen($data);
            } while ($length > 0);
        }
    }
}


1		<?php
2
3		namespace Thruster\Component\HttpMessage;
4
5		use Psr\Http\Message\StreamInterface;
6
7		/**
8		* Class PumpStream
9		*
10		* @package Thruster\Component\HttpMessage
11		* @author Aurimas Niekis <[email protected]>
12		*/
13		class PumpStream implements StreamInterface
14		{
15		/**
16		* @var callable
17		*/
18		private $source;
19
20		/**
21		* @var int
22		*/
23		private $size;
24
25		/**
26		* @var int
27		*/
28		private $tellPos;
29
30		/**
31		* @var array
32		*/
33		private $metadata;
34
35		/**
36		* @var BufferStream
37		*/
38		private $buffer;
39
40		/**
41		* @param callable $source Source of the stream data. The callable MAY
42		* accept an integer argument used to control the
43		* amount of data to return. The callable MUST
44		* return a string when called, or false on error
45		* or EOF.
46		* @param array $options Stream options:
47		* - metadata: Hash of metadata to use with stream.
48		* - size: Size of the stream, if known.
49		*/
50	5	public function __construct(callable $source, array $options = [])
51		{
52	5	$this->tellPos = 0;
53	5	$this->source = $source;
54	5	$this->size = $options['size'] ?? null;
55	5	$this->metadata = $options['metadata'] ?? [];
56	5	$this->buffer = new BufferStream();
57	5	}
58
59	1	public function __toString()
60		{
61		try {
62	1	return copy_to_string($this);
63		} catch (\Exception $e) {
64		return '';
65		}
66		}
67
68	1	public function close()
69		{
70	1	$this->detach();
71	1	}
72
73	1	public function detach()
74		{
75	1	$this->tellPos = false;
		0 ignored issues – show Documentation Bug introduced 2016-02-10 23:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$tellPos` was declared of type `integer`, but `false` is of type `false`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
76	1	$this->source = null;
77	1	}
78
79	2	public function getSize()
80		{
81	2	return $this->size;
82		}
83
84	2	public function tell()
85		{
86	2	return $this->tellPos;
87		}
88
89	2	public function eof() : bool
90		{
91	2	return !$this->source;
92		}
93
94	2	public function isSeekable() : bool
95		{
96	2	return false;
97		}
98
99		public function rewind()
100		{
101		$this->seek(0);
102		}
103
104		public function seek($offset, $whence = SEEK_SET)
105		{
106		throw new \RuntimeException('Cannot seek a PumpStream');
107		}
108
109	1	public function isWritable() : bool
110		{
111	1	return false;
112		}
113
114	1	public function write($string)
115		{
116	1	throw new \RuntimeException('Cannot write to a PumpStream');
117		}
118
119	1	public function isReadable() : bool
120		{
121	1	return true;
122		}
123
124	4	public function read($length)
125		{
126	4	$data = $this->buffer->read($length);
127	4	$readLen = strlen($data);
128	4	$this->tellPos += $readLen;
129	4	$remaining = $length - $readLen;
130
131	4	if ($remaining) {
132	4	$this->pump($remaining);
133	4	$data .= $this->buffer->read($remaining);
134	4	$this->tellPos += strlen($data) - $readLen;
135		}
136
137	4	return $data;
138		}
139
140	1	public function getContents()
141		{
142	1	$result = '';
143	1	while (!$this->eof()) {
144	1	$result .= $this->read(1000000);
145		}
146
147	1	return $result;
148		}
149
150	1	public function getMetadata($key = null)
151		{
152	1	if (!$key) {
153	1	return $this->metadata;
154		}
155
156	1	return isset($this->metadata[$key]) ? $this->metadata[$key] : null;
157		}
158
159	4	private function pump($length)
160		{
161	4	if ($this->source) {
162		do {
163	4	$data = call_user_func($this->source, $length);
164	4	if ($data === false \|\| $data === null) {
165	1	$this->source = null;
166	1	return;
167		}
168	3	$this->buffer->write($data);
169	3	$length -= strlen($data);
170	3	} while ($length > 0);
171		}
172	4	}
173		}
174

ThrusterIO / http-message

Issues (57)

Security Analysis not enabled

src/PumpStream.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like