UploadedFile::isMoved() - Code Metrics - ThrusterIO/http-message - Measure and Improve Code Quality continuously with Scrutinizer

UploadedFile::isMoved() A
last analyzed 2016-02-11 01:19 UTC

↳ Parent: UploadedFile

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	1
b	0
f	0
cc	1
eloc	2
nc	1
nop	0
crap	1

<?php

namespace Thruster\Component\HttpMessage;

use RuntimeException;
use InvalidArgumentException;
use Psr\Http\Message\StreamInterface;
use Psr\Http\Message\UploadedFileInterface;

/**
 * Class UploadedFile
 *
 * @package Thruster\Component\HttpMessage
 * @author  Aurimas Niekis <[email protected]>
 */
class UploadedFile implements UploadedFileInterface
{
    const ERRORS = [
        UPLOAD_ERR_OK,
        UPLOAD_ERR_INI_SIZE,
        UPLOAD_ERR_FORM_SIZE,
        UPLOAD_ERR_PARTIAL,
        UPLOAD_ERR_NO_FILE,
        UPLOAD_ERR_NO_TMP_DIR,
        UPLOAD_ERR_CANT_WRITE,
        UPLOAD_ERR_EXTENSION,
    ];

    /**
     * @var string
     */
    private $clientFilename;

    /**
     * @var string
     */
    private $clientMediaType;

    /**
     * @var int
     */
    private $error;

    /**
     * @var null|string
     */
    private $file;

    /**
     * @var bool
     */
    private $moved = false;

    /**
     * @var int
     */
    private $size;

    /**
     * @var StreamInterface|null
     */
    private $stream;

    /**
     * @param StreamInterface|string|resource $streamOrFile
     * @param int $size
     * @param int $errorStatus
     * @param string|null $clientFilename
     * @param string|null $clientMediaType
     */
    public function __construct(
        $streamOrFile,
        $size,
        $errorStatus,
        $clientFilename = null,
        $clientMediaType = null
    ) {
        $this->setError($errorStatus);
        $this->setSize($size);
        $this->setClientFilename($clientFilename);
        $this->setClientMediaType($clientMediaType);

        if ($this->isOk()) {
            $this->setStreamOrFile($streamOrFile);
        }
    }

    /**
     * Depending on the value set file or stream variable
     *
     * @param mixed $streamOrFile
     * @throws InvalidArgumentException
     */
    private function setStreamOrFile($streamOrFile)
    {
        if (is_string($streamOrFile)) {
            $this->file = $streamOrFile;
        } elseif (is_resource($streamOrFile)) {
            $this->stream = new Stream($streamOrFile);
        } elseif ($streamOrFile instanceof StreamInterface) {
            $this->stream = $streamOrFile;
        } else {
            throw new InvalidArgumentException(
                'Invalid stream or file provided for UploadedFile'
            );
        }
    }

    /**
     * @param int $error
     * @throws InvalidArgumentException
     */
    private function setError($error)
    {
        if (false === is_int($error)) {
            throw new InvalidArgumentException(
                'Upload file error status must be an integer'
            );
        }

        if (false === in_array($error, static::ERRORS)) {
            throw new InvalidArgumentException(
                'Invalid error status for UploadedFile'
            );
        }

        $this->error = $error;
    }

    /**
     * @param int $size
     * @throws InvalidArgumentException
     */
    private function setSize($size)
    {
        if (false === is_int($size)) {
            throw new InvalidArgumentException(
                'Upload file size must be an integer'
            );
        }

        $this->size = $size;
    }

    /**
     * @param mixed $param
     * @return boolean
     */
    private function isStringOrNull($param)
    {
        return in_array(gettype($param), ['string', 'NULL']);
    }

    /**
     * @param mixed $param
     * @return boolean
     */
    private function isStringNotEmpty($param)
    {
        return is_string($param) && false === empty($param);
    }

    /**
     * @param string|null $clientFilename
     * @throws InvalidArgumentException
     */
    private function setClientFilename($clientFilename)
    {
        if (false === $this->isStringOrNull($clientFilename)) {
            throw new InvalidArgumentException(
                'Upload file client filename must be a string or null'
            );
        }

        $this->clientFilename = $clientFilename;
    }

    /**
     * @param string|null $clientMediaType
     * @throws InvalidArgumentException
     */
    private function setClientMediaType($clientMediaType)
    {
        if (false === $this->isStringOrNull($clientMediaType)) {
            throw new InvalidArgumentException(
                'Upload file client media type must be a string or null'
            );
        }

        $this->clientMediaType = $clientMediaType;
    }

    /**
     * Return true if there is no upload error
     *
     * @return boolean
     */
    private function isOk()
    {
        return $this->error === UPLOAD_ERR_OK;
    }

    /**
     * @return boolean
     */
    public function isMoved()
    {
        return $this->moved;
    }

    /**
     * @throws RuntimeException if is moved or not ok
     */
    private function validateActive()
    {
        if (false === $this->isOk()) {
            throw new RuntimeException('Cannot retrieve stream due to upload error');
        }

        if ($this->isMoved()) {
            throw new RuntimeException('Cannot retrieve stream after it has already been moved');
        }
    }

    /**
     * {@inheritdoc}
     * @throws RuntimeException if the upload was not successful.
     */
    public function getStream()
    {
        $this->validateActive();

        if ($this->stream instanceof StreamInterface) {
            return $this->stream;
        }

        return new LazyOpenStream($this->file, 'r+');
    }

    /**
     * {@inheritdoc}
     *
     * @see http://php.net/is_uploaded_file
     * @see http://php.net/move_uploaded_file
     * @param string $targetPath Path to which to move the uploaded file.
     * @throws RuntimeException if the upload was not successful.
     * @throws InvalidArgumentException if the $path specified is invalid.
     * @throws RuntimeException on any error during the move operation, or on
     *     the second or subsequent call to the method.
     */
    public function moveTo($targetPath)
    {
        $this->validateActive();

        if (false === $this->isStringNotEmpty($targetPath)) {
            throw new InvalidArgumentException(
                'Invalid path provided for move operation; must be a non-empty string'
            );
        }

        if ($this->file) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $this->moved = php_sapi_name() == 'cli'
                ? rename($this->file, $targetPath)
                : move_uploaded_file($this->file, $targetPath);
        } else {
            copy_to_stream(
                $this->getStream(),
                new LazyOpenStream($targetPath, 'w')
            );

            $this->moved = true;
        }

        if (false === $this->moved) {
            throw new RuntimeException(
                sprintf('Uploaded file could not be moved to %s', $targetPath)
            );
        }
    }

    /**
     * {@inheritdoc}
     *
     * @return int|null The file size in bytes or null if unknown.
     */
    public function getSize()
    {
        return $this->size;
    }

    /**
     * {@inheritdoc}
     *
     * @see http://php.net/manual/en/features.file-upload.errors.php
     * @return int One of PHP's UPLOAD_ERR_XXX constants.
     */
    public function getError()
    {
        return $this->error;
    }

    /**
     * {@inheritdoc}
     *
     * @return string|null The filename sent by the client or null if none
     *     was provided.
     */
    public function getClientFilename()
    {
        return $this->clientFilename;
    }

    /**
     * {@inheritdoc}
     */
    public function getClientMediaType()
    {
        return $this->clientMediaType;
    }
}


1		<?php
2
3		namespace Thruster\Component\HttpMessage;
4
5		use RuntimeException;
6		use InvalidArgumentException;
7		use Psr\Http\Message\StreamInterface;
8		use Psr\Http\Message\UploadedFileInterface;
9
10		/**
11		* Class UploadedFile
12		*
13		* @package Thruster\Component\HttpMessage
14		* @author Aurimas Niekis <[email protected]>
15		*/
16		class UploadedFile implements UploadedFileInterface
17		{
18		const ERRORS = [
19		UPLOAD_ERR_OK,
20		UPLOAD_ERR_INI_SIZE,
21		UPLOAD_ERR_FORM_SIZE,
22		UPLOAD_ERR_PARTIAL,
23		UPLOAD_ERR_NO_FILE,
24		UPLOAD_ERR_NO_TMP_DIR,
25		UPLOAD_ERR_CANT_WRITE,
26		UPLOAD_ERR_EXTENSION,
27		];
28
29		/**
30		* @var string
31		*/
32		private $clientFilename;
33
34		/**
35		* @var string
36		*/
37		private $clientMediaType;
38
39		/**
40		* @var int
41		*/
42		private $error;
43
44		/**
45		* @var null\|string
46		*/
47		private $file;
48
49		/**
50		* @var bool
51		*/
52		private $moved = false;
53
54		/**
55		* @var int
56		*/
57		private $size;
58
59		/**
60		* @var StreamInterface\|null
61		*/
62		private $stream;
63
64		/**
65		* @param StreamInterface\|string\|resource $streamOrFile
66		* @param int $size
67		* @param int $errorStatus
68		* @param string\|null $clientFilename
69		* @param string\|null $clientMediaType
70		*/
71	74	public function __construct(
72		$streamOrFile,
73		$size,
74		$errorStatus,
75		$clientFilename = null,
76		$clientMediaType = null
77		) {
78	74	$this->setError($errorStatus);
79	65	$this->setSize($size);
80	61	$this->setClientFilename($clientFilename);
81	55	$this->setClientMediaType($clientMediaType);
82
83	49	if ($this->isOk()) {
84	27	$this->setStreamOrFile($streamOrFile);
85		}
86	42	}
87
88		/**
89		* Depending on the value set file or stream variable
90		*
91		* @param mixed $streamOrFile
92		* @throws InvalidArgumentException
93		*/
94	27	private function setStreamOrFile($streamOrFile)
95		{
96	27	if (is_string($streamOrFile)) {
97	7	$this->file = $streamOrFile;
98	20	} elseif (is_resource($streamOrFile)) {
99	1	$this->stream = new Stream($streamOrFile);
100		} elseif ($streamOrFile instanceof StreamInterface) {
101	12	$this->stream = $streamOrFile;
102		} else {
103	7	throw new InvalidArgumentException(
104	7	'Invalid stream or file provided for UploadedFile'
105		);
106		}
107	20	}
108
109		/**
110		* @param int $error
111		* @throws InvalidArgumentException
112		*/
113	74	private function setError($error)
114		{
115	74	if (false === is_int($error)) {
116	7	throw new InvalidArgumentException(
117	7	'Upload file error status must be an integer'
118		);
119		}
120
121	67	if (false === in_array($error, static::ERRORS)) {
122	2	throw new InvalidArgumentException(
123	2	'Invalid error status for UploadedFile'
124		);
125		}
126
127	65	$this->error = $error;
128	65	}
129
130		/**
131		* @param int $size
132		* @throws InvalidArgumentException
133		*/
134	65	private function setSize($size)
135		{
136	65	if (false === is_int($size)) {
137	4	throw new InvalidArgumentException(
138	4	'Upload file size must be an integer'
139		);
140		}
141
142	61	$this->size = $size;
143	61	}
144
145		/**
146		* @param mixed $param
147		* @return boolean
148		*/
149	61	private function isStringOrNull($param)
150		{
151	61	return in_array(gettype($param), ['string', 'NULL']);
152		}
153
154		/**
155		* @param mixed $param
156		* @return boolean
157		*/
158	12	private function isStringNotEmpty($param)
159		{
160	12	return is_string($param) && false === empty($param);
161		}
162
163		/**
164		* @param string\|null $clientFilename
165		* @throws InvalidArgumentException
166		*/
167	61	private function setClientFilename($clientFilename)
168		{
169	61	if (false === $this->isStringOrNull($clientFilename)) {
170	6	throw new InvalidArgumentException(
171	6	'Upload file client filename must be a string or null'
172		);
173		}
174
175	55	$this->clientFilename = $clientFilename;
176	55	}
177
178		/**
179		* @param string\|null $clientMediaType
180		* @throws InvalidArgumentException
181		*/
182	55	private function setClientMediaType($clientMediaType)
183		{
184	55	if (false === $this->isStringOrNull($clientMediaType)) {
185	6	throw new InvalidArgumentException(
186	6	'Upload file client media type must be a string or null'
187		);
188		}
189
190	49	$this->clientMediaType = $clientMediaType;
191	49	}
192
193		/**
194		* Return true if there is no upload error
195		*
196		* @return boolean
197		*/
198	49	private function isOk()
199		{
200	49	return $this->error === UPLOAD_ERR_OK;
201		}
202
203		/**
204		* @return boolean
205		*/
206	15	public function isMoved()
207		{
208	15	return $this->moved;
209		}
210
211		/**
212		* @throws RuntimeException if is moved or not ok
213		*/
214	29	private function validateActive()
215		{
216	29	if (false === $this->isOk()) {
217	14	throw new RuntimeException('Cannot retrieve stream due to upload error');
218		}
219
220	15	if ($this->isMoved()) {
221	2	throw new RuntimeException('Cannot retrieve stream after it has already been moved');
222		}
223	15	}
224
225		/**
226		* {@inheritdoc}
227		* @throws RuntimeException if the upload was not successful.
228		*/
229	13	public function getStream()
230		{
231	13	$this->validateActive();
232
233	6	if ($this->stream instanceof StreamInterface) {
234	5	return $this->stream;
235		}
236
237	1	return new LazyOpenStream($this->file, 'r+');
238		}
239
240		/**
241		* {@inheritdoc}
242		*
243		* @see http://php.net/is_uploaded_file
244		* @see http://php.net/move_uploaded_file
245		* @param string $targetPath Path to which to move the uploaded file.
246		* @throws RuntimeException if the upload was not successful.
247		* @throws InvalidArgumentException if the $path specified is invalid.
248		* @throws RuntimeException on any error during the move operation, or on
249		* the second or subsequent call to the method.
250		*/
251	19	public function moveTo($targetPath)
252		{
253	19	$this->validateActive();
254
255	12	if (false === $this->isStringNotEmpty($targetPath)) {
256	8	throw new InvalidArgumentException(
257	8	'Invalid path provided for move operation; must be a non-empty string'
258		);
259		}
260
261	4	if ($this->file) {
		0 ignored issues – show Bug Best Practice introduced 2016-02-10 23:41 UTC by Report Bug Copy Issue Report The expression `$this->file` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
262	1	$this->moved = php_sapi_name() == 'cli'
263	1	? rename($this->file, $targetPath)
264	1	: move_uploaded_file($this->file, $targetPath);
265		} else {
266	3	copy_to_stream(
267	3	$this->getStream(),
268	3	new LazyOpenStream($targetPath, 'w')
269		);
270
271	3	$this->moved = true;
272		}
273
274	4	if (false === $this->moved) {
275		throw new RuntimeException(
276		sprintf('Uploaded file could not be moved to %s', $targetPath)
277		);
278		}
279	4	}
280
281		/**
282		* {@inheritdoc}
283		*
284		* @return int\|null The file size in bytes or null if unknown.
285		*/
286	1	public function getSize()
287		{
288	1	return $this->size;
289		}
290
291		/**
292		* {@inheritdoc}
293		*
294		* @see http://php.net/manual/en/features.file-upload.errors.php
295		* @return int One of PHP's UPLOAD_ERR_XXX constants.
296		*/
297	7	public function getError()
298		{
299	7	return $this->error;
300		}
301
302		/**
303		* {@inheritdoc}
304		*
305		* @return string\|null The filename sent by the client or null if none
306		* was provided.
307		*/
308	1	public function getClientFilename()
309		{
310	1	return $this->clientFilename;
311		}
312
313		/**
314		* {@inheritdoc}
315		*/
316	1	public function getClientMediaType()
317		{
318	1	return $this->clientMediaType;
319		}
320		}
321

ThrusterIO / http-message

UploadedFile::isMoved() A last analyzed 2016-02-11 01:19 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

UploadedFile::isMoved() A
last analyzed 2016-02-11 01:19 UTC