Thruster\Action\DoctrineActions\DoctrinePersistActionExecutor

Complexity

Total Complexity

5

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getEntityManager()	0	4	1
A	execute()	0	12	2
A	getSupportedAction()	0	4	1

<?php

namespace Thruster\Action\DoctrineActions;

use Doctrine\ORM\EntityManager;
use Thruster\Component\Actions\ActionExecutorInterface;

/**
 * Class DoctrinePersistActionExecutor
 *
 * @package Thruster\Action\DoctrineActions
 * @author  Aurimas Niekis <aurimas@niekis.lt>
 */
class DoctrinePersistActionExecutor implements ActionExecutorInterface
{
    /**
     * @var EntityManager
     */
    protected $entityManager;

    /**
     * @param EntityManager $entityManager
     */
    public function __construct(EntityManager $entityManager)

You have injected the EntityManager via parameter $entityManager. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via getManager() each time you need it.

    {
        $this->entityManager = $entityManager;
    }

    /**
     * @return EntityManager
     */
    public function getEntityManager() : EntityManager
    {
        return $this->entityManager;
    }

    /**
     * @inheritDoc
     */
    public function execute(array $arguments) : array
    {
        $entityManager = $this->getEntityManager();

        foreach ($arguments as $argument) {
            $entityManager->persist($argument);
        }

        $entityManager->flush();

        return $arguments;
    }

    /**
     * @inheritDoc
     */
    public static function getSupportedAction() : string
    {
        return 'thruster_doctrine_persist_action';
    }

}