Thruster\Component\Dns\MultiServerResolver

Complexity

Total Complexity

7

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	resolve()	0	10	1
A	getNameServerSelectFunction()	0	9	3
A	getNameServerRandom()	0	4	1
A	getNameServerRoundRobin()	0	6	1

<?php

namespace Thruster\Component\Dns;

use Thruster\Component\EventLoop\EventLoopInterface;
use Thruster\Component\Promise\PromiseInterface;

/**
 * Class MultiServerResolver
 *
 * @package Thruster\Component\Dns
 * @author  Aurimas Niekis <aurimas@niekis.lt>
 */
class MultiServerResolver extends Resolver
{
    const STRATEGY_RANDOM = 1;
    const STRATEGY_ROUND_ROBIN = 2;

    /**
     * @var string[]
     */
    private $nameServers;

    /**
     * @var int
     */
    private $picker;

    /**
     * @var int
     */
    private $current = 0;

    public function __construct(array $nameServers, ExecutorInterface $executor, int $strategy = self::STRATEGY_RANDOM)
    {
        $this->nameServers = $nameServers;
        $this->picker      = $this->getNameServerSelectFunction($strategy);

It seems like $this->getNameServerSelectFunction($strategy) can also be of type string. However, the property $picker is declared as type integer. Maybe add an additional type check?

        parent::__construct('', $executor);
    }

    public function resolve(string $domain) : PromiseInterface
    {
        $query = new Query($domain, Message::TYPE_A, Message::CLASS_IN, time());

        $nameServer = $this->{$this->picker}();

        var_dump($nameServer);

var_dump($nameServer); looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data.

        return $this->resolveInternal($nameServer, $query);
    }

    private function getNameServerSelectFunction(int $strategy)
    {
        switch ($strategy) {
            case self::STRATEGY_RANDOM:
                return 'getNameServerRandom';
            case self::STRATEGY_ROUND_ROBIN:
                return 'getNameServerRoundRobin';
        }
    }

    private function getNameServerRandom() : string
    {
        return $this->nameServers[array_rand($this->nameServers)];
    }

    private function getNameServerRoundRobin() : string
    {
        $this->current += 1;

        return $this->nameServers[$this->current % count($this->nameServers)];
    }
}