DataModifierAwareTrait - Code Metrics - ThrusterIO/data-modifier-bundle - Measure and Improve Code Quality continuously with Scrutinizer

DataModifierAwareTrait A
last analyzed 2015-12-05 15:42 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	16
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

100%

Metric	Value
wmc	3
lcom	0
cbo	0
dl	0
loc	16
ccs	7
cts	7
cp	1
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
A	getDataModifierGroup()	0	13	3

<?php

namespace Thruster\Bundle\DataModifierBundle;

use Thruster\Component\DataModifier\DataModifierGroup;

/**
 * Trait DataModifierAwareTrait
 *
 * @package Thruster\Bundle\DataModifierBundle
 * @author  Aurimas Niekis <[email protected]>
 */
trait DataModifierAwareTrait
{
    public function getDataModifierGroup(string $groupName) : DataModifierGroup
    {
        if (property_exists($this, 'container')) {
            return $this->container->get('thruster_data_modifiers')->getGroup($groupName);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        } elseif (method_exists($this, 'getContainer')) {
            return $this->getContainer()->get('thruster_data_modifiers')->getGroup($groupName);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }

        throw new \LogicException(
            'DataModifierAwareTrait require Symfony Container accessible via property' .
            '$container or ->getContainer() method'
        );
    }
}


1		<?php
2
3		namespace Thruster\Bundle\DataModifierBundle;
4
5		use Thruster\Component\DataModifier\DataModifierGroup;
6
7		/**
8		* Trait DataModifierAwareTrait
9		*
10		* @package Thruster\Bundle\DataModifierBundle
11		* @author Aurimas Niekis <[email protected]>
12		*/
13		trait DataModifierAwareTrait
14		{
15	3	public function getDataModifierGroup(string $groupName) : DataModifierGroup
16		{
17	3	if (property_exists($this, 'container')) {
18	1	return $this->container->get('thruster_data_modifiers')->getGroup($groupName);
		0 ignored issues – show Bug introduced 2015-12-05 15:42 UTC by Report Bug Copy Issue Report The property `container` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
19	2	} elseif (method_exists($this, 'getContainer')) {
20	1	return $this->getContainer()->get('thruster_data_modifiers')->getGroup($groupName);
		0 ignored issues – show Bug introduced 2015-12-05 15:42 UTC by Report Bug Copy Issue Report It seems like `getContainer()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
21		}
22
23	1	throw new \LogicException(
24		'DataModifierAwareTrait require Symfony Container accessible via property' .
25	1	'$container or ->getContainer() method'
26		);
27		}
28		}
29

ThrusterIO / data-modifier-bundle

DataModifierAwareTrait A last analyzed 2015-12-05 15:42 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

1 Method

Duplication Side-by-Side

Filter issues like

DataModifierAwareTrait A
last analyzed 2015-12-05 15:42 UTC