ActionsAwareTrait::executeActions() - Code Metrics - ThrusterIO/actions-bundle - Measure and Improve Code Quality continuously with Scrutinizer

ActionsAwareTrait::executeActions() A
last analyzed 2015-12-05 17:04 UTC

↳ Parent: ActionsAwareTrait

Complexity

Conditions	3
Paths	3

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	13
ccs	7
cts	7
cp	1
rs	9.4286
cc	3
eloc	8
nc	3
nop	1
crap	3

<?php

namespace Thruster\Bundle\ActionsBundle;

use Thruster\Component\Actions\ActionInterface;

/**
 * Trait ActionsAwareTrait
 *
 * @package Thruster\Bundle\ActionsBundle
 * @author  Aurimas Niekis <[email protected]>
 */
trait ActionsAwareTrait
{
    public function executeActions(ActionInterface $action)
    {
        if (property_exists($this, 'container')) {
            return $this->container->get('thruster_actions.executor')->execute($action);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        } elseif (method_exists($this, 'getContainer')) {
            return $this->getContainer()->get('thruster_actions.executor')->execute($action);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }

        throw new \LogicException(
            'ActionsAwareTrait require Symfony Container accessible via property' .
            '$container or ->getContainer() method'
        );
    }
}


1		<?php
2
3		namespace Thruster\Bundle\ActionsBundle;
4
5		use Thruster\Component\Actions\ActionInterface;
6
7		/**
8		* Trait ActionsAwareTrait
9		*
10		* @package Thruster\Bundle\ActionsBundle
11		* @author Aurimas Niekis <[email protected]>
12		*/
13		trait ActionsAwareTrait
14		{
15	3	public function executeActions(ActionInterface $action)
16		{
17	3	if (property_exists($this, 'container')) {
18	1	return $this->container->get('thruster_actions.executor')->execute($action);
		0 ignored issues – show Bug introduced 2015-12-05 17:04 UTC by Report Bug Copy Issue Report The property `container` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
19	2	} elseif (method_exists($this, 'getContainer')) {
20	1	return $this->getContainer()->get('thruster_actions.executor')->execute($action);
		0 ignored issues – show Bug introduced 2015-12-05 17:04 UTC by Report Bug Copy Issue Report It seems like `getContainer()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
21		}
22
23	1	throw new \LogicException(
24		'ActionsAwareTrait require Symfony Container accessible via property' .
25	1	'$container or ->getContainer() method'
26		);
27		}
28		}
29

ThrusterIO / actions-bundle

ActionsAwareTrait::executeActions() A last analyzed 2015-12-05 17:04 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

ActionsAwareTrait::executeActions() A
last analyzed 2015-12-05 17:04 UTC